Skip to contentSkip to conversation

docs/devel/build-system: Update an example

PATCH Superseded Philippe Mathieu-Daudé 2 participants 3 messages May 15, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs/devel/build-system: Update an example

The default-configs/ example added in 717171bd2025 is no more accurate since fa212a2b8b60 (and various further other commits).

The Kconfig build system is now in place.
Use the aarch64-softmmu config as example.

---
 docs/devel/build-system.txt | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
docs/devel/build-system.txt +5 -10
index addd274eebd..79a85bfba06 100644
@@ -415,16 +415,11 @@ context.
 The files under default-configs/ control what emulated hardware is built
 into each QEMU system and userspace emulator targets. They merely
 contain a long list of config variable definitions. For example,
-default-configs/x86_64-softmmu.mak has:
-
-  include sound.mak
-  include usb.mak
-  CONFIG_QXL=$(CONFIG_SPICE)
-  CONFIG_VGA_ISA=y
-  CONFIG_VGA_CIRRUS=y
-  CONFIG_VMWARE_VGA=y
-  CONFIG_VIRTIO_VGA=y
-  ...snip...
+default-configs/aarch64-softmmu.mak has:
+
+  include arm-softmmu.mak
+  CONFIG_XLNX_ZYNQMP_ARM=y
+  CONFIG_XLNX_VERSAL=y
 
 These files rarely need changing unless new devices / hardware need to
 be enabled for a particular system/userspace emulation target
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Philippe Mathieu-Daudé

The default-configs/ example added in 717171bd2025 is no more accurate since fa212a2b8b60 (and various further other commits).

The Kconfig build system is now in place.
Use the aarch64-softmmu config as example.

---
 docs/devel/build-system.txt | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
docs/devel/build-system.txt +0 -0
index addd274eebd..79a85bfba06 100644

docs/devel/build-system.txt context. · line 417

Quoted 3 lines
docs/devel/build-system.txt +0 -0
@@ -415,16 +415,11 @@ context.
 The files under default-configs/ control what emulated hardware is built
 into each QEMU system and userspace emulator targets. They merely
 contain a long list of config variable definitions. For example,

"long list" is now often also not very accurate anymore. Maybe rephrase that sentence à la: "contain a list of config variable definitions like the machines that should be included" ?

Quoted 9 lines
docs/devel/build-system.txt +0 -8
-default-configs/x86_64-softmmu.mak has:
-
-  include sound.mak
-  include usb.mak
-  CONFIG_QXL=$(CONFIG_SPICE)
-  CONFIG_VGA_ISA=y
-  CONFIG_VGA_CIRRUS=y
-  CONFIG_VMWARE_VGA=y

docs/devel/build-system.txt context. · line 425

Quoted 10 lines
docs/devel/build-system.txt +5 -2
-  CONFIG_VIRTIO_VGA=y
-  ...snip...
+default-configs/aarch64-softmmu.mak has:
+
+  include arm-softmmu.mak
+  CONFIG_XLNX_ZYNQMP_ARM=y
+  CONFIG_XLNX_VERSAL=y
 
 These files rarely need changing unless new devices / hardware need to
 be enabled for a particular system/userspace emulation target

Anyway,

#2 lore raw
Quoted 13 lines · Thomas Huth
Quoted 12 lines · Philippe Mathieu-Daudé

The default-configs/ example added in 717171bd2025 is no more accurate since fa212a2b8b60 (and various further other commits).

The Kconfig build system is now in place.
Use the aarch64-softmmu config as example.

---
 docs/devel/build-system.txt | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)
Quoted 10 lines

docs/devel/build-system.txt context. · line 417

Quoted 8 lines
docs/devel/build-system.txt +0 -0
index addd274eebd..79a85bfba06 100644
@@ -415,16 +415,11 @@ context.
 The files under default-configs/ control what emulated hardware is built
 into each QEMU system and userspace emulator targets. They merely
 contain a long list of config variable definitions. For example,

"long list" is now often also not very accurate anymore. Maybe rephrase

Still accurate for MIPS :(

Quoted 2 lines

that sentence à la: "contain a list of config variable definitions like the machines that should be included" ?

Good idea.

Quoted 17 lines
Quoted 17 lines
docs/devel/build-system.txt +5 -10
-default-configs/x86_64-softmmu.mak has:
-
-  include sound.mak
-  include usb.mak
-  CONFIG_QXL=$(CONFIG_SPICE)
-  CONFIG_VGA_ISA=y
-  CONFIG_VGA_CIRRUS=y
-  CONFIG_VMWARE_VGA=y
-  CONFIG_VIRTIO_VGA=y
-  ...snip...
+default-configs/aarch64-softmmu.mak has:
+
+  include arm-softmmu.mak
+  CONFIG_XLNX_ZYNQMP_ARM=y
+  CONFIG_XLNX_VERSAL=y
 
Quoted 8 lines

docs/devel/build-system.txt context. · line 425

Quoted 3 lines
docs/devel/build-system.txt +0 -0
 These files rarely need changing unless new devices / hardware need to
 be enabled for a particular system/userspace emulation target

Anyway,

Thanks!

Phil.