package/ffmpeg: Fix ranlib check when cross-compiling
cover package/ffmpeg: Fix ranlib check when cross-compiling
Hi,
this is a different approach to fix the build error.
Please compare my patch with http://patchwork.ozlabs.org/patch/461843/
I am not sure what the best fix would be, therefore I have not yet sent my patch upstream.
Regards, Bernd
PATCH 1/1 package/ffmpeg: Fix ranlib check when cross-compiling
Fixes
http://autobuild.buildroot.net/results/d13/d13488a43f6e034623104a36c07114db99325b8d/
--- package/ffmpeg/0016-ranlib.patch | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 package/ffmpeg/0016-ranlib.patch
package/ffmpeg/0016-ranlib.patch new file +35 -0
@@ -0,0 +1,35 @@ +Fix ranlib check when cross-compiling + +Without this patch /usr/bin/ranlib is tested for "-D", not ranlib from the +cross-compiler suite being in use. + +Signed-off-by: Bernd Kuhls <[email protected]> + +diff -uNr ffmpeg-2.6.2.org/configure ffmpeg-2.6.2/configure +--- ffmpeg-2.6.2.org/configure 2015-04-12 00:47:55.000000000 +0200 ++++ ffmpeg-2.6.2/configure 2015-04-16 21:53:24.313202517 +0200 +@@ -2719,11 +2719,6 @@ + nm_default="nm -g" + objformat="elf" + pkg_config_default=pkg-config +-if ranlib 2>&1 | grep -q "\-D "; then +- ranlib_default="ranlib -D" +-else +- ranlib_default="ranlib" +-fi + strip_default="strip" + yasmexe_default="yasm" + windres_default="windres" +@@ -3001,6 +2996,12 @@ + die "Must specify target arch and OS when cross-compiling" + fi + ++if "${cross_prefix}ranlib" 2>&1 | grep -q "\-D "; then ++ ranlib_default="ranlib -D" ++else ++ ranlib_default="ranlib" ++fi ++ + test -n "$valgrind" && toolchain="valgrind-memcheck" + + case "$toolchain" in
Signature · 1 line
1.7.10.4
PATCH 1/1 package/ffmpeg: Fix ranlib check when cross-compiling
Dear Bernd Kuhls,
Quoted 8 lines · Bernd Kuhls
Fixes
http://autobuild.buildroot.net/results/d13/d13488a43f6e034623104a36c07114db99325b8d/Signed-off-by Bernd Kuhls <[email protected]>--- package/ffmpeg/0016-ranlib.patch | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 package/ffmpeg/0016-ranlib.patch
I've applied this patch. Please submit it upstream, and give us some feedback on upstream's reaction. One thing I'm wondering is whether with your patch, the --ranlib= option continues to work.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
cover package/ffmpeg: Fix ranlib check when cross-compiling
In reply to Bernd KuhlsQuoted 7 lines · Bernd Kuhls
Hi,
this is a different approach to fix the build error.
Please compare my patch with http://patchwork.ozlabs.org/patch/461843/I am not sure what the best fix would be, therefore I have not yet sent my patch upstream.
I'm OK with either solution. I propose that you send your patch upstream, see
how they react, and if it's positive then we go with yours. If they don't accept it, then I think that not patching (i.e. my solution) is better.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F