ffmpeg: explicitly pass --ranlib
PATCH 1/1 ffmpeg: explicitly pass --ranlib
It seems that ffmpeg's custom configure doesn't observe the RANLIB environment variable, and incorrectly uses the host's ranlib to check if the -D option is supported. Blackfin's ranlib doesn't, most others do.
I also checked if there are any more mistakes like that in ffmpeg's configure script, but it looked OK.
Fixes:
http://autobuild.buildroot.net/results/d13488a43f6e034623104a36c07114db99325b8d
--- package/ffmpeg/ffmpeg.mk | 1 + 1 file changed, 1 insertion(+)
package/ffmpeg/ffmpeg.mk +1 -0
@@ -18,6 +18,7 @@ endif FFMPEG_CONF_OPTS = \ --prefix=/usr \ + --ranlib=$(TARGET_RANLIB) \ --enable-avfilter \ --disable-version3 \ --enable-logging \
Signature · 1 line
2.1.4
PATCH 1/1 ffmpeg: explicitly pass --ranlib
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> wrote in news:1429214355-29429-1-git-send-email-arnout at mind.be:
Quoted 1 line
+ --ranlib=$(TARGET_RANLIB) \
Hi,
are you sure that your patch changes the behaviour of
http://git.videolan.org/?
p=ffmpeg.git;a=blob;f=configure;h=c11262a66c5ce8906f1a06bb54de3ab1e964dfb0;hb =HEAD#l2760
when testing ranlib features?
I am asking this because the configure options are stored into script variables in line 3019[1], whereas the ranlib test occurs in line 2760 already.
Regards, Bernd
[1] http://git.videolan.org/?
p=ffmpeg.git;a=blob;f=configure;h=c11262a66c5ce8906f1a06bb54de3ab1e964dfb0;hb =HEAD#l3019
PATCH 1/1 ffmpeg: explicitly pass --ranlib
Quoted 12 lines · Bernd Kuhls
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> wrote in news:1429214355-29429-1-git-send-email-arnout at mind.be:
Quoted 1 line
+ --ranlib=$(TARGET_RANLIB) \
Hi,
are you sure that your patch changes the behaviour of
http://git.videolan.org/?
p=ffmpeg.git;a=blob;f=configure;h=c11262a66c5ce8906f1a06bb54de3ab1e964dfb0;hb =HEAD#l2760
Quoted 4 lines
when testing ranlib features?
I am asking this because the configure options are stored into script variables in line 3019[1], whereas the ranlib test occurs in line 2760 already.
It doesn't change the behaviour of the ranlib_default test, but since we pass
the ranlib invocation explicitly on the commandline the default is not used. And I did check that it solves the autobuild error (which I could reproduce locally).
Regards,
Arnout
Quoted 13 lines
Regards, Bernd
[1] http://git.videolan.org/?
p=ffmpeg.git;a=blob;f=configure;h=c11262a66c5ce8906f1a06bb54de3ab1e964dfb0;hb =HEAD#l3019_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 ffmpeg: explicitly pass --ranlib
In reply to Arnout Vandecappelle (Essensium/Mind)Arnout, All,
On 2015-04-16 21:59 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
Quoted 7 lines
It seems that ffmpeg's custom configure doesn't observe the RANLIB environment variable, and incorrectly uses the host's ranlib to check if the -D option is supported. Blackfin's ranlib doesn't, most others do.
I also checked if there are any more mistakes like that in ffmpeg's configure script, but it looked OK.
Your wording "ffmpeg's configure" prompted me to look at ffmpeg, and so here's my thoughts about it...
Given that ffmpeg is not using autoconf, automake and co., it should not be usign the autotools-package infra, but should be switched over to using the generic-package infra instead.
OK, not your fault! ;-)
Regards,
Yann E. MORIN.
Quoted 28 lines
Fixes:
http://autobuild.buildroot.net/results/d13488a43f6e034623104a36c07114db99325b8dCc Bernd Kuhs <[email protected]>--- package/ffmpeg/ffmpeg.mk | 1 + 1 file changed, 1 insertion(+)package/ffmpeg/ffmpeg.mk +1
-0@@ -18,6 +18,7 @@ endif FFMPEG_CONF_OPTS = \ --prefix=/usr \ + --ranlib=$(TARGET_RANLIB) \ --enable-avfilter \ --disable-version3 \ --enable-logging \Signature · 6 lines
2.1.4 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'