Skip to contentSkip to conversation

fs/btrfs: use inode_set_flags() instead of set_mask_bits()

PATCH New Zhang Zhen 1 participant 3 messages Apr 20, 2015 – Jun 4, 2015 1 message not in the archive Btrfs file system

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Zhang Zhen

author
#1 lore raw

PATCH 1/1 fs/btrfs: use inode_set_flags() instead of set_mask_bits()

Use inode_set_flags() instead of set_mask_bits() according to commit 5f16f3225b062 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
---
 fs/btrfs/ioctl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/ioctl.c +2 -3
index 74609b9..728b487 100644
@@ -149,9 +149,8 @@ void btrfs_update_iflags(struct inode *inode)
 	if (ip->flags & BTRFS_INODE_DIRSYNC)
 		new_fl |= S_DIRSYNC;
 
-	set_mask_bits(&inode->i_flags,
-		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC,
-		      new_fl);
+	inode_set_flags(inode, new_fl,
+		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC);
 }
 
 /*
Signature · 4 lines
1.9.1


.
author
#2 lore raw

PATCH 1/1 fs/btrfs: use inode_set_flags() instead of set_mask_bits()

In reply to a message not in the archive

Use inode_set_flags() instead of set_mask_bits() according to commit 5f16f3225b062 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
---
 fs/btrfs/ioctl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/ioctl.c +2 -3
index 74609b9..728b487 100644
@@ -149,9 +149,8 @@ void btrfs_update_iflags(struct inode *inode)
 	if (ip->flags & BTRFS_INODE_DIRSYNC)
 		new_fl |= S_DIRSYNC;
 
-	set_mask_bits(&inode->i_flags,
-		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC,
-		      new_fl);
+	inode_set_flags(inode, new_fl,
+		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC);
 }
 
 /*
Signature · 4 lines
1.9.1


.
author
#3 lore raw

PATCH 1/1 fs/btrfs: use general inode_set_flags() instead of set_mask_bits()

Use general inode_set_flags() instead of set_mask_bits() according to commit 5f16f3225b062 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
---
 fs/btrfs/ioctl.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/btrfs/ioctl.c +2 -3
index 74609b9..728b487 100644
@@ -149,9 +149,8 @@ void btrfs_update_iflags(struct inode *inode)
 	if (ip->flags & BTRFS_INODE_DIRSYNC)
 		new_fl |= S_DIRSYNC;
 
-	set_mask_bits(&inode->i_flags,
-		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC,
-		      new_fl);
+	inode_set_flags(inode, new_fl,
+		      S_SYNC | S_APPEND | S_IMMUTABLE | S_NOATIME | S_DIRSYNC);
 }
 
 /*
Signature · 4 lines
1.9.1


.