Skip to contentSkip to conversation

modetest: fix misc when terminates modetest

PATCH In review Joonyoung Shim 2 participants 5 messages Apr 13, 2015 – Apr 29, 2015

lore
Share & tools
lore

Joonyoung Shim

author
#0 lore raw

cover modetest: fix misc when terminates modetest

Hi all,

This patchset is to fix properly about buffer and framebuffer resources when terminates modetest of libdrm.

Thanks.

Joonyoung Shim (5):
modetest: fix Segmentation fault
modetest: add to use drmModeRmFB
modetest: fix to proper error path handling
modetest: clear buffer and framebuffer of planes
modetest: destroy buffer of cursor

 tests/modetest/modetest.c | 49 ++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 44 insertions(+), 5 deletions(-)

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#1 lore raw

Hi Joonyoung,

Quoted 5 lines · Joonyoung Shim

Hi all,

This patchset is to fix properly about buffer and framebuffer resources when terminates modetest of libdrm.

The series looks great (incl. the MAKE_RGB_INFO fix) and barring any objections I'll push it by the end of the week. Just a small sidenote - some of the commit messages are a bit hard to read. Hope you don't mind if I change them slightly before pushing.

Thanks
Emil

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

author
#2 lore raw

Hi Emil,

Quoted 5 lines · Emil Velikov

Hi Joonyoung,

Quoted 2 lines · Joonyoung Shim

Hi all,

Quoted 7 lines
Quoted 3 lines

This patchset is to fix properly about buffer and framebuffer resources when terminates modetest of libdrm.

The series looks great (incl. the MAKE_RGB_INFO fix) and barring any objections I'll push it by the end of the week. Just a small sidenote - some of the commit messages are a bit hard to read. Hope you don't mind if I change them slightly before pushing.

It's ok, i guess i should thank you.

Thanks.
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 11 lines · Joonyoung Shim

Hi Emil,

Quoted 8 lines · Emil Velikov

Hi Joonyoung,

Quoted 5 lines · Joonyoung Shim

Hi all,

This patchset is to fix properly about buffer and framebuffer resources when terminates modetest of libdrm.

Quoted 7 lines
Quoted 4 lines

The series looks great (incl. the MAKE_RGB_INFO fix) and barring any objections I'll push it by the end of the week. Just a small sidenote - some of the commit messages are a bit hard to read. Hope you don't mind if I change them slightly before pushing.

It's ok, i guess i should thank you.

I seriously won't be offended if you don't, so it's entirely up-to you.

Cheers
Emil

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
In reply to Joonyoung Shim
Quoted 11 lines · Joonyoung Shim

Hi Emil,

Quoted 8 lines · Emil Velikov

Hi Joonyoung,

Quoted 5 lines · Joonyoung Shim

Hi all,

This patchset is to fix properly about buffer and framebuffer resources when terminates modetest of libdrm.

Quoted 7 lines
Quoted 4 lines

The series looks great (incl. the MAKE_RGB_INFO fix) and barring any objections I'll push it by the end of the week. Just a small sidenote - some of the commit messages are a bit hard to read. Hope you don't mind if I change them slightly before pushing.

It's ok, i guess i should thank you.

In case you've missed it - I corrected the value for invalid fb_id. According to the kernel and other users - 0 should be used, as (unsigned int)-1 (used in the series) is valid one, albeit hard to hit.

Thanks again for the fixes.

-Emil
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel