memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()
Subsystems (2)
PATCH v3 2/2 memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat()
After hotadd_new_pgdat()->free_area_init_node(), pgdat's spanned/present are 0, and zone's spanned/present/managed are 0, so remove reset_node_managed_pages() and reset_node_managed_pages().
Signed-off-by Xishi Qiu <[email protected]>
--- mm/memory_hotplug.c | 25 ------------------------- 1 files changed, 0 insertions(+), 25 deletions(-)
mm/memory_hotplug.c +0 -25
@@ -1064,16 +1064,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ }#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */ -static void reset_node_present_pages (pg_data_t *pgdat) -{ -struct zone *z; - -for (z = pgdat->node_zones; z < pgdat->node_zones +MAX_NR_ZONES ; z++) - z->present_pages =0 ; - - pgdat->node_present_pages =0 ; -} -/* we are OK calling __meminit stuff here - we have CONFIG_MEMORY_HOTPLUG */ static pg_data_t __ref *hotadd_new_pgdat (int nid,u64 start) {
@@ -1108,21 +1098,6 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)build_all_zonelists (pgdat,NULL );mutex_unlock (&zonelists_mutex); -/* -* zone->managed_pages is set to an approximate value in -* free_area_init_core(), which will cause -* /sys/device/system/node/nodeX/meminfo has wrong data. -* So reset it to 0 before any memory is onlined. -*/ -reset_node_managed_pages (pgdat); - -/* -* When memory is hot-added, all the memory is in offline state. So -* clear all zones' present_pages because they will be updated in -* online_pages() and offline_pages(). -*/ -reset_node_present_pages (pgdat); -return pgdat; }
Signature · 1 line
1.7.1
add CC: Tejun Heo <[email protected]>
Quoted 52 lines · Xishi Qiu
After hotadd_new_pgdat()->free_area_init_node(), pgdat's spanned/present are 0, and zone's spanned/present/managed are 0, so remove
reset_node_managed_pages()andreset_node_managed_pages().Signed-off-by Xishi Qiu <[email protected]>--- mm/memory_hotplug.c | 25 ------------------------- 1 files changed, 0 insertions(+), 25 deletions(-)mm/memory_hotplug.c +0
-25@@ -1064,16 +1064,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ }#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */ -static void reset_node_present_pages (pg_data_t *pgdat) -{ -struct zone *z; - -for (z = pgdat->node_zones; z < pgdat->node_zones +MAX_NR_ZONES ; z++) - z->present_pages =0 ; - - pgdat->node_present_pages =0 ; -} -/* we are OK calling __meminit stuff here - we have CONFIG_MEMORY_HOTPLUG */ static pg_data_t __ref *hotadd_new_pgdat (int nid,u64 start) {@@ -1108,21 +1098,6 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start)build_all_zonelists (pgdat,NULL );mutex_unlock (&zonelists_mutex); -/* -* zone->managed_pages is set to an approximate value in -* free_area_init_core(), which will cause -* /sys/device/system/node/nodeX/meminfo has wrong data. -* So reset it to 0 before any memory is onlined. -*/ -reset_node_managed_pages (pgdat); - -/* -* When memory is hot-added, all the memory is in offline state. So -* clear all zones' present_pages because they will be updated in -* online_pages() and offline_pages(). -*/ -reset_node_present_pages (pgdat); -return pgdat; }