Skip to contentSkip to conversation

uboot: add default for BR2_TARGET_UBOOT_PATCH

PATCH New Frank Hunleth 3 participants 5 messages Apr 21, 2015 – Apr 24, 2015

lore
Share & tools
lore

Frank Hunleth

author
#0 lore raw

PATCH 1/1 uboot: add default for BR2_TARGET_UBOOT_PATCH

Automatically copy over the value from BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR to make handling its deprecation easier. Thanks to Arnout for the suggestion.

Signed-off-by Frank Hunleth <[email protected]>
---
 boot/uboot/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/uboot/Config.in +1 -0
index 4f01499..419b183 100644
@@ -84,6 +84,7 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
 
 config BR2_TARGET_UBOOT_PATCH
 	string "Custom U-Boot patches"
+	default BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
 	help
 	  A space-separated list of patches to apply to U-Boot.
 	  Each patch can be described as an URL, a local file path,
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 uboot: add default for BR2_TARGET_UBOOT_PATCH

Dear Frank Hunleth,

Quoted 14 lines · Frank Hunleth

Automatically copy over the value from BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR to make handling its deprecation easier. Thanks to Arnout for the suggestion.

Signed-off-by Frank Hunleth <[email protected]>
---
 boot/uboot/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/uboot/Config.in +0 -0
index 4f01499..419b183 100644

boot/uboot/Config.in config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR · line 90

Quoted 7 lines
boot/uboot/Config.in +1 -0
@@ -84,6 +84,7 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
 
 config BR2_TARGET_UBOOT_PATCH
 	string "Custom U-Boot patches"
+	default BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
 	help
 	  A space-separated list of patches to apply to U-Boot.
 	  Each patch can be described as an URL, a local file path,

Does this actually works? I've tried removing BR2_TARGET_UBOOT_PATCH="" from my .config, add BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR="foo bar", and ran 'make menuconfig'. I was hoping to see "foo bar" in BR2_TARGET_UBOOT_PATCH, but it wasn't the case. Am I missing something?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 uboot: add default for BR2_TARGET_UBOOT_PATCH

Quoted 19 lines · Thomas Petazzoni

Dear Frank Hunleth,

Quoted 15 lines · Frank Hunleth

Automatically copy over the value from BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR to make handling its deprecation easier. Thanks to Arnout for the suggestion.

Signed-off-by Frank Hunleth <[email protected]>
---
 boot/uboot/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/uboot/Config.in +0 -0
index 4f01499..419b183 100644
@@ -84,6 +84,7 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
Quoted 12 lines

boot/uboot/Config.in config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR · line 90

Quoted 6 lines
boot/uboot/Config.in +1 -0
 config BR2_TARGET_UBOOT_PATCH
      string "Custom U-Boot patches"
+     default BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
      help
        A space-separated list of patches to apply to U-Boot.
        Each patch can be described as an URL, a local file path,

Does this actually works? I've tried removing BR2_TARGET_UBOOT_PATCH="" from my .config, add BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR="foo bar", and ran 'make menuconfig'. I was hoping to see "foo bar" in BR2_TARGET_UBOOT_PATCH, but it wasn't the case. Am I missing something?

It only works if you have BR2_DEPRECATED_SINCE_2015_05 enabled. I almost posted an email asking how useful this was. I very rarely enable BR2_DEPRECATED. However, I justified it to myself that if nothing else, it was documentation that the former value in BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR could be copied verbatim.

FWIW, I did try reordering the options to see if putting BR2_TARGET_UBOOT_PATCH first would make this work, but it didn't change the results on my end.

Frank

#3 lore raw

PATCH 1/1 uboot: add default for BR2_TARGET_UBOOT_PATCH

Quoted 34 lines · Frank Hunleth
Quoted 19 lines · Thomas Petazzoni

Dear Frank Hunleth,

Quoted 15 lines · Frank Hunleth

Automatically copy over the value from BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR to make handling its deprecation easier. Thanks to Arnout for the suggestion.

Signed-off-by Frank Hunleth <[email protected]>
---
 boot/uboot/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/uboot/Config.in +0 -0
index 4f01499..419b183 100644
@@ -84,6 +84,7 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
Quoted 12 lines

boot/uboot/Config.in config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR · line 90

Quoted 6 lines
boot/uboot/Config.in +1 -0
 config BR2_TARGET_UBOOT_PATCH
      string "Custom U-Boot patches"
+     default BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
      help
        A space-separated list of patches to apply to U-Boot.
        Each patch can be described as an URL, a local file path,

Does this actually works? I've tried removing BR2_TARGET_UBOOT_PATCH="" from my .config, add BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR="foo bar", and ran 'make menuconfig'. I was hoping to see "foo bar" in BR2_TARGET_UBOOT_PATCH, but it wasn't the case. Am I missing something?

Quoted 1 line

It only works if you have BR2_DEPRECATED_SINCE_2015_05 enabled.

Right, it's deprecated, not legacy...

Perhaps it's better to move it to legacy instead of deprecating. Deprecating is
for when we remove a feature, but here it's more like we renamed it.

Note that string handling in legacy is a bit special, look at e.g.
BR2_PACKAGE_TZDATA_ZONELIST (renamed to BR2_TARGET_TZ_ZONELIST) for an example.

Regards,
Arnout

Quoted 13 lines

I
almost posted an email asking how useful this was. I very rarely enable BR2_DEPRECATED. However, I justified it to myself that if nothing else, it was documentation that the former value in BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR could be copied verbatim.

FWIW, I did try reordering the options to see if putting BR2_TARGET_UBOOT_PATCH first would make this work, but it didn't change the results on my end.

Frank

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#4 lore raw

PATCH 1/1 uboot: add default for BR2_TARGET_UBOOT_PATCH

Quoted 35 lines · Arnout Vandecappelle
Quoted 34 lines · Frank Hunleth
Quoted 31 lines · Thomas Petazzoni

Dear Frank Hunleth,

Quoted 14 lines · Frank Hunleth

Automatically copy over the value from BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR to make handling its deprecation easier. Thanks to Arnout for the suggestion.

Signed-off-by Frank Hunleth <[email protected]>
---
 boot/uboot/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/uboot/Config.in +0 -0
index 4f01499..419b183 100644

boot/uboot/Config.in config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR · line 90

Quoted 7 lines
boot/uboot/Config.in +1 -0
@@ -84,6 +84,7 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
 
 config BR2_TARGET_UBOOT_PATCH
      string "Custom U-Boot patches"
+     default BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
      help
        A space-separated list of patches to apply to U-Boot.
        Each patch can be described as an URL, a local file path,

Does this actually works? I've tried removing BR2_TARGET_UBOOT_PATCH="" from my .config, add BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR="foo bar", and ran 'make menuconfig'. I was hoping to see "foo bar" in BR2_TARGET_UBOOT_PATCH, but it wasn't the case. Am I missing something?

Quoted 6 lines
Quoted 1 line

It only works if you have BR2_DEPRECATED_SINCE_2015_05 enabled.

Right, it's deprecated, not legacy...

Perhaps it's better to move it to legacy instead of deprecating. Deprecating is
for when we remove a feature, but here it's more like we renamed it.

Thanks. Changing it from deprecated to legacy is an improvement. I'll send the new patch as soon as I finish testing it.

-Frank

Quoted 29 lines

Note that string handling in legacy is a bit special, look at e.g.
BR2_PACKAGE_TZDATA_ZONELIST (renamed to BR2_TARGET_TZ_ZONELIST) for an example.

Regards,
Arnout

Quoted 6 lines

I
almost posted an email asking how useful this was. I very rarely enable BR2_DEPRECATED. However, I justified it to myself that if nothing else, it was documentation that the former value in BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR could be copied verbatim.

Quoted 7 lines

FWIW, I did try reordering the options to see if putting BR2_TARGET_UBOOT_PATCH first would make this work, but it didn't change the results on my end.

Frank

--

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
Signature · 4 lines
Frank Hunleth
Troodon Software LLC
Embedded Software Development
http://troodon-software.com/