ARM: exynos: Fix wake-up interrupts for Exynos3250
Subsystems (3)
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
Commit 8b283c025443 (ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.
In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert ace283a04a4a (ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...
--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-exynos/suspend.c +2 -2
@@ -87,8 +87,8 @@ static unsigned int exynos_pmu_spare3;static u32 exynos_irqwake_intmask =0xffffffff ;static const struct exynos_wkup_irq exynos3250_wkup_irq[] = { - {105 ,BIT (1 ) },/* RTC alarm */ - {106 ,BIT (2 ) },/* RTC tick */ + {73 ,BIT (1 ) },/* RTC alarm */ + {74 ,BIT (2 ) },/* RTC tick */ {/* sentinel */ }, };
Signature · 1 line
2.1.4
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
2015-04-23 2:40 GMT+09:00 Marc Zyngier <[email protected]>:
Quoted 11 lines
Commit
8b283c025443(ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert
ace283a04a4a(ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...
Quoted 8 lines
Cc Chanwoo Choi <[email protected]>Cc Kyungmin Park <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Kukjin Kim <[email protected]>Signed-off-by Marc Zyngier <[email protected]>--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for fixing this!
Best regards,
Krzysztof
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
Quoted 22 lines · Krzysztof Kozlowski
2015-04-23 2:40 GMT+09:00 Marc Zyngier <[email protected]>:
Quoted 11 lines
Commit
8b283c025443(ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert
ace283a04a4a(ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...Quoted 8 lines
Cc Chanwoo Choi <[email protected]>Cc Kyungmin Park <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Kukjin Kim <[email protected]>Signed-off-by Marc Zyngier <[email protected]>--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 2 lines
Thanks and applied.
- Kukjin
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
Quoted 23 lines · Kukjin Kim
Quoted 22 lines · Krzysztof Kozlowski
2015-04-23 2:40 GMT+09:00 Marc Zyngier <[email protected]>:
Quoted 19 lines
Commit
8b283c025443(ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert
ace283a04a4a(ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...Cc Chanwoo Choi <[email protected]>Cc Kyungmin Park <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Kukjin Kim <[email protected]>Signed-off-by Marc Zyngier <[email protected]>--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 3 lines
Quoted 2 lines
Thanks and applied.
Looks like this fix never made it to mainline. What happened?
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
Quoted 24 lines · Marc Zyngier
Quoted 23 lines · Kukjin Kim
Quoted 22 lines · Krzysztof Kozlowski
2015-04-23 2:40 GMT+09:00 Marc Zyngier <[email protected]>:
Quoted 19 lines
Commit
8b283c025443(ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert
ace283a04a4a(ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...Cc Chanwoo Choi <[email protected]>Cc Kyungmin Park <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Kukjin Kim <[email protected]>Signed-off-by Marc Zyngier <[email protected]>--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
Thanks and applied.
Looks like this fix never made it to mainline. What happened?
Indeed, good question - what happened? Anyway I applied this to my tree so it won't get lost again. I will push it to Kukjin this weekend.
Best regards,
Krzysztof
PATCH 1/1 ARM: exynos: Fix wake-up interrupts for Exynos3250
In reply to Marc ZyngierHi Marc,
Quoted 26 lines · Marc Zyngier
Commit
8b283c025443(ARM: exynos4/5: convert pmu wakeup to stacked domains) changed the Exynos PMU code to use stacked domains. This has led to a number of interrupt numbers to be fixed.In the meantime, support for Exynos 3250 was added, missing the required change to this platform. This amounts to revert
ace283a04a4a(ARM: EXYNOS: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC), as the initial patch was right, just a bit early...Cc Chanwoo Choi <[email protected]>Cc Kyungmin Park <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Kukjin Kim <[email protected]>Signed-off-by Marc Zyngier <[email protected]>--- arch/arm/mach-exynos/suspend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/mach-exynos/suspend.c +0
-0
arch/arm/mach-exynos/suspend.c static unsigned int exynos_pmu_spare3; · line 94
Quoted 10 lines
arch/arm/mach-exynos/suspend.c +2
-2@@ -87,8 +87,8 @@ static unsigned int exynos_pmu_spare3;static u32 exynos_irqwake_intmask =0xffffffff ;static const struct exynos_wkup_irq exynos3250_wkup_irq[] = { - {105 ,BIT (1 ) },/* RTC alarm */ - {106 ,BIT (2 ) },/* RTC tick */ + {73 ,BIT (1 ) },/* RTC alarm */ + {74 ,BIT (2 ) },/* RTC tick */ {/* sentinel */ }, };
Thanks,
Chanwoo Choi