xillybus: XILLYBUS_OF should depend on HAS_DMA
Subsystems (2)
PATCH 1/1 xillybus: XILLYBUS_OF should depend on HAS_DMA
If NO_DMA=y:
drivers/built-in.o: In function `xilly_of_unmap':
xillybus_of.c:(.text+0xa860e): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `xilly_map_single_of':
xillybus_of.c:(.text+0xa8668): undefined reference to `dma_map_single'
xillybus_of.c:(.text+0xa8676): undefined reference to `dma_mapping_error'
xillybus_of.c:(.text+0xa86ca): undefined reference to `dma_unmap_single'
drivers/built-in.o: In function `xilly_dma_sync_single_for_device_of':
xillybus_of.c:(.text+0xa8700): undefined reference to `dma_sync_single_for_cpu'
drivers/built-in.o: In function `xilly_dma_sync_single_for_cpu_of':
xillybus_of.c:(.text+0xa8726): undefined reference to `dma_sync_single_for_cpu'--- drivers/char/xillybus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/xillybus/Kconfig +1 -1
@@ -24,7 +24,7 @@ config XILLYBUS_PCIE config XILLYBUS_OF tristate "Xillybus over Device Tree" - depends on OF_ADDRESS && OF_IRQ + depends on OF_ADDRESS && OF_IRQ && HAS_DMA help Set to M if you want Xillybus to find its resources from the Open Firmware Flattened Device Tree. If the target is an embedded
Signature · 1 line
1.9.1
Eli Billauer
maintainerHello Geert,
Thanks for this. The dependency on HAS_DMA is obviously missing (is there any real platform that uses OF but has HAS_DMA off? Sounds a bit esoteric to me).
And if we're at it, I now realize that XILLYBUS_PCIE maybe also should depend on HAS_DMA, in case PCI is enabled but HAS_DMA isn't...?
I don't maintain a git repository of my own -- Greg applies my patches into char-next when I have any (doesn't happen very often). So I suppose this should be Cced to the maintainers of "CHAR and MISC DRIVERS" (that is, Greg and Arnd). Preferably with a "char: xillybus:" prefix in the title, I guess.
Thanks & regards,
Eli
Quoted 32 lines · Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `xilly_of_unmap': xillybus_of.c:(.text+0xa860e): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `xilly_map_single_of': xillybus_of.c:(.text+0xa8668): undefined reference to `dma_map_single' xillybus_of.c:(.text+0xa8676): undefined reference to `dma_mapping_error' xillybus_of.c:(.text+0xa86ca): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `xilly_dma_sync_single_for_device_of': xillybus_of.c:(.text+0xa8700): undefined reference to `dma_sync_single_for_cpu' drivers/built-in.o: In function `xilly_dma_sync_single_for_cpu_of': xillybus_of.c:(.text+0xa8726): undefined reference to `dma_sync_single_for_cpu'Signed-off-by Geert Uytterhoeven<[email protected]>--- drivers/char/xillybus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/char/xillybus/Kconfig +1
-1@@ -24,7 +24,7 @@ config XILLYBUS_PCIE config XILLYBUS_OF tristate "Xillybus over Device Tree" - depends on OF_ADDRESS&& OF_IRQ + depends on OF_ADDRESS&& OF_IRQ&& HAS_DMA help Set to M if you want Xillybus to find its resources from the Open Firmware Flattened Device Tree. If the target is an embedded
Hi Eli,
Quoted 3 lines · Eli Billauer
Thanks for this. The dependency on
HAS_DMAis obviously missing (is there any real platform that uses OF but hasHAS_DMAoff? Sounds a bit esoteric to me).
I hit this with the patch that allows to enable OF if COMPILE_TEST, which will probably be accepted soon.
Quoted 2 lines
And if we're at it, I now realize that
XILLYBUS_PCIEmaybe also should depend onHAS_DMA, in case PCI is enabled butHAS_DMAisn't...?
PCI is only available on platform that set HAS_DMA.
Quoted 4 lines
I don't maintain a git repository of my own -- Greg applies my patches into char-next when I have any (doesn't happen very often). So I suppose this should be Cced to the maintainers of "CHAR and MISC DRIVERS" (that is, Greg and Arnd). Preferably with a "char: xillybus:" prefix in the title, I guess.
I've just used get_maintainer.pl, so please update MAINTAINERS.
Can I add your Acked-by, then I can send an updated version to Greg and Arnd?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Eli Billauer
maintainerQuoted 3 lines · Geert Uytterhoeven
Can I add your Acked-by, then I can send an updated version to Greg and Arnd?
Yes, indeed. Thanks.
Eli