Skip to contentSkip to conversation

mm/hugetlb: reduce arch dependent code about hugetlb_prefault_arch_hook

PATCH In review Zhang Zhen 2 participants 2 messages Apr 25, 2015 – Apr 28, 2015 1 message not in the archive

Subsystems (10)
Memory management Arm (32-bit) x86 PowerPC +6 more subsystems
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Zhang Zhen

author
#1 lore raw

PATCH 1/1 mm/hugetlb: reduce arch dependent code about hugetlb_prefault_arch_hook

Currently we have many duplicates in definitions of hugetlb_prefault_arch_hook. In all architectures this function is empty.

Signed-off-by Zhang Zhen <[email protected]>
---
 arch/arm/include/asm/hugetlb.h     | 4 ----
 arch/arm64/include/asm/hugetlb.h   | 4 ----
 arch/ia64/include/asm/hugetlb.h    | 4 ----
 arch/metag/include/asm/hugetlb.h   | 4 ----
 arch/mips/include/asm/hugetlb.h    | 4 ----
 arch/powerpc/include/asm/hugetlb.h | 5 -----
 arch/s390/include/asm/hugetlb.h    | 1 -
 arch/sh/include/asm/hugetlb.h      | 3 ---
 arch/sparc/include/asm/hugetlb.h   | 4 ----
 arch/tile/include/asm/hugetlb.h    | 4 ----
 arch/x86/include/asm/hugetlb.h     | 3 ---
 fs/hugetlbfs/inode.c               | 1 -
 12 files changed, 41 deletions(-)
arch/arm/include/asm/hugetlb.h +0 -4
index 1f1b1cd..31bb7dc 100644
@@ -53,10 +53,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline int huge_pte_none(pte_t pte)
 {
 	return pte_none(pte);
arch/arm64/include/asm/hugetlb.h +0 -4
index 5b7ca8a..734c17e 100644
@@ -86,10 +86,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline int huge_pte_none(pte_t pte)
 {
 	return pte_none(pte);
arch/ia64/include/asm/hugetlb.h +0 -4
index aa91005..ff1377b 100644
@@ -20,10 +20,6 @@ static inline int is_hugepage_only_range(struct mm_struct *mm,
 		REGION_NUMBER((addr)+(len)-1) == RGN_HPAGE);
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
 				   pte_t *ptep, pte_t pte)
 {
arch/metag/include/asm/hugetlb.h +0 -4
index 471f481..f730b39 100644
@@ -14,10 +14,6 @@ static inline int is_hugepage_only_range(struct mm_struct *mm,
 int prepare_hugepage_range(struct file *file, unsigned long addr,
 						unsigned long len);
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
 					  unsigned long addr, unsigned long end,
 					  unsigned long floor,
arch/mips/include/asm/hugetlb.h +0 -4
index fe0d15d..4a5bb54 100644
@@ -38,10 +38,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
 					  unsigned long addr,
 					  unsigned long end,
arch/powerpc/include/asm/hugetlb.h +0 -5
index 1d53a65..4bbd3c8 100644
@@ -112,11 +112,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
-
 static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
 				   pte_t *ptep, pte_t pte)
 {
arch/s390/include/asm/hugetlb.h +0 -1
index 11eae5f..dfb542a 100644
@@ -35,7 +35,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-#define hugetlb_prefault_arch_hook(mm)		do { } while (0)
 #define arch_clear_hugepage_flags(page)		do { } while (0)
 
 int arch_prepare_hugepage(struct page *page);
arch/sh/include/asm/hugetlb.h +0 -3
index 699255d..b788a9b 100644
@@ -26,9 +26,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm) {
-}
-
 static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
 					  unsigned long addr, unsigned long end,
 					  unsigned long floor,
arch/sparc/include/asm/hugetlb.h +0 -4
index e4cab46..3130d76 100644
@@ -11,10 +11,6 @@ void set_huge_pte_at(struct mm_struct *mm, unsigned long addr,
 pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned long addr,
 			      pte_t *ptep);
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline int is_hugepage_only_range(struct mm_struct *mm,
 					 unsigned long addr,
 					 unsigned long len) {
arch/tile/include/asm/hugetlb.h +0 -4
index 3257733..1abd00c 100644
@@ -40,10 +40,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm)
-{
-}
-
 static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
 					  unsigned long addr, unsigned long end,
 					  unsigned long floor,
arch/x86/include/asm/hugetlb.h +0 -3
index 68c0539..dab7a3a 100644
@@ -26,9 +26,6 @@ static inline int prepare_hugepage_range(struct file *file,
 	return 0;
 }
 
-static inline void hugetlb_prefault_arch_hook(struct mm_struct *mm) {
-}
-
 static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
 					  unsigned long addr, unsigned long end,
 					  unsigned long floor,
fs/hugetlbfs/inode.c +0 -1
index 2640d88..f45ea95 100644
@@ -130,7 +130,6 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma)
 		goto out;
 
 	ret = 0;
-	hugetlb_prefault_arch_hook(vma->vm_mm);
 	if (vma->vm_flags & VM_WRITE && inode->i_size < len)
 		inode->i_size = len;
 out:
Signature · 4 lines
1.9.1


.
Acked-by on v1 1/1
#2 lore raw
Quoted 4 lines · Zhang Zhen

Currently we have many duplicates in definitions of hugetlb_prefault_arch_hook. In all architectures this function is empty.

Signed-off-by Zhang Zhen <[email protected]>
Acked-by David Rientjes <[email protected]>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>