Skip to contentSkip to conversation

hostmem: Fix mem-path property name in error report

PATCH Applied Jan Kiszka 3 participants 3 messages Apr 24, 2015 – Apr 25, 2015 Arm STM32

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 hostmem: Fix mem-path property name in error report

The subtle difference between "property not found" and "property not set" is already confusing enough.

Signed-off-by Jan Kiszka <[email protected]>
---
 backends/hostmem-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
backends/hostmem-file.c +1 -1
index 5179994..4b55361 100644
@@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
         return;
     }
     if (!fb->mem_path) {
-        error_setg(errp, "mem_path property not set");
+        error_setg(errp, "mem-path property not set");
         return;
     }
 #ifndef CONFIG_LINUX
Signature · 1 line
2.1.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Jan Kiszka

The subtle difference between "property not found" and "property not set" is already confusing enough.

Signed-off-by Jan Kiszka <[email protected]>
Reviewed-by Peter Crosthwaite <[email protected]>
Quoted 20 lines
---
 backends/hostmem-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
backends/hostmem-file.c +1 -2
index 5179994..4b55361 100644
@@ -43,7 +43,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
         return;
     }
     if (!fb->mem_path) {
-        error_setg(errp, "mem_path property not set");
+        error_setg(errp, "mem-path property not set");
         return;
     }
 #ifndef CONFIG_LINUX
--

2.1.4

Applied
#2 lore raw
In reply to Jan Kiszka
Quoted 2 lines · Jan Kiszka

The subtle difference between "property not found" and "property not set" is already confusing enough.

Applied to -trivial, thanks!

/mjt