Skip to contentSkip to conversation

extend enough credits for freeing one truncate record while replaying truncate records

PATCH New Xue jiufei 1 participant 1 message Apr 27, 2015 OCFS2

lore
Share & tools
lore

Xue jiufei

author
#0 lore raw

PATCH 3/3 extend enough credits for freeing one truncate record while replaying truncate records

Now function ocfs2_replay_truncate_records first modify the tl_used, then call ocfs2_extend_trans to extend transactions for gd and alloc inode used for freeing clusters. jbd2_journal_restart() may be called and it may happened that tl_used in truncate log is decreased but the clusters is not freed, which means these clusters are lost. So we should avoid extending transactions in these two operations.

Signed-off-by joyce.xue <[email protected]>
---
 fs/ocfs2/alloc.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)
fs/ocfs2/alloc.c +8 -11
index ebb2cc4..6f571aa 100644
@@ -5975,16 +5975,6 @@ static int ocfs2_replay_truncate_records(struct ocfs2_super *osb,
 
 		ocfs2_journal_dirty(handle, tl_bh);
 
-		/* TODO: Perhaps we can calculate the bulk of the
-		 * credits up front rather than extending like
-		 * this. */
-		status = ocfs2_extend_trans(handle,
-					    OCFS2_TRUNCATE_LOG_FLUSH_ONE_REC);
-		if (status < 0) {
-			mlog_errno(status);
-			goto bail;
-		}
-
 		rec = tl->tl_recs[i];
 		start_blk = ocfs2_clusters_to_blocks(data_alloc_inode->i_sb,
 						    le32_to_cpu(rec.t_start));

@@ -6005,6 +5995,13 @@ static int ocfs2_replay_truncate_records(struct ocfs2_super *osb,
 				goto bail;
 			}
 		}
+
+		status = ocfs2_extend_trans(handle,
+				OCFS2_TRUNCATE_LOG_FLUSH_ONE_REC);
+		if (status < 0) {
+			mlog_errno(status);
+			goto bail;
+		}
 		i--;
 	}
 

@@ -6063,7 +6060,7 @@ int __ocfs2_flush_truncate_log(struct ocfs2_super *osb)
 		goto out_mutex;
 	}
 
-	handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_UPDATE);
+	handle = ocfs2_start_trans(osb, OCFS2_TRUNCATE_LOG_FLUSH_ONE_REC);
 	if (IS_ERR(handle)) {
 		status = PTR_ERR(handle);
 		mlog_errno(status);
Signature · 1 line
1.8.4.3