Skip to contentSkip to conversation

be2net: log link status

PATCH Superseded Ivan Vecera 3 participants 5 messages Apr 28, 2015 – Apr 30, 2015

Subsystems (3)
Networking Network drivers Emulex 10Gbps NIC BE2, BE3-r, Lancer, Skyhawk-R driver (be2net)
lore
Share & tools
lore

Ivan Vecera

author
#0 lore raw

PATCH v3 1/1 be2net: log link status

The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log.

v3: Changes from v2 discarded as "not necessary"

Cc Sathya Perla <[email protected]>
Cc Subbu Seetharaman <[email protected]>
Cc Ajit Khaparde <[email protected]>
Signed-off-by Ivan Vecera <[email protected]>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/emulex/benet/be_main.c +2 -0
index fb0bc3c..e349131 100644
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
 		netif_carrier_on(netdev);
 	else
 		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
 }
  static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff

*skb)

Signature · 1 line
2.0.5
Acked-by on v3 1/1
#1 lore raw
Quoted 7 lines

-----Original Message-----
From: Ivan Vecera [mailto:[email protected]]

The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log.

Quoted 6 lines

v3: Changes from v2 discarded as "not necessary"

Cc Sathya Perla <[email protected]>
Cc Subbu Seetharaman <[email protected]>
Cc Ajit Khaparde <[email protected]>
Signed-off-by Ivan Vecera <[email protected]>
Acked-by Sathya Perla <[email protected]>
maintainer
#2 lore raw
In reply to Ivan Vecera

From: Ivan Vecera <[email protected]>
Date: Tue, 28 Apr 2015 21:39:32 +0200

Quoted 20 lines

The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged in the system log.

v3: Changes from v2 discarded as "not necessary"

Cc Sathya Perla <[email protected]>
Cc Subbu Seetharaman <[email protected]>
Cc Ajit Khaparde <[email protected]>
Signed-off-by Ivan Vecera <[email protected]>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/emulex/benet/be_main.c +0 -0
index fb0bc3c..e349131 100644

drivers/net/ethernet/emulex/benet/be_main.c void be_link_status_update(struct be_adapter · line 662

Quoted 1 line
drivers/net/ethernet/emulex/benet/be_main.c +0 -0
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter
 *adapter, u8 link_status)

Patch has been corrupted by your email client.

Please fix this up and resubmit.

author
#3 lore raw

PATCH v3 1/1 be2net: log link status

The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged to the system log.

v3: Changes from v2 discarded as "not necessary"

Cc Sathya Perla <[email protected]>
Cc Subbu Seetharaman <[email protected]>
Cc Ajit Khaparde <[email protected]>
Signed-off-by Ivan Vecera <[email protected]>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/emulex/benet/be_main.c +2 -0
index fb0bc3c..e349131 100644
@@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapter *adapter, u8 link_status)
 		netif_carrier_on(netdev);
 	else
 		netif_carrier_off(netdev);
+
+	netdev_info(netdev, "Link is %s\n", link_status ? "Up" : "Down");
 }
 
 static void be_tx_stats_update(struct be_tx_obj *txo, struct sk_buff *skb)
Signature · 1 line
2.0.5
maintainer Applied
#4 lore raw

From: Ivan Vecera <[email protected]>
Date: Thu, 30 Apr 2015 11:59:49 +0200

Quoted 10 lines

The driver unlike other drivers does not log link state changes. It's better for an user when asynchronous link states are logged to the system log.

v3: Changes from v2 discarded as "not necessary"

Cc Sathya Perla <[email protected]>
Cc Subbu Seetharaman <[email protected]>
Cc Ajit Khaparde <[email protected]>
Signed-off-by Ivan Vecera <[email protected]>

Applied.