Skip to contentSkip to conversation

selftests/powerpc: Remove unneeded variable

PATCH In review [email protected] 2 participants 2 messages Jun 14, 2023 – Jun 15, 2023 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 selftests/powerpc: Remove unneeded variable

Fix the following coccicheck warning:

tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7: Unneeded variable: "rc". Return "0"

---
 .../powerpc/alignment/alignment_handler.c     | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)
tools/testing/selftests/powerpc/alignment/alignment_handler.c +12 -12
index 33ee34fc0828..4980656c3f70 100644
@@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void)
     STORE_VSX_XFORM_TEST(stxvd2x);
     STORE_VSX_XFORM_TEST(stxvw4x);
     STORE_VSX_XFORM_TEST(stxsdx);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_vsx_207(void)
@@ -348,7 +348,7 @@ int test_alignment_handler_vsx_207(void)
     LOAD_VSX_XFORM_TEST(lxsiwzx);
     STORE_VSX_XFORM_TEST(stxsspx);
     STORE_VSX_XFORM_TEST(stxsiwx);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_vsx_300(void)
@@ -380,7 +380,7 @@ int test_alignment_handler_vsx_300(void)
     STORE_VSX_XFORM_TEST(stxvx);
     STORE_VSX_XFORM_TEST(stxvl);
     STORE_VSX_XFORM_TEST(stxvll);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_vsx_prefix(void)
@@ -399,7 +399,7 @@ int test_alignment_handler_vsx_prefix(void)
     STORE_VSX_8LS_PREFIX_TEST(PSTXSSP, 0);
     STORE_VSX_8LS_PREFIX_TEST(PSTXV0, 0);
     STORE_VSX_8LS_PREFIX_TEST(PSTXV1, 1);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_integer(void)
@@ -458,7 +458,7 @@ int test_alignment_handler_integer(void)
     STORE_DFORM_TEST(stmw);
 #endif
 
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_integer_206(void)
@@ -473,7 +473,7 @@ int test_alignment_handler_integer_206(void)
     LOAD_XFORM_TEST(ldbrx);
     STORE_XFORM_TEST(stdbrx);
 
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_integer_prefix(void)
@@ -494,7 +494,7 @@ int test_alignment_handler_integer_prefix(void)
     STORE_MLS_PREFIX_TEST(PSTH);
     STORE_MLS_PREFIX_TEST(PSTW);
     STORE_8LS_PREFIX_TEST(PSTD);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_vmx(void)
@@ -522,7 +522,7 @@ int test_alignment_handler_vmx(void)
     STORE_VMX_XFORM_TEST(stvehx);
     STORE_VMX_XFORM_TEST(stvewx);
     STORE_VMX_XFORM_TEST(stvxl);
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_fp(void)
@@ -550,7 +550,7 @@ int test_alignment_handler_fp(void)
     STORE_FLOAT_XFORM_TEST(stfsux);
     STORE_FLOAT_XFORM_TEST(stfiwx);
 
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_fp_205(void)
@@ -568,7 +568,7 @@ int test_alignment_handler_fp_205(void)
     STORE_FLOAT_DFORM_TEST(stfdp);
     STORE_FLOAT_XFORM_TEST(stfdpx);
 
-    return rc;
+    return 0;
 }
 
 int test_alignment_handler_fp_206(void)
@@ -582,7 +582,7 @@ int test_alignment_handler_fp_206(void)
 
     LOAD_FLOAT_XFORM_TEST(lfiwzx);
 
-    return rc;
+    return 0;
 }
 
@@ -599,7 +599,7 @@ int test_alignment_handler_fp_prefix(void)
     LOAD_FLOAT_MLS_PREFIX_TEST(PLFD);
     STORE_FLOAT_MLS_PREFIX_TEST(PSTFS);
     STORE_FLOAT_MLS_PREFIX_TEST(PSTFD);
-    return rc;
+    return 0;
 }
 
 void usage(char *prog)
#2 lore raw
Quoted 4 lines · [email protected] writes:

Fix the following coccicheck warning:

tools/testing/selftests/powerpc/alignment/alignment_handler.c:558:5-7:
Unneeded variable: "rc". Return "0"

The check is wrong.

tools/testing/selftests/powerpc/alignment/alignment_handler.c int test_alignment_handler_vsx_206(void) · line 335

Quoted 12 lines
(quoted diff) +0 -0

a/tools/testing/selftests/powerpc/alignment/alignment_handler.c b/tools/testing/selftests/powerpc/alignment/alignment_handler.c index 33ee34fc0828..4980656c3f70 100644

tools/testing/selftests/powerpc/alignment/alignment_handler.c +1 -1
@@ -332,7 +332,7 @@ int test_alignment_handler_vsx_206(void)
      STORE_VSX_XFORM_TEST(stxvd2x);
      STORE_VSX_XFORM_TEST(stxvw4x);
      STORE_VSX_XFORM_TEST(stxsdx);
-    return rc;
+    return 0;

rc is used in the macros.

cheers