Skip to contentSkip to conversation

ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls

PATCH Applied Axel Lin 3 participants 3 messages Apr 27, 2015 – May 1, 2015

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: mc13783: Fix wrong mask value used in mc13xxx_reg_rmw() calls

mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL bit.

---
Hi,
I don't have this h/w for test, so please help review and test this patch. Thanks.

 sound/soc/codecs/mc13783.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
sound/soc/codecs/mc13783.c +2 -2
index 2ffb9a0..3d44fc5 100644
@@ -623,14 +623,14 @@ static int mc13783_probe(struct snd_soc_codec *codec)
 				AUDIO_SSI_SEL, 0);
 	else
 		mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_CODEC,
-				0, AUDIO_SSI_SEL);
+				AUDIO_SSI_SEL, AUDIO_SSI_SEL);
 
 	if (priv->dac_ssi_port == MC13783_SSI1_PORT)
 		mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC,
 				AUDIO_SSI_SEL, 0);
 	else
 		mc13xxx_reg_rmw(priv->mc13xxx, MC13783_AUDIO_DAC,
-				0, AUDIO_SSI_SEL);
+				AUDIO_SSI_SEL, AUDIO_SSI_SEL);
 
 	return 0;
 }
Signature · 1 line
2.1.0
#1 lore raw

Hello,

Quoted 4 lines · Axel Lin

mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL bit.

I'm sorry but I don't have access to the hardware anymore. Maybe Fabio Estevam or Shawn Guo can test it.

Regards,

Philippe
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

maintainer Applied
#2 lore raw
In reply to Axel Lin
Quoted 3 lines · Axel Lin

mc13xxx_reg_rmw() won't change any bit if passing 0 to the mask field. Pass AUDIO_SSI_SEL instead of 0 for the mask field to set AUDIO_SSI_SEL bit.

Applied, thanks.