ARM: dts: Fix bootup issue on smdk5250

PATCH New Yadwinder Singh Brar 6 participants 14 messages Nov 18, 2014 – Aug 18, 2015

Subsystems (2)

Device tree bindings Arm Samsung Exynos

lore

Share & tools

lore

Yadwinder Singh Brar

author

2014-11-18 12:08 UTC #0 lore raw

PATCH 1/2 ARM: dts: Fix bootup issue on smdk5250

With default config on smdk5250 latest tree throws below message :

[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue

and hangs randomly because it reads wrong temperature value.

I can't figure out any direct relation between LDO10 and TMU from board schematics which I have. So making LDO10 always-on to fix issue for now.

Signed-off-by Yadwinder Singh Brar <[email protected]>

---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -0

index bc27cc2..95b5b51 100644
@@ -190,6 +190,7 @@
 				regulator-name = "P1.8V_LDO_OUT10";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
 			};
 
 			ldo11_reg: LDO11 {

Signature · 1 line

1.7.0.4

Yadwinder Singh Brar

author

2014-11-18 12:08 UTC #1 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.

This patch makes max77686 RTC work and also configures it as wakeup source.

Signed-off-by Yadwinder Singh Brar <[email protected]>

---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

arch/arm/boot/dts/exynos5250-smdk5250.dts +12 -0

index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
 		reg = <0x09>;
 		interrupt-parent = <&gpx3>;
 		interrupts = <2 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		wakeup-source;
 
 		voltage-regulators {
 			ldo1_reg: LDO1 {

@@ -411,3 +414,12 @@
 		};
 	};
 };
+
+&pinctrl_0 {
+	max77686_irq: max77686-irq {
+		samsung,pins = "gpx3-2";
+		samsung,pin-function = <0xf>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};

Signature · 1 line

1.7.0.4

Javier Martinez Canillas

2014-11-18 14:02 UTC #2 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

Hello Yadwinder,

Quoted 4 lines · Yadwinder Singh Brar

This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.

I'm not familiar with this board but the patch looks good to me assuming the IRQ is the correct one.

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,
Javier

Pankaj Dubey

2014-11-20 04:06 UTC #3 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

In reply to Yadwinder Singh Brar

Hi,

Quoted 9 lines · Yadwinder Singh Brar

This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>

Tested this on SMDK5250, and with this PMIC RTC is working fine.

Tested-by Pankaj Dubey <[email protected]>

Thanks,
Pankaj Dubey

Quoted 32 lines

---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++

  1 files changed, 12 insertions(+), 0 deletions(-)

arch/arm/boot/dts/exynos5250-smdk5250.dts +12 -0

index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
  		reg = <0x09>;
  		interrupt-parent = <&gpx3>;
  		interrupts = <2 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		wakeup-source;
 
  		voltage-regulators {
  			ldo1_reg: LDO1 {

@@ -411,3 +414,12 @@
  		};
  	};
  };
+
+&pinctrl_0 {
+	max77686_irq: max77686-irq {
+		samsung,pins = "gpx3-2";
+		samsung,pin-function = <0xf>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};

Pankaj Dubey

2015-04-28 11:01 UTC #4 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

In reply to Yadwinder Singh Brar

Hi Kukjin,

Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.

Thanks,
Pankaj Dubey

Quoted 42 lines · Yadwinder Singh Brar

This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>
Tested-by Pankaj Dubey <[email protected]>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
  1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +12 -0
index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
  		reg = <0x09>;
  		interrupt-parent = <&gpx3>;
  		interrupts = <2 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		wakeup-source;
 
  		voltage-regulators {
  			ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
  		};
  	};
  };
+
+&pinctrl_0 {
+	max77686_irq: max77686-irq {
+		samsung,pins = "gpx3-2";
+		samsung,pin-function = <0xf>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};

Krzysztof Kozlowski

2015-05-02 05:49 UTC #5 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:

Quoted 5 lines

Hi Kukjin,
Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.

Could you resend the patch after rebasing it?

Best regards,
Krzysztof

Quoted 53 lines

Thanks,
Pankaj Dubey
Quoted 44 lines · Yadwinder Singh Brar
This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>
Tested-by Pankaj Dubey <[email protected]>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
  1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +12 -0
index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
          reg = <0x09>;
          interrupt-parent = <&gpx3>;
          interrupts = <2 IRQ_TYPE_NONE>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&max77686_irq>;
+        wakeup-source;
 
          voltage-regulators {
              ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
          };
      };
  };
+
+&pinctrl_0 {
+    max77686_irq: max77686-irq {
+        samsung,pins = "gpx3-2";
+        samsung,pin-function = <0xf>;
+        samsung,pin-pud = <0>;
+        samsung,pin-drv = <0>;
+    };
+};
Signature · 4 lines
To unsubscribe from this list: send the line "unsubscribe
linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Krzysztof Kozlowski

2015-08-17 05:50 UTC #6 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <[email protected]>:

Quoted 11 lines

W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
Quoted 5 lines
Hi Kukjin,
Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.
Could you resend the patch after rebasing it?
Best regards,
Krzysztof

Dear Pankaj and Yadwinder,

Do you plan to do anything with this patch?

Best regards,
Krzysztof

Quoted 54 lines

Quoted 53 lines
Thanks,
Pankaj Dubey
Quoted 34 lines · Yadwinder Singh Brar
This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>
Tested-by Pankaj Dubey <[email protected]>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
  1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
          reg = <0x09>;
          interrupt-parent = <&gpx3>;
          interrupts = <2 IRQ_TYPE_NONE>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&max77686_irq>;
+        wakeup-source;
 
          voltage-regulators {
              ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
          };
      };
arch/arm/boot/dts/exynos5250-smdk5250.dts line 425
Quoted 10 lines
arch/arm/boot/dts/exynos5250-smdk5250.dts +9 -0
  };
+
+&pinctrl_0 {
+    max77686_irq: max77686-irq {
+        samsung,pins = "gpx3-2";
+        samsung,pin-function = <0xf>;
+        samsung,pin-pud = <0>;
+        samsung,pin-drv = <0>;
+    };
+};
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Pankaj Dubey

2015-08-18 06:13 UTC #7 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski

2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <[email protected]>:
Quoted 7 lines
W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
Quoted 5 lines
Hi Kukjin,
Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.

Quoted 9 lines

Quoted 4 lines
Could you resend the patch after rebasing it?
Best regards,
Krzysztof
Dear Pankaj and Yadwinder,
Do you plan to do anything with this patch?

Thanks for reminding us. Somehow I missed this.
I will resend the patch shortly after rebasing and testing.

Thanks,
Pankaj Dubey

Quoted 59 lines

Best regards,
Krzysztof
Quoted 54 lines
Quoted 53 lines
Thanks,
Pankaj Dubey
Quoted 34 lines · Yadwinder Singh Brar
This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>
Tested-by Pankaj Dubey <[email protected]>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
   1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
           reg = <0x09>;
           interrupt-parent = <&gpx3>;
           interrupts = <2 IRQ_TYPE_NONE>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&max77686_irq>;
+        wakeup-source;
 
           voltage-regulators {
               ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
           };
       };
arch/arm/boot/dts/exynos5250-smdk5250.dts line 425
Quoted 10 lines
arch/arm/boot/dts/exynos5250-smdk5250.dts +9 -0
   };
+
+&pinctrl_0 {
+    max77686_irq: max77686-irq {
+        samsung,pins = "gpx3-2";
+        samsung,pin-function = <0xf>;
+        samsung,pin-pud = <0>;
+        samsung,pin-drv = <0>;
+    };
+};
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Pankaj Dubey

2015-08-18 06:26 UTC #8 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 13 lines · Krzysztof Kozlowski

2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <[email protected]>:
Quoted 11 lines
W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
Quoted 5 lines
Hi Kukjin,
Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.
Could you resend the patch after rebasing it?
Best regards,
Krzysztof

Quoted 8 lines

Dear Pankaj and Yadwinder,
Do you plan to do anything with this patch?
Best regards,
Krzysztof

Just noticed that the patch in subject is already merged in kgene tree.
There was another patch "[1/2]: ARM: dts: Fix bootup issue on smdk5250" which was posted along with this is still not merged. Resending it once again.

[1]: http://www.spinics.net/lists/linux-samsung-soc/msg39100.html

Thanks,
Pankaj Dubey

Quoted 55 lines

Quoted 54 lines
Quoted 53 lines
Thanks,
Pankaj Dubey
Quoted 34 lines · Yadwinder Singh Brar
This patch adds pinctrl configuration for using configuring gpx3-2 as an external interrupt from max77686. Though max77686 RTC is enabled and gets probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by Yadwinder Singh Brar <[email protected]>
Reviewed-by Javier Martinez Canillas <[email protected]>
Tested-by Pankaj Dubey <[email protected]>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12 ++++++++++++
   1 files changed, 12 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +3 -0
index 95b5b51..19cd918 100644
@@ -131,6 +131,9 @@
           reg = <0x09>;
           interrupt-parent = <&gpx3>;
           interrupts = <2 IRQ_TYPE_NONE>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&max77686_irq>;
+        wakeup-source;
 
           voltage-regulators {
               ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
           };
       };
arch/arm/boot/dts/exynos5250-smdk5250.dts line 425
Quoted 10 lines
arch/arm/boot/dts/exynos5250-smdk5250.dts +9 -0
   };
+
+&pinctrl_0 {
+    max77686_irq: max77686-irq {
+        samsung,pins = "gpx3-2";
+        samsung,pin-function = <0xf>;
+        samsung,pin-pud = <0>;
+        samsung,pin-drv = <0>;
+    };
+};
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Krzysztof Kozlowski

2015-08-18 07:00 UTC #9 lore raw

PATCH 2/2 ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

Quoted 18 lines · Pankaj Dubey

Hi Krzysztof,
Quoted 15 lines · Krzysztof Kozlowski
2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <[email protected]>:
Quoted 11 lines
W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
Quoted 5 lines
Hi Kukjin,
Any updated for this patch. Without this PMIC RTC is not working on SMDK5250.
Could you resend the patch after rebasing it?
Best regards,
Krzysztof
Dear Pankaj and Yadwinder,

Quoted 8 lines

Quoted 6 lines
Do you plan to do anything with this patch?
Best regards,
Krzysztof
Just noticed that the patch in subject is already merged in kgene tree.

Yes, you're right.

Quoted 5 lines

There was another patch "[1/2]: ARM: dts: Fix bootup issue on smdk5250" which was posted along with this is still not merged. Resending it once again.
[1]: http://www.spinics.net/lists/linux-samsung-soc/msg39100.html

Thanks!

Best regards,
Krzysztof

Pankaj Dubey

2014-11-20 04:01 UTC #10 lore raw

PATCH 1/2 ARM: dts: Fix bootup issue on smdk5250

In reply to Yadwinder Singh Brar

Hi,

Quoted 5 lines · Yadwinder Singh Brar

With default config on smdk5250 latest tree throws below message :

[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue

Quoted 7 lines

and hangs randomly because it reads wrong temperature value.
I can't figure out any direct relation between LDO10 and TMU from board schematics which I have. So making LDO10 always-on to fix issue for now.
Signed-off-by Yadwinder Singh Brar <[email protected]>

Tested this on SMDK5250 board, system boot is fine now, hence

Tested-by Pankaj Dubey <[email protected]>

Quoted 17 lines

---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +

  1 files changed, 1 insertions(+), 0 deletions(-)

arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -0

index bc27cc2..95b5b51 100644
@@ -190,6 +190,7 @@
  				regulator-name = "P1.8V_LDO_OUT10";
  				regulator-min-microvolt = <1800000>;
  				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
  			};
 
  			ldo11_reg: LDO11 {

Kukjin Kim

2014-11-22 03:25 UTC #11 lore raw

PATCH 1/2 ARM: dts: Fix bootup issue on smdk5250

Quoted 3 lines · Pankaj Dubey

Hi,

Hi,

Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client can't filter wrong ;)

Quoted 11 lines · Yadwinder Singh Brar

Quoted 10 lines
With default config on smdk5250 latest tree throws below message :
[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
and hangs randomly because it reads wrong temperature value.
I can't figure out any direct relation between LDO10 and TMU from board schematics which I have. So making LDO10 always-on to fix issue for now.

Hmm...strange, I also can't see any relations now...but I need to contact to hardware guy before applying this, this fixes the problem though.

Thanks,
Kukjin

Quoted 24 lines

Quoted 2 lines
Signed-off-by Yadwinder Singh Brar <[email protected]>
Tested this on SMDK5250 board, system boot is fine now, hence
Tested-by Pankaj Dubey <[email protected]>
Quoted 17 lines
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -0
index bc27cc2..95b5b51 100644
@@ -190,6 +190,7 @@
  				regulator-name = "P1.8V_LDO_OUT10";
  				regulator-min-microvolt = <1800000>;
  				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
  			};
 
  			ldo11_reg: LDO11 {

Yadwinder Singh Brar

author

2014-11-25 13:16 UTC #12 lore raw

PATCH 1/2 ARM: dts: Fix bootup issue on smdk5250

Hi Kukjin,

Quoted 11 lines

Subject: RE: [1/2] ARM: dts: Fix bootup issue on smdk5250
Quoted 3 lines · Pankaj Dubey
Hi,
Hi,
Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client can't filter wrong ;)

Sure, but I think your mail client had played some trick, as patches were posted with [PATCH */2] prefix.

Quoted 10 lines

Quoted 4 lines · Yadwinder Singh Brar
Quoted 3 lines
With default config on smdk5250 latest tree throws below message :
[    2.226049] thermal thermal_zone0: critical temperature
reached(224 C),shutting down
Quoted 1 line
Quoted 1 line
[    2.227840] reboot: Failed to start orderly shutdown: forcing
the issue
Quoted 3 lines
Quoted 3 lines
and hangs randomly because it reads wrong temperature value.

Quoted 8 lines

Quoted 2 lines
Quoted 2 lines
I can't figure out any direct relation between LDO10 and TMU from board schematics which I have. So making LDO10 always-on to fix
issue for now.
Quoted 1 line
Quoted 1 line
Hmm...strange, I also can't see any relations now...but I need to contact to hardware guy before applying this, this fixes the problem though.

Ok, sure it will be good know actual relation from hardware guy.

Meanwhile can we get another patch[1] merged which was posted along with patch just because both patches were on same file. Otherwise there is no dependency between them and can be applied independently.

Best Regards,
Yadwinder

[1] : http://www.spinics.net/lists/linux-samsung-soc/msg39107.html

Quoted 28 lines

Thanks,
Kukjin
Quoted 25 lines
Quoted 2 lines
Signed-off-by Yadwinder Singh Brar <[email protected]>
Tested this on SMDK5250 board, system boot is fine now, hence
Tested-by Pankaj Dubey <[email protected]>
Quoted 18 lines
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -0
index bc27cc2..95b5b51 100644
@@ -190,6 +190,7 @@
  				regulator-name = "P1.8V_LDO_OUT10";
  				regulator-min-microvolt = <1800000>;
  				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
  			};
 
  			ldo11_reg: LDO11 {

Pankaj Dubey

2015-04-28 11:04 UTC #13 lore raw

PATCH 1/2 ARM: dts: Fix bootup issue on smdk5250

In reply to Kukjin Kim

Hi Kukjin,

Quoted 15 lines · Kukjin Kim

Quoted 3 lines · Pankaj Dubey
Hi,
Hi,
Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client can't filter wrong ;)
Quoted 6 lines · Yadwinder Singh Brar
Quoted 5 lines
With default config on smdk5250 latest tree throws below message :
[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue

Quoted 8 lines

Quoted 5 lines
Quoted 5 lines
and hangs randomly because it reads wrong temperature value.
I can't figure out any direct relation between LDO10 and TMU from board schematics which I have. So making LDO10 always-on to fix issue for now.
Hmm...strange, I also can't see any relations now...but I need to contact to hardware guy before applying this, this fixes the problem though.

By any chance you got time to check with HW engineer, as issue is there without this patch, SMDK5250 fails to boot and hangs.

Thanks,
Pankaj Dubey

Quoted 29 lines

Thanks,
Kukjin
Quoted 24 lines
Quoted 2 lines
Signed-off-by Yadwinder Singh Brar <[email protected]>
Tested this on SMDK5250 board, system boot is fine now, hence
Tested-by Pankaj Dubey <[email protected]>
Quoted 17 lines
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
   1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250-smdk5250.dts +1 -0
index bc27cc2..95b5b51 100644
@@ -190,6 +190,7 @@
   				regulator-name = "P1.8V_LDO_OUT10";
   				regulator-min-microvolt = <1800000>;
   				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
   			};
 
   			ldo11_reg: LDO11 {