Skip to contentSkip to conversation

package/libpthsem: remove argp-standalone dependency

PATCH New Romain Naour 4 participants 6 messages May 2, 2015 – May 3, 2015

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/2 package/libpthsem: remove argp-standalone dependency

argp-standalone provide libargp.a and argp.h which are never used in libpthsem.

Signed-off-by Romain Naour <[email protected]>
---
 package/libpthsem/Config.in    | 1 -
 package/libpthsem/libpthsem.mk | 1 -
 2 files changed, 2 deletions(-)
package/libpthsem/Config.in +0 -1
index 932acec..3219de1 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_LIBPTHSEM
 	bool "libpthsem"
 	depends on BR2_USE_MMU # fork()
-	select BR2_PACKAGE_ARGP_STANDALONE
 	help
 	  GNU pth is a user mode multi threading library. pthsem is an extend
 	  version, with support for semaphores added.
package/libpthsem/libpthsem.mk +0 -1
index 7c1de86..f9f6f71 100644
@@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+
 LIBPTHSEM_LICENSE_FILES = COPYING
 LIBPTHSEM_AUTORECONF = YES
 LIBPTHSEM_INSTALL_STAGING = YES
-LIBPTHSEM_DEPENDENCIES = argp-standalone
 LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config
 
 ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
Signature · 1 line
1.9.3
author
#1 lore raw

PATCH 2/2 package/argp-standalone: is useless for (e)glibc toolchains

According to Thomas's remark [1], (e)glibc toolchains provide it's own argp.h version.
Also, it appears that argp.h from glibc is more up to date should be preferred to argp-standalone one.

[1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

Signed-off-by Romain Naour <[email protected]>

---
Note: I didn't add a comment in Config.in to tell that argp-standalone
package is useless for (e)glibc toolchains.

---
 package/argp-standalone/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/argp-standalone/Config.in +2 -0
index 5a0c051..3319dd9 100644
@@ -1,5 +1,7 @@
 config BR2_PACKAGE_ARGP_STANDALONE
 	bool "argp-standalone"
+	# glibc provides its own argp implementation.
+	depends on !BR2_TOOLCHAIN_USES_GLIBC
 	help
 	  Glibc hierarchical argument parsing standalone library.
Signature · 1 line
1.9.3
#2 lore raw

PATCH 2/2 package/argp-standalone: is useless for (e)glibc toolchains

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

According to Thomas's remark [1], (e)glibc toolchains provide it's own argp.h version.
Also, it appears that argp.h from glibc is more up to date should be preferred to argp-standalone one.

Quoted 6 lines

[1] http://lists.busybox.net/pipermail/buildroot/2015-May/127511.html

Signed-off-by Romain Naour <[email protected]>

---
Note: I didn't add a comment in Config.in to tell that argp-standalone
package is useless for (e)glibc toolchains.

I think it is OK to not display anything as it doesn't make sense on glibc.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/2 package/libpthsem: remove argp-standalone dependency

In reply to Romain Naour
Quoted 4 lines · Romain Naour

argp-standalone provide libargp.a and argp.h which are never used in libpthsem.

Signed-off-by Romain Naour <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Build-test with and without the _COMPAT option, and checked that there is no
reference to argp in the source.

Adding the original submitter of this package in Cc for final verification.
Gregory, do you remember why you added the argp-standalone dependency?

Regards,
Arnout

Quoted 30 lines
---
 package/libpthsem/Config.in    | 1 -
 package/libpthsem/libpthsem.mk | 1 -
 2 files changed, 2 deletions(-)
package/libpthsem/Config.in +0 -1
index 932acec..3219de1 100644
@@ -1,7 +1,6 @@
 config BR2_PACKAGE_LIBPTHSEM
 	bool "libpthsem"
 	depends on BR2_USE_MMU # fork()
-	select BR2_PACKAGE_ARGP_STANDALONE
 	help
 	  GNU pth is a user mode multi threading library. pthsem is an extend
 	  version, with support for semaphores added.
package/libpthsem/libpthsem.mk +0 -1
index 7c1de86..f9f6f71 100644
@@ -11,7 +11,6 @@ LIBPTHSEM_LICENSE = LGPLv2.1+
 LIBPTHSEM_LICENSE_FILES = COPYING
 LIBPTHSEM_AUTORECONF = YES
 LIBPTHSEM_INSTALL_STAGING = YES
-LIBPTHSEM_DEPENDENCIES = argp-standalone
 LIBPTHSEM_CONFIG_SCRIPTS = pthsem-config
 
 ifeq ($(BR2_PACKAGE_LIBPTHSEM_COMPAT),y)
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
author
#4 lore raw

PATCH 1/2 package/libpthsem: remove argp-standalone dependency

Hi Arnout, All

Le 02/05/2015 14:21, Arnout Vandecappelle a ?crit :

Quoted 6 lines · Romain Naour
Quoted 4 lines

argp-standalone provide libargp.a and argp.h which are never used in libpthsem.

Signed-off-by Romain Naour <[email protected]>
Quoted 8 lines
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Build-test with and without the _COMPAT option, and checked that there is no
reference to argp in the source.

Adding the original submitter of this package in Cc for final verification.
Gregory, do you remember why you added the argp-standalone dependency?

Peter find why argp-standalone was added to libpthsem:
http://git.buildroot.net/buildroot/commit/?id=25206d6e26dc4ce9c272e68876f31d0ca7d30e67

Gregory is also the original submitter of bcusdk package and it seems that he added argp-standalone dependency to libpthsem instead of bcusdk.

Thank you Arnout for your review and test.

Best regards,
Romain

Quoted 3 lines

Regards,
Arnout

Applied
#5 lore raw

PATCH 1/2 package/libpthsem: remove argp-standalone dependency

In reply to Romain Naour

Dear Romain Naour,

Quoted 8 lines · Romain Naour

argp-standalone provide libargp.a and argp.h which are never used in libpthsem.

Signed-off-by Romain Naour <[email protected]>
---
 package/libpthsem/Config.in    | 1 -
 package/libpthsem/libpthsem.mk | 1 -
 2 files changed, 2 deletions(-)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com