Skip to contentSkip to conversation

arm: mvebu: Remove "u-boot.kwb" CONFIG_BUILD_TARGET for non-SPL targets

PATCH New Stefan Roese 2 participants 3 messages May 4, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Kirkwood and Armada 370, 375, 38x, 39x, XP, 3700, 7K/8K, CN9130 SoC support
lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 arm: mvebu: Remove "u-boot.kwb" CONFIG_BUILD_TARGET for non-SPL targets

By removing this default build target, the "u-boot.kwb" target is not automatically generated. This fixes a temporary build error when using out-of-tree builds, as buildman does per default (reported by Simon).

When the full SPL support is added for these targets with the DDR training code, the "u-boot-spl.kwb" image will be generated automatically.

Users providing a special bin_hdr binary (binary.0) file can always add this binary file and generate the full firmware image by issuing the "make u-boot.kwb" command directly.

Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Luka Perkov <[email protected]>
---
 arch/arm/mach-mvebu/include/mach/config.h | 2 --
 1 file changed, 2 deletions(-)
arch/arm/mach-mvebu/include/mach/config.h +0 -2
index b326ec0..9dde710 100644
@@ -35,8 +35,6 @@
 /* Add target to build it automatically upon "make" */
 #ifdef CONFIG_SPL
 #define CONFIG_BUILD_TARGET	"u-boot-spl.kwb"
-#else
-#define CONFIG_BUILD_TARGET	"u-boot.kwb"
 #endif
 
 /* end of 16M scrubbed by training in bootrom */
Signature · 1 line
2.4.0
#1 lore raw

PATCH 1/1 arm: mvebu: Remove "u-boot.kwb" CONFIG_BUILD_TARGET for non-SPL targets

Hi Stefan,

Quoted 12 lines · Stefan Roese

By removing this default build target, the "u-boot.kwb" target is not automatically generated. This fixes a temporary build error when using out-of-tree builds, as buildman does per default (reported by Simon).

When the full SPL support is added for these targets with the DDR training code, the "u-boot-spl.kwb" image will be generated automatically.

Users providing a special bin_hdr binary (binary.0) file can always add this binary file and generate the full firmware image by issuing the "make u-boot.kwb" command directly.

Quoted 7 lines
Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Luka Perkov <[email protected]>
---
 arch/arm/mach-mvebu/include/mach/config.h | 2 --
 1 file changed, 2 deletions(-)
Reviewed-by Simon Glass <[email protected]>

How/when is this series being applied?

Regards,
Simon

author
#2 lore raw

PATCH 1/1 arm: mvebu: Remove "u-boot.kwb" CONFIG_BUILD_TARGET for non-SPL targets

Hi Simon,

Quoted 21 lines · Simon Glass
Quoted 12 lines · Stefan Roese

By removing this default build target, the "u-boot.kwb" target is not automatically generated. This fixes a temporary build error when using out-of-tree builds, as buildman does per default (reported by Simon).

When the full SPL support is added for these targets with the DDR training code, the "u-boot-spl.kwb" image will be generated automatically.

Users providing a special bin_hdr binary (binary.0) file can always add this binary file and generate the full firmware image by issuing the "make u-boot.kwb" command directly.

Quoted 7 lines
Signed-off-by Stefan Roese <[email protected]>
Cc Simon Glass <[email protected]>
Cc Prafulla Wadaskar <[email protected]>
Cc Luka Perkov <[email protected]>
---
  arch/arm/mach-mvebu/include/mach/config.h | 2 --
  1 file changed, 2 deletions(-)
Quoted 3 lines
Reviewed-by Simon Glass <[email protected]>

How/when is this series being applied?

Pretty soon. Luka mentioned to me off-list, that he planned to apply and push this series last weekend. Hopefully he will find the time to do it early this week.

Luka, can you please add this patch to the series as well?

Thanks,
Stefan