Patch breaks suspend
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.
I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive. Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit 5d5132059a1f652de9dc2d62a8ff15561e648d11
Author: Rafael J. Wysocki <[email protected]> Date: Sat Feb 22 00:48:31 2014 +0100
ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions of SATA devices and ports instead of registering special ACPI dock operations using register_hotplug_dock_device().
That change will allow the entire code handling those special ACPI dock operations to be dropped in the next commit.
Unfortunately I do not understand this part of the code and have no idea what I can do. Any pointers would be very appreciated.
Best regards,
Marian
Quoted 20 lines · Marian Marinov
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive. Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit5d5132059a1f652de9dc2d62a8ff15561e648d11Author: Rafael J. Wysocki <[email protected]> Date: Sat Feb 22 00:48:31 2014 +0100ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions of SATA devices and ports instead of registering special ACPI dock operations using
register_hotplug_dock_device().That change will allow the entire code handling those special ACPI dock operations to be dropped in the next commit.
Quoted 6 lines
Signed-off-by Rafael J. Wysocki <[email protected]>Reviewed-by Aaron Lu <[email protected]>Acked-by Tejun Heo <[email protected]>Unfortunately I do not understand this part of the code and have no idea what I can do. Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS category), assign it to me and CC Aaron?
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
Quoted 5 lines · Rafael J. Wysocki
Quoted 4 lines · Marian Marinov
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive.
Is it disappeared after resume?
Quoted 20 lines
Quoted 20 lines
Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit5d5132059a1f652de9dc2d62a8ff15561e648d11Author: Rafael J. Wysocki <[email protected]> Date: Sat Feb 22 00:48:31 2014 +0100ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions of SATA devices and ports instead of registering special ACPI dock operations using
register_hotplug_dock_device().That change will allow the entire code handling those special ACPI dock operations to be dropped in the next commit.
Signed-off-by Rafael J. Wysocki <[email protected]>Reviewed-by Aaron Lu <[email protected]>Acked-by Tejun Heo <[email protected]>
Quoted 7 lines
Quoted 2 lines
Unfortunately I do not understand this part of the code and have no idea what I can do. Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS category), assign it to me and CC Aaron?
Please attach dmesg, lspci and acpidump there when filing the bug, thanks.
BTW, this commit has been in upstream since v3.15, is your last kernel in use older than v3.15?
Thanks,
Aaron
Quoted 25 lines · Rafael J. Wysocki
Quoted 24 lines · Marian Marinov
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive. Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit5d5132059a1f652de9dc2d62a8ff15561e648d11Author: Rafael J. Wysocki <[email protected]> Date: Sat Feb 22 00:48:31 2014 +0100ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions of SATA devices and ports instead of registering special ACPI dock operations using
register_hotplug_dock_device().That change will allow the entire code handling those special ACPI dock operations to be dropped in the next commit.
Signed-off-by Rafael J. Wysocki <[email protected]>Reviewed-by Aaron Lu <[email protected]>Acked-by Tejun Heo <[email protected]>
Quoted 6 lines
Quoted 2 lines
Unfortunately I do not understand this part of the code and have no idea what I can do. Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS category), assign it to me and CC Aaron?
BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731
Added you and Aaron to the CC list.
What additional info can I provide you? Would you like any debug info from the kernel it self? Dmesg output?
Marian
Quoted 30 lines · Marian Marinov
Quoted 29 lines · Rafael J. Wysocki
Quoted 20 lines · Marian Marinov
Hi guys,
I have Lenovo T520 with one SSD and one SATA drive.I tried to upgrade to Linux 4.0 and found that after suspend and resume I can't access the second (SATA) drive. Both drives have bios encryption enabled.
I did a bisect and found that the following patch causes the issue:
commit5d5132059a1f652de9dc2d62a8ff15561e648d11Author: Rafael J. Wysocki <[email protected]> Date: Sat Feb 22 00:48:31 2014 +0100ACPI / ATA: Add hotplug contexts to ACPI companions of SATA devices
Modify the SATA subsystem to add hotplug contexts to ACPI companions of SATA devices and ports instead of registering special ACPI dock operations using
register_hotplug_dock_device().That change will allow the entire code handling those special ACPI dock operations to be dropped in the next commit.
Quoted 6 lines
Signed-off-by Rafael J. Wysocki <[email protected]>Reviewed-by Aaron Lu <[email protected]>Acked-by Tejun Heo <[email protected]>Unfortunately I do not understand this part of the code and have no idea what I can do. Any pointers would be very appreciated.
Well, not right from the top of my head, but this looks really suspicious to me.
Quoted 8 lines
Quoted 2 lines
Can you please file a bug entry for this at bugzilla.kernel.org (in the ACPI/BIOS category), assign it to me and CC Aaron?
BUG created: https://bugzilla.kernel.org/show_bug.cgi?id=97731
Added you and Aaron to the CC list.
What additional info can I provide you? Would you like any debug info from the kernel it self? Dmesg output?
Let's track this one in the BZ from now on if that's not a problem.
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.