Skip to contentSkip to conversation

thermal: armada: Update Armada 380 thermal sensor coefficients

PATCH New Gregory CLEMENT 1 participant 3 messages Apr 15, 2015 – May 6, 2015

Subsystems (3)
Stable branch Thermal Marvell mvebu thermal driver
lore
Share & tools
lore

Gregory CLEMENT

author
#0 lore raw

PATCH 1/1 thermal: armada: Update Armada 380 thermal sensor coefficients

From: Nadav Haklai <[email protected]>

Improve the Armada 380 thermal sensor accuracy by using updated formula. The updated formula is:
Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1

Signed-off-by Nadav Haklai <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
Cc <[email protected]> #v3.16
---
 drivers/thermal/armada_thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/thermal/armada_thermal.c +3 -3
index c2556cf5186b..01255fd65135 100644
@@ -224,9 +224,9 @@ static const struct armada_thermal_data armada380_data = {
 	.is_valid_shift = 10,
 	.temp_shift = 0,
 	.temp_mask = 0x3ff,
-	.coef_b = 1169498786UL,
-	.coef_m = 2000000UL,
-	.coef_div = 4289,
+	.coef_b = 2931108200UL,
+	.coef_m = 5000000UL,
+	.coef_div = 10502,
 	.inverted = true,
 };
Signature · 1 line
2.1.0
author
#1 lore raw

PATCH 1/1 thermal: armada: Update Armada 380 thermal sensor coefficients

Hi Zhang, Eduardo,

Quoted 9 lines · Gregory CLEMENT

From: Nadav Haklai <[email protected]>

Improve the Armada 380 thermal sensor accuracy by using updated formula. The updated formula is:
Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1

Signed-off-by Nadav Haklai <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
Cc <[email protected]> #v3.16

Any chance that this fix was merged in 4.1-rc ?

Thanks,

Gregory

Quoted 22 lines
---
 drivers/thermal/armada_thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/thermal/armada_thermal.c +3 -3
index c2556cf5186b..01255fd65135 100644
@@ -224,9 +224,9 @@ static const struct armada_thermal_data armada380_data = {
 	.is_valid_shift = 10,
 	.temp_shift = 0,
 	.temp_mask = 0x3ff,
-	.coef_b = 1169498786UL,
-	.coef_m = 2000000UL,
-	.coef_div = 4289,
+	.coef_b = 2931108200UL,
+	.coef_m = 5000000UL,
+	.coef_div = 10502,
 	.inverted = true,
 };
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 thermal: armada: Update Armada 380 thermal sensor coefficients

Hi Zhang, Eduardo,

Quoted 9 lines · Gregory CLEMENT

Hi Zhang, Eduardo,

Quoted 6 lines · Gregory CLEMENT

From: Nadav Haklai <[email protected]>

Improve the Armada 380 thermal sensor accuracy by using updated formula. The updated formula is:
Temperature[C degrees] = 0.4761 * tsen_vsen_out - 279.1

Quoted 5 lines
Quoted 3 lines
Signed-off-by Nadav Haklai <[email protected]>
Signed-off-by Gregory CLEMENT <[email protected]>
Cc <[email protected]> #v3.16

Any chance that this fix was merged in 4.1-rc ?

I saw that you missed the merge window. However I think this patch is really a fix and is a good candidate to be merged in 4.1.

Thanks,

Gregory

Quoted 30 lines

Thanks,

Gregory

Quoted 22 lines
---
 drivers/thermal/armada_thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/thermal/armada_thermal.c +3 -3
index c2556cf5186b..01255fd65135 100644
@@ -224,9 +224,9 @@ static const struct armada_thermal_data armada380_data = {
 	.is_valid_shift = 10,
 	.temp_shift = 0,
 	.temp_mask = 0x3ff,
-	.coef_b = 1169498786UL,
-	.coef_m = 2000000UL,
-	.coef_div = 4289,
+	.coef_b = 2931108200UL,
+	.coef_m = 5000000UL,
+	.coef_div = 10502,
 	.inverted = true,
 };
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com