: imx: mx6: use OTP for temperature grade and freq grade

The IMX6 has four different speed grades determined by eFUSE SPEED_GRADING (OCOTP_CFG3[17:16]).

Display this value to make it clear the difference regarding the CPU speed currently running at vs the max speed allowed per grade. Note that the power on CPU speed is determined by OCOTP_CFG4[18].

I see no indication in the IMX6SX reference manual that it has the same CPU speed grades in this OTP register.

Signed-off-by Tim Harvey <[email protected]>

---
 arch/arm/cpu/armv7/mx6/soc.c              | 26 ++++++++++++++++++++++++++
 arch/arm/imx-common/cpu.c                 | 17 +++++++++++++++++
 arch/arm/include/asm/arch-mx6/sys_proto.h |  1 +
 arch/arm/include/asm/proc                 |  1 +
 4 files changed, 45 insertions(+)
 create mode 120000 arch/arm/include/asm/proc

arch/arm/cpu/armv7/mx6/soc.c +26 -0

index dd34138..dc422a6 100644
@@ -83,6 +83,32 @@ u32 get_cpu_rev(void)
 	return (type << 12) | (reg + 0x10);
 }
 
+#define OCOTP_CFG3_SPEED_SHIFT          16
+#define OCOTP_CFG3_SPEED_1P2GHZ         0x3
+#define OCOTP_CFG3_SPEED_996MHZ         0x2
+#define OCOTP_CFG3_SPEED_852MHZ         0x1
+
+u32 get_cpu_speed_grade_hz(void)
+{
+	struct ocotp_regs *ocotp = (struct ocotp_regs *)OCOTP_BASE_ADDR;
+	struct fuse_bank *bank = &ocotp->bank[0];
+	struct fuse_bank0_regs *fuse =
+		(struct fuse_bank0_regs *)bank->fuse_regs;
+	uint32_t val;
+
+	val = readl(&fuse->cfg3);
+	val >>= OCOTP_CFG3_SPEED_SHIFT;
+	val &= 0x3;
+
+	if (val == OCOTP_CFG3_SPEED_1P2GHZ)
+		return 1200000000;
+	if (val == OCOTP_CFG3_SPEED_996MHZ)
+		return 996000000;
+	if (val == OCOTP_CFG3_SPEED_852MHZ)
+		return 852000000;
+	return 792000000;
+}
+
 #ifdef CONFIG_REVISION_TAG
 u32 __weak get_board_rev(void)
 {

arch/arm/imx-common/cpu.c +17 -0

index 067d08f..ead7f08 100644
@@ -151,11 +151,28 @@ int print_cpuinfo(void)
 
 	cpurev = get_cpu_rev();
 
+#if defined(CONFIG_MX6)
+	printf("CPU:   Freescale i.MX%s rev%d.%d",
+		get_imx_type((cpurev & 0xFF000) >> 12),
+		(cpurev & 0x000F0) >> 4,
+		(cpurev & 0x0000F) >> 0);
+	if (is_cpu_type(MXC_CPU_MX6SX))
+		printf(" at %d MHz", mxc_get_clock(MXC_ARM_CLK) / 1000000);
+	else {
+		printf(" %d MHz", get_cpu_speed_grade_hz() / 1000000);
+		if (get_cpu_speed_grade_hz() != mxc_get_clock(MXC_ARM_CLK)) {
+			printf(" (at %d MHz)",
+			       mxc_get_clock(MXC_ARM_CLK) / 1000000);
+		}
+	}
+	puts("\n");
+#else
 	printf("CPU:   Freescale i.MX%s rev%d.%d at %d MHz\n",
 		get_imx_type((cpurev & 0xFF000) >> 12),
 		(cpurev & 0x000F0) >> 4,
 		(cpurev & 0x0000F) >> 0,
 		mxc_get_clock(MXC_ARM_CLK) / 1000000);
+#endif
 
 #if defined(CONFIG_MX6) && defined(CONFIG_IMX6_THERMAL)
 	ret = uclass_get_device(UCLASS_THERMAL, 0, &thermal_dev);

arch/arm/include/asm/arch-mx6/sys_proto.h +1 -0

index 28ba844..a2cd0a9 100644
@@ -16,6 +16,7 @@
 
 u32 get_nr_cpus(void);
 u32 get_cpu_rev(void);
+u32 get_cpu_speed_grade_hz(void);
 
 /* returns MXC_CPU_ value */
 #define cpu_type(rev) (((rev) >> 12)&0xff)

arch/arm/include/asm/proc new file +1 -0

new file mode 120000
index 0000000..c7f3c20
@@ -0,0 +1 @@
+proc-armv
\ No newline at end of file

Hi Tim,

arch/arm/imx-common/cpu.c int print_cpuinfo(void) · line 175

Quoted 13 lines · Tim Harvey

arch/arm/imx-common/cpu.c +13 -0

+#if defined(CONFIG_IMX6_THERMAL)
+               switch (get_cpu_temp_grade(&minc, &maxc)) {
+               case TEMP_AUTOMOTIVE:
+                       puts(" automotive");
+                       break;
+               case TEMP_INDUSTRIAL:
+                       puts(" industrial");
+                       break;
+               case TEMP_EXTCOMMERCIAL:
+                       puts(" extended commercial");
+                       break;
+               default:
+                       puts(" commercial");

Could you please change 'commercial' to 'consumer'?

That's the term we see in the datasheet.

I also agree with Nikolay that it would be better to split the CPU line info in two now.

Thanks,

Fabio Estevam

Fabio,

It looks like I convinced you in the thread regarding the similar patch to the kernel
(http://www.spinics.net/lists/arm-kernel/msg417378.html) that the verbiage should remain as is, but I will follow-up with a v2 that puts the thermal information on the line with the current temperature.

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info, but perhaps adding the functions to obtain the info and use it for imx_thermal is beyond debate. Please let me know.

Hi Tim,

Quoted 7 lines · Tim Harvey

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Quoted 8 lines

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info,
but perhaps adding the functions to obtain the info and use it for imx_thermal
is beyond debate. Please let me know.

Could you please send (or include in the commit text) an example, how these infos are displayed now in the bootup log? Best in comparison to the "old" log. To see the output change resulting from the patchset.

Thanks,
Stefan

Quoted 20 lines · Stefan Roese

Hi Tim,

Quoted 7 lines · Tim Harvey

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Quoted 8 lines

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info,
but perhaps adding the functions to obtain the info and use it for imx_thermal
is beyond debate. Please let me know.

Quoted 7 lines

Could you please send (or include in the commit text) an example, how these infos are displayed now in the bootup log? Best in comparison to the "old" log. To see the output change resulting from the patchset.

Thanks,
Stefan

Stefan,

Good point - as I am guessing there will be debate about the 'amount' of info displayed and am open to suggestions on how to word it and/or how to enable it. In future revs of the patchset I'll be more explicit in the commit logs, but for now with the series applied I get this:

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

When I submit the next version I will split out adding the functions to get speed-grade and temperature-grade from using those functions in cpu_printinfo() as well as some may not be happy with adding more info to cpu_printinfo() but may find value in setting the thermal limits of imx_thermal properly based on temp-grade (Patch 4/4).

Tim

Quoted 58 lines · Tim Harvey

Quoted 20 lines · Stefan Roese

Hi Tim,

Quoted 7 lines · Tim Harvey

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Quoted 8 lines

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info,
but perhaps adding the functions to obtain the info and use it for imx_thermal
is beyond debate. Please let me know.

Quoted 7 lines

Could you please send (or include in the commit text) an example, how these infos are displayed now in the bootup log? Best in comparison to the "old" log. To see the output change resulting from the patchset.

Thanks,
Stefan

Stefan,

Good point - as I am guessing there will be debate about the 'amount' of info displayed and am open to suggestions on how to word it and/or how to enable it. In future revs of the patchset I'll be more explicit in the commit logs, but for now with the series applied I get this:

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

When I submit the next version I will split out adding the functions to get speed-grade and temperature-grade from using those functions in cpu_printinfo() as well as some may not be happy with adding more info to cpu_printinfo() but may find value in setting the thermal limits of imx_thermal properly based on temp-grade (Patch 4/4).

Quoted 1 line

Tim

Stefano,

I've cc'd all the maintainers I could find of MX6 based boards for comment on adding this text to the mx6 print_cpuinfo. I would like to see some ack/review from them otherwise I would think silence is considered a thumbs up ;)

Stefano,

I've cc'd all the maintainers I could find of MX6 based boards for comment on adding this text to the mx6 print_cpuinfo. I would like to see some ack/review from them otherwise I would think silence is considered a thumbs up ;)

Quoted 58 lines · Stefan Roese

Quoted 20 lines

Hi Tim,

Quoted 7 lines · Tim Harvey

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Quoted 8 lines

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info,
but perhaps adding the functions to obtain the info and use it for imx_thermal
is beyond debate. Please let me know.

Quoted 7 lines

Could you please send (or include in the commit text) an example, how these infos are displayed now in the bootup log? Best in comparison to the "old" log. To see the output change resulting from the patchset.

Thanks,
Stefan

Stefan,

Good point - as I am guessing there will be debate about the 'amount' of info displayed and am open to suggestions on how to word it and/or how to enable it. In future revs of the patchset I'll be more explicit in the commit logs, but for now with the series applied I get this:

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

When I submit the next version I will split out adding the functions to get speed-grade and temperature-grade from using those functions in cpu_printinfo() as well as some may not be happy with adding more info to cpu_printinfo() but may find value in setting the thermal limits of imx_thermal properly based on temp-grade (Patch 4/4).

Quoted 1 line

Tim

Stefano,

I've cc'd all the maintainers I could find of MX6 based boards for comment on adding this text to the mx6 print_cpuinfo. I would like to see some ack/review from them otherwise I would think silence is considered a thumbs up ;)

Quoted 58 lines · Stefan Roese

Quoted 20 lines

Hi Tim,

Quoted 7 lines · Tim Harvey

The MX6 has OTP bits specifying the processor speed grade as well as temperature grade.

This series adds functions to return this information as well as adds the details to the CPU info displayed.

Quoted 8 lines

Additionally we use the temperature grade to replace the hard-coded limits in imx_thermal.c

I expect some possible discussion/debate regarding the displaying of this info,
but perhaps adding the functions to obtain the info and use it for imx_thermal
is beyond debate. Please let me know.

Quoted 7 lines

Could you please send (or include in the commit text) an example, how these infos are displayed now in the bootup log? Best in comparison to the "old" log. To see the output change resulting from the patchset.

Thanks,
Stefan

Stefan,

Good point - as I am guessing there will be debate about the 'amount' of info displayed and am open to suggestions on how to word it and/or how to enable it. In future revs of the patchset I'll be more explicit in the commit logs, but for now with the series applied I get this:

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

When I submit the next version I will split out adding the functions to get speed-grade and temperature-grade from using those functions in cpu_printinfo() as well as some may not be happy with adding more info to cpu_printinfo() but may find value in setting the thermal limits of imx_thermal properly based on temp-grade (Patch 4/4).

Quoted 1 line

Tim

Stefano,

I've cc'd all the maintainers I could find of MX6 based boards for comment on adding this text to the mx6 print_cpuinfo. I would like to see some ack/review from them otherwise I would think silence is considered a thumbs up ;)

Regards,

Tim
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Hello Tim,

Quoted 17 lines

Quoted 17 lines

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

Where do get the speed grade ant temperature grade information from i.MX6SOLO / DL from? The fusemap in the reference manual says nothing about these info for SOLO / DL and a Freescale FAE stated that these information is not present in the fuses for SOLO / DL.

Regards,

Markus

Quoted 2 lines · Markus Niebel

Hello Tim,

<snip>

Quoted 17 lines

Quoted 17 lines

Quoted 17 lines

IMX6Q automotive (1GHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6Q rev1.2 at 792 MHz
- after Patch 1/4:
CPU: Freescale i.MX6Q rev1.2 996 MHz (at 792 MHz)
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6Q rev1.2 automotive (-40C to 125C) 996 MHz (at 792 MHz)

IMX6S industrial (800MHz capable) powering up at 800MHz:
- before:
CPU: Freescale i.MX6SOLO rev1.2 at 792 MHz
- after Patch 1/4: (max speed == cur speed)
CPU: Freescale i.MX6SOLO rev1.2 792 MHz
- after Patch 3/4 (if CONFIG_IMX6_THERMAL defined)
CPU: Freescale i.MX6SOLO rev1.2 industrial (-40C to 105C) 792 MHz

<snip>

Quoted 9 lines

Where do get the speed grade ant temperature grade information from i.MX6SOLO / DL from? The fusemap in the reference manual says nothing about these info for SOLO / DL and a Freescale FAE stated that these information is not present in the fuses for SOLO / DL.

Regards,

Markus

Markus,

Your right - There is no indication in the IMX6SDLRM that OTP indicates either temperature grade 'or' speed grade, however my testing looks like they implement the same OTP settings for this as the IMX6DUAL/IMX6QUAD as indicated in the IMX6DQRM.

I have tested these patches with the following SoC's I have available:
- MCIMX6S7CVM08AC (IMX6S r1.2, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct)
- MCIMX6S5EVM10AC (IMX6S r1.2, Extended Commercial temp, 1GHz) - shows 'extended commercial (-20C to 105C) 996 MHz (at 792 MHz)' (correct)
- MCIMX6U7CVM08AB (IMX6DL r1.1, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct)
- MCIMX6Q6AVT10AC (IMX6Q r1.2. Automotive temp, 1GHz) - shows 'automotive (-40C to 125C) 996 MHz (at 792 MHz)' (correct)

I'll send our FAE a question to verify - perhaps your FAE simply answered the questions based on the reference manual (which is notoriously lacking info and in some cases wrong).

I encourage anyone with additional parts to test these patches and report if they show accurate information. If anyone has any IMX6SX I would appreciate removing the check that ignores the OTP for that and seeing if the results make sense.

Hi Tim,

Quoted 1 line · Tim Harvey

Quoted 16 lines

Your right - There is no indication in the IMX6SDLRM that OTP indicates either temperature grade 'or' speed grade, however my testing looks like they implement the same OTP settings for this as the IMX6DUAL/IMX6QUAD as indicated in the IMX6DQRM.

I have tested these patches with the following SoC's I have available:
- MCIMX6S7CVM08AC (IMX6S r1.2, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct)
- MCIMX6S5EVM10AC (IMX6S r1.2, Extended Commercial temp, 1GHz) - shows 'extended commercial (-20C to 105C) 996 MHz (at 792 MHz)' (correct)
- MCIMX6U7CVM08AB (IMX6DL r1.1, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct)
- MCIMX6Q6AVT10AC (IMX6Q r1.2. Automotive temp, 1GHz) - shows 'automotive (-40C to 125C) 996 MHz (at 792 MHz)' (correct)

Quoted 8 lines

I'll send our FAE a question to verify - perhaps your FAE simply answered the questions based on the reference manual (which is notoriously lacking info and in some cases wrong).

I encourage anyone with additional parts to test these patches and report if they show accurate information. If anyone has any IMX6SX I would appreciate removing the check that ignores the OTP for that and seeing if the results make sense.

Here are the results from riotboard (imx6s) testing with your patches against Stefano's tree:

Before:
CPU: Freescale i.MX6SOLO rev1.1 at 792 MHz

After patch 1:
CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792 MHz)

After patch 2:
CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792 MHz)

After patch 3:
CPU: Freescale i.MX6SOLO rev1.1 // No idea why I lost the MHz values

After patch 4:
CPU: Freescale i.MX6SOLO rev1.1

MHz values are missing after patch 3, and looking diagonally at the code I don't see a reason. Next, riotboard doesn't have CONFIG_IMX6_THERMAL by default. When added, I get this:

$ make u-boot.imx
...

Are there additional CONFIG dependencies?

Regards,
Nikolay

Quoted 5 lines · Nikolay Dimitrov

Hi Tim,

Quoted 1 line · Tim Harvey

<snip>

Quoted 32 lines

Quoted 16 lines

Your right - There is no indication in the IMX6SDLRM that OTP indicates either temperature grade 'or' speed grade, however my testing looks like they implement the same OTP settings for this as the IMX6DUAL/IMX6QUAD as indicated in the IMX6DQRM.

I have tested these patches with the following SoC's I have
available: - MCIMX6S7CVM08AC (IMX6S r1.2, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct) - MCIMX6S5EVM10AC (IMX6S r1.2, Extended Commercial temp, 1GHz) - shows 'extended commercial (-20C to 105C) 996 MHz (at 792 MHz)' (correct) - MCIMX6U7CVM08AB (IMX6DL r1.1, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct) - MCIMX6Q6AVT10AC (IMX6Q r1.2. Automotive temp, 1GHz) - shows 'automotive (-40C to 125C) 996 MHz (at 792 MHz)' (correct)

Quoted 8 lines

I'll send our FAE a question to verify - perhaps your FAE simply
answered the questions based on the reference manual (which is
notoriously lacking info and in some cases wrong).

I encourage anyone with additional parts to test these patches and report if they show accurate information. If anyone has any IMX6SX I would appreciate removing the check that ignores the OTP for that and seeing if the results make sense.

Here are the results from riotboard (imx6s) testing with your patches against Stefano's tree:

Before: CPU: Freescale i.MX6SOLO rev1.1 at 792 MHz

Quoted 8 lines

After patch 1: CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792
MHz)

After patch 2: CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792
MHz)

After patch 3: CPU: Freescale i.MX6SOLO rev1.1 // No idea why I
lost the MHz values

Nikolay,

thats an issue in my patch if you don't have CONFIG_IMX6_THERMAL. I'll fix in a followup patch version

Quoted 10 lines

After patch 4: CPU: Freescale i.MX6SOLO rev1.1

MHz values are missing after patch 3, and looking diagonally at the code I don't see a reason. Next, riotboard doesn't have CONFIG_IMX6_THERMAL by default. When added, I get this:

$ make u-boot.imx ...

<snip>

Quoted 1 line

Quoted 1 line

Are there additional CONFIG dependencies?

Looks like CONFIG_IMX6_THERMAL also needs CONFIG_DM_THERMAL (includes thermal-uclass from drivers/thermal/Makefile)

Thanks for testing this. If you can get it working please let me know what the actual part markings are on the parts you test with.

Hi Tim,

Quoted 67 lines · Tim Harvey

Quoted 5 lines · Nikolay Dimitrov

Hi Tim,

Quoted 1 line · Tim Harvey

<snip>

Quoted 33 lines

Quoted 17 lines

Your right - There is no indication in the IMX6SDLRM that OTP indicates either temperature grade 'or' speed grade, however my testing looks like they implement the same OTP settings for this as the IMX6DUAL/IMX6QUAD as indicated in the IMX6DQRM.

I have tested these patches with the following SoC's I have
available: - MCIMX6S7CVM08AC (IMX6S r1.2, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct)
- MCIMX6S5EVM10AC (IMX6S r1.2, Extended Commercial temp, 1GHz)
- shows 'extended commercial (-20C to 105C) 996 MHz (at 792 MHz)' (correct) - MCIMX6U7CVM08AB (IMX6DL r1.1, Industrial temp, 800MHz) - shows 'industrial (-40C to 105C) 792 MHz' (correct) - MCIMX6Q6AVT10AC (IMX6Q r1.2. Automotive temp, 1GHz)
- shows 'automotive (-40C to 125C) 996 MHz (at 792 MHz)' (correct)

Quoted 8 lines

I'll send our FAE a question to verify - perhaps your FAE simply answered the questions based on the reference manual (which is notoriously lacking info and in some cases wrong).

I encourage anyone with additional parts to test these patches and report if they show accurate information. If anyone has any IMX6SX I would appreciate removing the check that ignores the OTP for that and seeing if the results make sense.

Here are the results from riotboard (imx6s) testing with your patches against Stefano's tree:

Before: CPU: Freescale i.MX6SOLO rev1.1 at 792 MHz

Quoted 8 lines

After patch 1: CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792
MHz)

After patch 2: CPU: Freescale i.MX6SOLO rev1.1 996 MHz (at 792
MHz)

After patch 3: CPU: Freescale i.MX6SOLO rev1.1 // No idea why
I lost the MHz values

Nikolay,

thats an issue in my patch if you don't have CONFIG_IMX6_THERMAL. I'll fix in a followup patch version

Quoted 10 lines

After patch 4: CPU: Freescale i.MX6SOLO rev1.1

MHz values are missing after patch 3, and looking diagonally at the code I don't see a reason. Next, riotboard doesn't have CONFIG_IMX6_THERMAL by default. When added, I get this:

$ make u-boot.imx ...

<snip>

Quoted 1 line

Quoted 7 lines

Quoted 1 line

Are there additional CONFIG dependencies?

Looks like CONFIG_IMX6_THERMAL also needs CONFIG_DM_THERMAL (includes thermal-uclass from drivers/thermal/Makefile)

Thanks for testing this. If you can get it working please let me know what the actual part markings are on the parts you test with.

The updated CONFIGs fixed the build. Here are the outputs of all boards where I can easily run mainline U-Boot.

Riotboard 1, part number MCIMX6S5DVM10AB
======================================== CPU: Freescale i.MX6SOLO
rev1.1 commercial (0C to 95C) 996 MHz (at 792 MHz) CPU: Temperature
53 C

Riotboard 2, part number MCIMX6S5DVM10AC
======================================== CPU: Freescale i.MX6SOLO
rev1.2 commercial (0C to 95C) 996 MHz (at 792 MHz) CPU: Temperature
42 C

Marsboard, part number MCIMX6D5EYM10AC
====================================== CPU: Freescale i.MX6D rev1.2
extended commercial (-20C to 105C) 996 MHz (at 792 MHz) CPU:
Temperature 38 C

Btw, as the information in the "CPU:" line gets bigger and bigger, it's probably worth thinking about splitting it into separate lines. This will simplify the text formatting tricks, can be easily controlled by CONFIG directives and can look neater. But even if you don't change it, it looks fine to me - I like to see info, and if I don't need it, I can always cut it off easily.

Thanks for working on this patch series.

Regards, Nikolay

PS: I have also some more customer boards with imx6d rev 1.3 and some imx6q with unknown revisions, but can't test there as mainline u-boot has broken spi flash support in SPL since 2014.07 and I hadn't had time to fix it and port it (although I would love to).