PMIC/REGULATOR cleanup and Sandbox tests

The cleanup includes:
- pmic.h - fix mistakes in a few comments
- pmic operations: value 'reg_count' - redefine as function call
- fix function name: pmic_bind_childs() -> pmic_bind_children()
- pmic_bind_children: increment child_info pointer if operation in loop fail

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 drivers/power/pmic/pmic-uclass.c | 25 +++++++++----------------
 include/power/pmic.h             | 39 ++++++++++++++++++++-------------------
 2 files changed, 29 insertions(+), 35 deletions(-)

drivers/power/pmic/pmic-uclass.c +9 -16

index d82d3da..6766bd5 100644
@@ -27,8 +27,8 @@ static ulong str_get_num(const char *ptr, const char *maxptr)
        return simple_strtoul(ptr, NULL, 0);
 }
 
-int pmic_bind_childs(struct udevice *pmic, int offset,
-                    const struct pmic_child_info *child_info)
+int pmic_bind_children(struct udevice *pmic, int offset,
+                      const struct pmic_child_info *child_info)
 {
        const struct pmic_child_info *info;
        const void *blob = gd->fdt_blob;

@@ -68,6 +68,7 @@ int pmic_bind_childs(struct udevice *pmic, int offset,
                        if (!drv) {
                                debug("  - driver: '%s' not found!\n",
                                      info->driver);
+                               info++;
                                continue;
                        }
 

@@ -77,6 +78,7 @@ int pmic_bind_childs(struct udevice *pmic, int offset,
                                          node, &child);
                        if (ret) {
                                debug("  - child binding error: %d\n", ret);
+                               info++;
                                continue;
                        }
 

@@ -110,16 +112,16 @@ int pmic_get(const char *name, struct udevice **devp)
 int pmic_reg_count(struct udevice *dev)
 {
        const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       if (!ops)
+
+       if (!ops || !ops->reg_count)
                return -ENOSYS;
 
-       return ops->reg_count;
+       return ops->reg_count(dev);
 }
 
 int pmic_read(struct udevice *dev, uint reg, uint8_t *buffer, int len)
 {
        const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       int ret;
 
        if (!buffer)
                return -EFAULT;

@@ -127,17 +129,12 @@ int pmic_read(struct udevice *dev, uint reg, uint8_t *buffer, int len)
        if (!ops || !ops->read)
                return -ENOSYS;
 
-       ret = ops->read(dev, reg, buffer, len);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ops->read(dev, reg, buffer, len);
 }
 
 int pmic_write(struct udevice *dev, uint reg, const uint8_t *buffer, int len)
 {
        const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       int ret;
 
        if (!buffer)
                return -EFAULT;

@@ -145,11 +142,7 @@ int pmic_write(struct udevice *dev, uint reg, const uint8_t *buffer, int len)
        if (!ops || !ops->write)
                return -ENOSYS;
 
-       ret = ops->write(dev, reg, buffer, len);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ops->write(dev, reg, buffer, len);
 }
 
 UCLASS_DRIVER(pmic) = {

include/power/pmic.h +20 -20

index f7ae781..eb152ef 100644
@@ -11,9 +11,9 @@
 #ifndef __CORE_PMIC_H_
 #define __CORE_PMIC_H_
 
-#include <linux/list.h>
-#include <spi.h>
 #include <i2c.h>
+#include <spi.h>
+#include <linux/list.h>
 #include <power/power_chrg.h>
 
 enum { PMIC_I2C, PMIC_SPI, PMIC_NONE};

@@ -90,10 +90,10 @@ struct pmic {
  * U-Boot PMIC Framework
  * =====================
  *
- * UCLASS_PMIC - The is designed to provide an I/O interface for PMIC devices.
+ * UCLASS_PMIC - This is designed to provide an I/O interface for PMIC devices.
  *
  * For the multi-function PMIC devices, this can be used as parent I/O device
- * for each IC's interface. Then, each children uses its parent for read/write.
+ * for each IC's interface. Then, each child uses its parent for read/write.
  *
  * The driver model tree could look like this:
  *

@@ -112,8 +112,8 @@ struct pmic {
  * We can find two PMIC cases in boards design:
  * - single I/O interface
  * - multiple I/O interfaces
- * We bind single PMIC device for each interface, to provide an I/O as a parent,
- * of proper child devices. Each child usually implements a different function,
+ * We bind a single PMIC device for each interface, to provide an I/O for
+ * its child devices. And each child usually implements a different function,
  * controlled by the same interface.
  *
  * The binding should be done automatically. If device tree nodes/subnodes are

@@ -131,7 +131,7 @@ struct pmic {
  * Note:
  * Each PMIC interface driver should use a different compatible string.
  *
- * If each pmic child device driver need access the PMIC-specific registers,
+ * If a PMIC child device driver needs access the PMIC-specific registers,
  * it need know only the register address and the access can be done through
  * the parent pmic driver. Like in the example:
  *

@@ -141,10 +141,10 @@ struct pmic {
  * |   |_ dev: my_regulator (set value/etc..)  (is child)   - UCLASS_REGULATOR
  *
  * To ensure such device relationship, the pmic device driver should also bind
- * all its child devices, like in the example below. It should be done by call
- * the 'pmic_bind_childs()' - please refer to the description of this function
- * in this header file. This function, should be called in the driver's '.bind'
- * method.
+ * all its child devices, like in the example below. It can be done by calling
+ * the 'pmic_bind_children()' - please refer to the function description, which
+ * can be found in this header file. This function, should be called inside the
+ * driver's bind() method.
  *
  * For the example driver, please refer the MAX77686 driver:
  * - 'drivers/power/pmic/max77686.c'

@@ -156,18 +156,19 @@ struct pmic {
  * Should be implemented by UCLASS_PMIC device drivers. The standard
  * device operations provides the I/O interface for it's childs.
  *
- * @reg_count: devices register count
+ * @reg_count: device's register count
  * @read:      read 'len' bytes at "reg" and store it into the 'buffer'
  * @write:     write 'len' bytes from the 'buffer' to the register at 'reg' address
  */
 struct dm_pmic_ops {
-       int reg_count;
+       int (*reg_count)(struct udevice *dev);
        int (*read)(struct udevice *dev, uint reg, uint8_t *buffer, int len);
        int (*write)(struct udevice *dev, uint reg, const uint8_t *buffer,
                     int len);
 };
 
-/* enum pmic_op_type - used for various pmic devices operation calls,
+/**
+ * enum pmic_op_type - used for various pmic devices operation calls,
  * for reduce a number of lines with the same code for read/write or get/set.
  *
  * @PMIC_OP_GET - get operation

@@ -181,7 +182,7 @@ enum pmic_op_type {
 /**
  * struct pmic_child_info - basic device's child info for bind child nodes with
  * the driver by the node name prefix and driver name. This is a helper struct
- * for function: pmic_bind_childs().
+ * for function: pmic_bind_children().
  *
  * @prefix - child node name prefix (or its name if is unique or single)
  * @driver - driver name for the sub-node with prefix

@@ -194,7 +195,7 @@ struct pmic_child_info {
 /* drivers/power/pmic-uclass.c */
 
 /**
- * pmic_bind_childs() - bind drivers for given parent pmic, using child info
+ * pmic_bind_children() - bind drivers for given parent pmic, using child info
  * found in 'child_info' array.
  *
  * @pmic       - pmic device - the parent of found child's

@@ -216,7 +217,7 @@ struct pmic_child_info {
  *     (pmic - bind automatically by compatible)
  *     compatible = "my_pmic";
  *     ...
- *     (pmic's childs - bind by pmic_bind_childs())
+ *     (pmic's childs - bind by pmic_bind_children())
  *     (nodes prefix: "ldo", driver: "my_regulator_ldo")
  *     ldo1 { ... };
  *     ldo2 { ... };

@@ -226,8 +227,8 @@ struct pmic_child_info {
  *     buck2 { ... };
  * };
  */
-int pmic_bind_childs(struct udevice *pmic, int offset,
-                    const struct pmic_child_info *child_info);
+int pmic_bind_children(struct udevice *pmic, int offset,
+                      const struct pmic_child_info *child_info);
 
 /**
  * pmic_get: get the pmic device using its name
--

1.9.1

Hi Przemyslaw,

Quoted 6 lines · Przemyslaw Marczak

The cleanup includes:
- pmic.h - fix mistakes in a few comments
- pmic operations: value 'reg_count' - redefine as function call
- fix function name: pmic_bind_childs() -> pmic_bind_children()
- pmic_bind_children: increment child_info pointer if operation in loop fail

Quoted 6 lines

Signed-off-by Przemyslaw Marczak <[email protected]>

---
  drivers/power/pmic/pmic-uclass.c | 25 +++++++++----------------
  include/power/pmic.h             | 39 ++++++++++++++++++++-------------------
  2 files changed, 29 insertions(+), 35 deletions(-)

Acked-by Simon Glass <[email protected]>

Tested on sandbox:

Tested-by Simon Glass <[email protected]>

BTW in pmic_bind_children() you have something like this:

info = child_info;

while (info->prefix) {
    ...
    if (ret) {
       debug("  - child binding error: %d\n", ret);
       info++;
       continue;
    }

I think this would be better:

for (info = child_info; info->prefix, info++)

and remove the three info++ expressions inside the loop.

Quoted 206 lines

drivers/power/pmic/pmic-uclass.c +9 -16

index d82d3da..6766bd5 100644
@@ -27,8 +27,8 @@ static ulong str_get_num(const char *ptr, const char *maxptr)
         return simple_strtoul(ptr, NULL, 0);
  }
 
-int pmic_bind_childs(struct udevice *pmic, int offset,
-                    const struct pmic_child_info *child_info)
+int pmic_bind_children(struct udevice *pmic, int offset,
+                      const struct pmic_child_info *child_info)
  {
         const struct pmic_child_info *info;
         const void *blob = gd->fdt_blob;

@@ -68,6 +68,7 @@ int pmic_bind_childs(struct udevice *pmic, int offset,
                         if (!drv) {
                                 debug("  - driver: '%s' not found!\n",
                                       info->driver);
+                               info++;
                                 continue;
                         }
 

@@ -77,6 +78,7 @@ int pmic_bind_childs(struct udevice *pmic, int offset,
                                           node, &child);
                         if (ret) {
                                 debug("  - child binding error: %d\n", ret);
+                               info++;
                                 continue;
                         }
 

@@ -110,16 +112,16 @@ int pmic_get(const char *name, struct udevice **devp)
  int pmic_reg_count(struct udevice *dev)
  {
         const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       if (!ops)
+
+       if (!ops || !ops->reg_count)
                 return -ENOSYS;
 
-       return ops->reg_count;
+       return ops->reg_count(dev);
  }
 
  int pmic_read(struct udevice *dev, uint reg, uint8_t *buffer, int len)
  {
         const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       int ret;
 
         if (!buffer)
                 return -EFAULT;

@@ -127,17 +129,12 @@ int pmic_read(struct udevice *dev, uint reg, uint8_t *buffer, int len)
         if (!ops || !ops->read)
                 return -ENOSYS;
 
-       ret = ops->read(dev, reg, buffer, len);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ops->read(dev, reg, buffer, len);
  }
 
  int pmic_write(struct udevice *dev, uint reg, const uint8_t *buffer, int len)
  {
         const struct dm_pmic_ops *ops = dev_get_driver_ops(dev);
-       int ret;
 
         if (!buffer)
                 return -EFAULT;

@@ -145,11 +142,7 @@ int pmic_write(struct udevice *dev, uint reg, const uint8_t *buffer, int len)
         if (!ops || !ops->write)
                 return -ENOSYS;
 
-       ret = ops->write(dev, reg, buffer, len);
-       if (ret)
-               return ret;
-
-       return 0;
+       return ops->write(dev, reg, buffer, len);
  }
 
  UCLASS_DRIVER(pmic) = {

include/power/pmic.h +20 -19

index f7ae781..eb152ef 100644
@@ -11,9 +11,9 @@
  #ifndef __CORE_PMIC_H_
  #define __CORE_PMIC_H_
 
-#include <linux/list.h>
-#include <spi.h>
  #include <i2c.h>
+#include <spi.h>
+#include <linux/list.h>
  #include <power/power_chrg.h>
 
  enum { PMIC_I2C, PMIC_SPI, PMIC_NONE};

@@ -90,10 +90,10 @@ struct pmic {
   * U-Boot PMIC Framework
   * =====================
   *
- * UCLASS_PMIC - The is designed to provide an I/O interface for PMIC devices.
+ * UCLASS_PMIC - This is designed to provide an I/O interface for PMIC devices.
   *
   * For the multi-function PMIC devices, this can be used as parent I/O device
- * for each IC's interface. Then, each children uses its parent for read/write.
+ * for each IC's interface. Then, each child uses its parent for read/write.
   *
   * The driver model tree could look like this:
   *

@@ -112,8 +112,8 @@ struct pmic {
   * We can find two PMIC cases in boards design:
   * - single I/O interface
   * - multiple I/O interfaces
- * We bind single PMIC device for each interface, to provide an I/O as a parent,
- * of proper child devices. Each child usually implements a different function,
+ * We bind a single PMIC device for each interface, to provide an I/O for
+ * its child devices. And each child usually implements a different function,
   * controlled by the same interface.
   *
   * The binding should be done automatically. If device tree nodes/subnodes are

@@ -131,7 +131,7 @@ struct pmic {
   * Note:
   * Each PMIC interface driver should use a different compatible string.
   *
- * If each pmic child device driver need access the PMIC-specific registers,
+ * If a PMIC child device driver needs access the PMIC-specific registers,
   * it need know only the register address and the access can be done through
   * the parent pmic driver. Like in the example:
   *

@@ -141,10 +141,10 @@ struct pmic {
   * |   |_ dev: my_regulator (set value/etc..)  (is child)   - UCLASS_REGULATOR
   *
   * To ensure such device relationship, the pmic device driver should also bind
- * all its child devices, like in the example below. It should be done by call
- * the 'pmic_bind_childs()' - please refer to the description of this function
- * in this header file. This function, should be called in the driver's '.bind'
- * method.
+ * all its child devices, like in the example below. It can be done by calling
+ * the 'pmic_bind_children()' - please refer to the function description, which
+ * can be found in this header file. This function, should be called inside the
+ * driver's bind() method.
   *
   * For the example driver, please refer the MAX77686 driver:
   * - 'drivers/power/pmic/max77686.c'

@@ -156,18 +156,19 @@ struct pmic {
   * Should be implemented by UCLASS_PMIC device drivers. The standard
   * device operations provides the I/O interface for it's childs.
   *
- * @reg_count: devices register count
+ * @reg_count: device's register count
   * @read:      read 'len' bytes at "reg" and store it into the 'buffer'
   * @write:     write 'len' bytes from the 'buffer' to the register at 'reg' address
   */
  struct dm_pmic_ops {
-       int reg_count;
+       int (*reg_count)(struct udevice *dev);
         int (*read)(struct udevice *dev, uint reg, uint8_t *buffer, int len);
         int (*write)(struct udevice *dev, uint reg, const uint8_t *buffer,
                      int len);
  };
 
-/* enum pmic_op_type - used for various pmic devices operation calls,
+/**
+ * enum pmic_op_type - used for various pmic devices operation calls,
   * for reduce a number of lines with the same code for read/write or get/set.
   *
   * @PMIC_OP_GET - get operation

@@ -181,7 +182,7 @@ enum pmic_op_type {
  /**
   * struct pmic_child_info - basic device's child info for bind child nodes with
   * the driver by the node name prefix and driver name. This is a helper struct
- * for function: pmic_bind_childs().
+ * for function: pmic_bind_children().
   *
   * @prefix - child node name prefix (or its name if is unique or single)
   * @driver - driver name for the sub-node with prefix

@@ -194,7 +195,7 @@ struct pmic_child_info {
  /* drivers/power/pmic-uclass.c */
 
  /**
- * pmic_bind_childs() - bind drivers for given parent pmic, using child info
+ * pmic_bind_children() - bind drivers for given parent pmic, using child info
   * found in 'child_info' array.
   *
   * @pmic       - pmic device - the parent of found child's

@@ -216,7 +217,7 @@ struct pmic_child_info {
   *     (pmic - bind automatically by compatible)
   *     compatible = "my_pmic";
   *     ...
- *     (pmic's childs - bind by pmic_bind_childs())
+ *     (pmic's childs - bind by pmic_bind_children())
   *     (nodes prefix: "ldo", driver: "my_regulator_ldo")
   *     ldo1 { ... };
   *     ldo2 { ... };

@@ -226,8 +227,8 @@ struct pmic_child_info {
   *     buck2 { ... };
   * };
   */
-int pmic_bind_childs(struct udevice *pmic, int offset,
-                    const struct pmic_child_info *child_info);
+int pmic_bind_children(struct udevice *pmic, int offset,
+                      const struct pmic_child_info *child_info);
 

Quoted 5 lines

include/power/pmic.h +0 -1

  /**
   * pmic_get: get the pmic device using its name
--

1.9.1

This update includes:
- add implementation of pmic_reg_count() method
- pmic_bind_children() - update function call name
- Kconfig: add new line at the end of file

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 drivers/power/pmic/Kconfig    |  2 +-
 drivers/power/pmic/max77686.c | 15 ++++++++++-----
 2 files changed, 11 insertions(+), 6 deletions(-)

This cleanup includes:
- remove of the preprocessor macros which pointed to long name functions
- update of the names of some regulator uclass driver functions
- cleanup of the function regulator_autoset()
- reword of some comments of regulator uclass header file
- regulator_get_by_platname: check error for uclass_find_* function calls
- add function: regulator_name_is_unique
- regulator post_bind(): check regulator name uniqueness
- fix mistakes in: regulator/Kconfig
- regulator.h: update comments

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 drivers/power/regulator/Kconfig            |   2 +-
 drivers/power/regulator/regulator-uclass.c | 104 +++++++++++++++++---------
 include/power/regulator.h                  | 116 +++++++++++++++--------------
 3 files changed, 128 insertions(+), 94 deletions(-)

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 board/samsung/odroid/odroid.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

board/samsung/odroid/odroid.c +4 -6

index 29de325..32155f1 100644
@@ -37,6 +37,7 @@ static const char *mmc_regulators[] = {
        "VDDQ_EMMC_1.8V",
        "VDDQ_EMMC_2.8V",
        "TFLASH_2.8V",
+       NULL,
 };
 
 void set_board_type(void)

@@ -427,9 +428,7 @@ int exynos_init(void)
 
 int exynos_power_init(void)
 {
-       int list_count = ARRAY_SIZE(mmc_regulators);
-
-       if (regulator_list_autoset(mmc_regulators, list_count, NULL, true))
+       if (regulator_list_autoset(mmc_regulators, NULL, true))
                error("Unable to init all mmc regulators");
 
        return 0;

@@ -441,7 +440,7 @@ static int s5pc210_phy_control(int on)
        struct udevice *dev;
        int ret;
 
-       ret = regulator_by_platname("VDD_UOTG_3.0V", &dev);
+       ret = regulator_get_by_platname("VDD_UOTG_3.0V", &dev);
        if (ret) {
                error("Regulator get error: %d", ret);
                return ret;

@@ -487,7 +486,7 @@ int board_usb_init(int index, enum usb_init_type init)
        /* Power off and on BUCK8 for LAN9730 */
        debug("LAN9730 - Turning power buck 8 OFF and ON.\n");
 
-       ret = regulator_by_platname("VCC_P3V3_2.85V", &dev);
+       ret = regulator_get_by_platname("VCC_P3V3_2.85V", &dev);
        if (ret) {
                error("Regulator get error: %d", ret);
                return ret;
--

1.9.1

This commit cleanups the use of function: failed(). The new function name is: failure(), and it is used for print errno and the errno-related message only.

The second change is choosing PMIC device by it's name, instead of seq number. Thanks to this change, for set the current device, call of pmic_get() is enough.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 common/cmd_pmic.c | 131 +++++++++++++++++++++++-------------------------------
 1 file changed, 55 insertions(+), 76 deletions(-)

This commit cleanups the regulator command.
The first change, is adjusting "regulator dev" command to use "regulator-name" constraint, for setting the operating device. Thanks to this, the regulator_get() function is removed.

This also updates do_list() function, with loop over uclass_find_* function calls, to prevent probe of all listed regulators.

This also cleanups the printing in command.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 common/cmd_regulator.c | 239 +++++++++++++++++++++++++------------------------
 1 file changed, 122 insertions(+), 117 deletions(-)

This commit cleanups the PMIC framework documentation.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 doc/driver-model/pmic-framework.txt | 20 +++++++++-----------
 1 file changed, 9 insertions(+), 11 deletions(-)

The function get_emul() in sandbox i2c bus driver, always returns first child as i2c emul device. This may only work for i2c devices with a single child, which is an only i2c emul device.

In case when i2c device has more than one child (e.g. PMIC), and one is i2c emul, then the function should search it by check uclass id for each child. This patch add this change to the get_emul().

Signed-off-by Przemyslaw Marczak <[email protected]>

Cc Simon Glass <[email protected]>

---
 drivers/i2c/sandbox_i2c.c | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

This commit adds emulation of sandbox PMIC device, which includes:
- PMIC I2C emulation driver
- PMIC I/O driver (UCLASS_PMIC)
- PMIC regulator driver (UCLASS_REGULATOR)

The sandbox PMIC has 12 significant registers and 4 as padding to 16 bytes, which allows using 'i2c md' command with the default count (16).

The sandbox PMIC provides regulators:
- 2x BUCK
- 2x LDO

Each, with adjustable output:
- Enable state
- Voltage
- Current limit (LDO1/BUCK1 only)
- Operation mode (different for BUCK and LDO)

Each attribute has it's own register, beside the enable state, which depends on operation mode.

The header file: sandbox_pmic.h includes PMIC's default register values, which are set on i2c pmic emul driver's probe() method.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 doc/device-tree-bindings/pmic/sandbox.txt      |  35 +++
 doc/device-tree-bindings/regulator/sandbox.txt |  45 ++++
 drivers/power/pmic/Kconfig                     |  25 ++
 drivers/power/pmic/Makefile                    |   3 +-
 drivers/power/pmic/i2c_pmic_emul.c             | 145 ++++++++++
 drivers/power/pmic/sandbox.c                   |  79 ++++++
 drivers/power/regulator/Kconfig                |  30 +++
 drivers/power/regulator/Makefile               |   1 +
 drivers/power/regulator/sandbox.c              | 355 +++++++++++++++++++++++++

 include/power/sandbox_pmic.h                   | 189 +++++++++++++
 10 files changed, 906 insertions(+), 1 deletion(-)
 create mode 100644 doc/device-tree-bindings/pmic/sandbox.txt
 create mode 100644 doc/device-tree-bindings/regulator/sandbox.txt
 create mode 100644 drivers/power/pmic/i2c_pmic_emul.c
 create mode 100644 drivers/power/pmic/sandbox.c
 create mode 100644 drivers/power/regulator/sandbox.c
 create mode 100644 include/power/sandbox_pmic.h

Hi Przemyslaw,

Quoted 37 lines · Przemyslaw Marczak

This commit adds emulation of sandbox PMIC device, which includes:
- PMIC I2C emulation driver
- PMIC I/O driver (UCLASS_PMIC)
- PMIC regulator driver (UCLASS_REGULATOR)

The sandbox PMIC has 12 significant registers and 4 as padding to 16 bytes, which allows using 'i2c md' command with the default count (16).

The sandbox PMIC provides regulators:
- 2x BUCK
- 2x LDO

Each, with adjustable output:
- Enable state
- Voltage
- Current limit (LDO1/BUCK1 only)
- Operation mode (different for BUCK and LDO)

Each attribute has it's own register, beside the enable state, which depends on operation mode.

The header file: sandbox_pmic.h includes PMIC's default register values, which are set on i2c pmic emul driver's probe() method.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
  doc/device-tree-bindings/pmic/sandbox.txt      |  35 +++
  doc/device-tree-bindings/regulator/sandbox.txt |  45 ++++
  drivers/power/pmic/Kconfig                     |  25 ++
  drivers/power/pmic/Makefile                    |   3 +-
  drivers/power/pmic/i2c_pmic_emul.c             | 145 ++++++++++
  drivers/power/pmic/sandbox.c                   |  79 ++++++
  drivers/power/regulator/Kconfig                |  30 +++
  drivers/power/regulator/Makefile               |   1 +
  drivers/power/regulator/sandbox.c              | 355 +++++++++++++++++++++++++
  include/power/sandbox_pmic.h                   | 189 +++++++++++++
  10 files changed, 906 insertions(+), 1 deletion(-)

Quoted 6 lines

create mode 100644 doc/device-tree-bindings/pmic/sandbox.txt create mode 100644 doc/device-tree-bindings/regulator/sandbox.txt create mode 100644 drivers/power/pmic/i2c_pmic_emul.c create mode 100644 drivers/power/pmic/sandbox.c
create mode 100644 drivers/power/regulator/sandbox.c create mode 100644 include/power/sandbox_pmic.h

Acked-by Simon Glass <[email protected]>

Tested on sandbox:

Tested-by Simon Glass <[email protected]>

I expected i2c_pmic_emul to get its settings from the device tree too
- is that not possible for some reason?

Regards,
Simon

Hi Przemyslaw,

Quoted 37 lines · Przemyslaw Marczak

This commit adds emulation of sandbox PMIC device, which includes:
- PMIC I2C emulation driver
- PMIC I/O driver (UCLASS_PMIC)
- PMIC regulator driver (UCLASS_REGULATOR)

The sandbox PMIC has 12 significant registers and 4 as padding to 16 bytes, which allows using 'i2c md' command with the default count (16).

The sandbox PMIC provides regulators:
- 2x BUCK
- 2x LDO

Each, with adjustable output:
- Enable state
- Voltage
- Current limit (LDO1/BUCK1 only)
- Operation mode (different for BUCK and LDO)

Each attribute has it's own register, beside the enable state, which depends on operation mode.

The header file: sandbox_pmic.h includes PMIC's default register values, which are set on i2c pmic emul driver's probe() method.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
  doc/device-tree-bindings/pmic/sandbox.txt      |  35 +++
  doc/device-tree-bindings/regulator/sandbox.txt |  45 ++++
  drivers/power/pmic/Kconfig                     |  25 ++
  drivers/power/pmic/Makefile                    |   3 +-
  drivers/power/pmic/i2c_pmic_emul.c             | 145 ++++++++++
  drivers/power/pmic/sandbox.c                   |  79 ++++++
  drivers/power/regulator/Kconfig                |  30 +++
  drivers/power/regulator/Makefile               |   1 +
  drivers/power/regulator/sandbox.c              | 355 +++++++++++++++++++++++++
  include/power/sandbox_pmic.h                   | 189 +++++++++++++
  10 files changed, 906 insertions(+), 1 deletion(-)

Quoted 6 lines

create mode 100644 doc/device-tree-bindings/pmic/sandbox.txt create mode 100644 doc/device-tree-bindings/regulator/sandbox.txt create mode 100644 drivers/power/pmic/i2c_pmic_emul.c create mode 100644 drivers/power/pmic/sandbox.c
create mode 100644 drivers/power/regulator/sandbox.c create mode 100644 include/power/sandbox_pmic.h

Acked-by Simon Glass <[email protected]>

Tested on sandbox:

Tested-by Simon Glass <[email protected]>

I expected i2c_pmic_emul to get its settings from the device tree too
- is that not possible for some reason?

Regards,
Simon

Hello Simon,

Quoted 54 lines · Simon Glass

Hi Przemyslaw,

Quoted 41 lines · Przemyslaw Marczak

This commit adds emulation of sandbox PMIC device, which includes:
- PMIC I2C emulation driver
- PMIC I/O driver (UCLASS_PMIC)
- PMIC regulator driver (UCLASS_REGULATOR)

The sandbox PMIC has 12 significant registers and 4 as padding to 16 bytes,
which allows using 'i2c md' command with the default count (16).

The sandbox PMIC provides regulators:
- 2x BUCK
- 2x LDO

Each, with adjustable output:
- Enable state
- Voltage
- Current limit (LDO1/BUCK1 only)
- Operation mode (different for BUCK and LDO)

Each attribute has it's own register, beside the enable state, which depends
on operation mode.

The header file: sandbox_pmic.h includes PMIC's default register values, which are set on i2c pmic emul driver's probe() method.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
  doc/device-tree-bindings/pmic/sandbox.txt      |  35 +++
  doc/device-tree-bindings/regulator/sandbox.txt |  45 ++++
  drivers/power/pmic/Kconfig                     |  25 ++
  drivers/power/pmic/Makefile                    |   3 +-
  drivers/power/pmic/i2c_pmic_emul.c             | 145 ++++++++++
  drivers/power/pmic/sandbox.c                   |  79 ++++++
  drivers/power/regulator/Kconfig                |  30 +++
  drivers/power/regulator/Makefile               |   1 +
  drivers/power/regulator/sandbox.c              | 355
+++++++++++++++++++++++++
  include/power/sandbox_pmic.h                   | 189 +++++++++++++
  10 files changed, 906 insertions(+), 1 deletion(-)

Quoted 6 lines

create mode 100644 doc/device-tree-bindings/pmic/sandbox.txt create mode 100644 doc/device-tree-bindings/regulator/sandbox.txt create mode 100644 drivers/power/pmic/i2c_pmic_emul.c create mode 100644 drivers/power/pmic/sandbox.c
create mode 100644 drivers/power/regulator/sandbox.c create mode 100644 include/power/sandbox_pmic.h

Acked-by Simon Glass <[email protected]>

Quoted 9 lines

Tested on sandbox:

Tested-by Simon Glass <[email protected]>

I expected i2c_pmic_emul to get its settings from the device tree too
- is that not possible for some reason?

Regards,
Simon

To put the default PMIC register settings into device tree,
I would like add some changes:
- add arch/sandbox/dts/include/dt-bindings/pmic/sandbox_pmic.h - to define "VAL2REG(min, step, val)" macro and operation mode IDs
- add arch/sandbox/dts/sandbox_pmic.dtsi
- include the sandbox_pmic.dtsi in sandbox.dts
- include the sandbox_pmic.dtsi in test.dts

And the last one is a problem, because it's compiled without the U-Boot build system - but by dtc command. I could extend the dtc by arg '-i' - to include the sandbox_pmic.dtsi, but then, still I can't use the preprocessor macro.

I think, that move the "test.dts" into "arch/sandbox/dts" directory is a good idea in this case.

Is that acceptable for you?

Actually I didn't used the script "test-dm.sh" before, since I just compile the U-Boot by my own script with the "dtc" routine.

This commit adds sandbox PMIC subnode to sandbox i2c bus 0.

The PMIC's node includes:
- 2x BUCK
- 2x LDO

Each regulator node include proper constraints:
- min, max micro Volts
- min, max micro Amps (only first of each type)
- always on (BUCK1)
- boot on (LDO1)

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 test/dm/test.dts | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

This commit enables:
- emulated i2c PMIC driver
- sandbox PMIC I/O driver
- sandbox PMIC's regulator driver

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 configs/sandbox_defconfig | 7 +++++++
 1 file changed, 7 insertions(+)

This change adds new file to sandbox driver model test environment. The file is: test/dm/power.c, and it includes tests for PMIC framework, which includes PMIC uclass and REGULATOR uclass.

All tests are based od Sandbox PMIC emulated device. Some test constants for this device are defined in the header: include/power/sandbox_pmic.h

PMIC tests includes:
- pmic get - tests, that pmic_get() returns the requested device
- pmic I/O - tests I/O by writing and reading some values to PMIC's registers and then compares, that the write/read values are equal.

The regulator tests includes:
- Regulator get by devname/platname
- Voltage set/get
- Current set/get
- Enable set/get
- Mode set/get
- Autoset
- List autoset

For the regulator 'get' test, the returned device pointers are compared, and their names are also compared to the requested one. Every other test, first sets the given attribute and next try to get it. The test pass, when the set/get values are equal.

Signed-off-by Przemyslaw Marczak <[email protected]>

---
 include/power/sandbox_pmic.h |  33 ++++
 test/dm/Makefile             |   2 +
 test/dm/power.c              | 371 +++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 406 insertions(+)
 create mode 100644 test/dm/power.c

include/power/sandbox_pmic.h +33 -0

index f9bc10e..01004a0 100644
@@ -186,4 +186,37 @@ enum {
 #define LDO2_UV_REG_DEFAULT    LDO2_UV_TO_REG(OUT_LDO2_UV_DEFAULT)
 #define LDO2_OM_REG_DEFAULT    OUT_OM_SET(OUT_LDO2_OM_DEFAULT)
 
+/* Test data for: test/dm/power.c */
+
+/* BUCK names */
+#define SANDBOX_BUCK1_DEVNAME  "buck1"
+#define SANDBOX_BUCK1_PLATNAME "SUPPLY_1.2V"
+#define SANDBOX_BUCK2_DEVNAME  "buck2"
+#define SANDBOX_BUCK2_PLATNAME "SUPPLY_3.3V"
+/* LDO names */
+#define SANDBOX_LDO1_DEVNAME   "ldo1"
+#define SANDBOX_LDO1_PLATNAME  "VDD_EMMC_1.8V"
+#define SANDBOX_LDO2_DEVNAME   "ldo2"
+#define SANDBOX_LDO2_PLATNAME  "VDD_LCD_3.3V"
+
+/*
+ * Expected regulators setup after call of:
+ * - regulator_autoset()
+ * - regulator_list_autoset()
+ */
+
+/* BUCK1: for testing regulator_autoset() */
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_UV      1200000
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_UA      200000
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_ENABLE  true
+
+/* LDO1/2 for testing regulator_list_autoset() */
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_UV       1800000
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_UA       100000
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_ENABLE   true
+
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_UV       OUT_LDO2_UV_DEFAULT
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_UA       -ENOSYS
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_ENABLE   false
+
 #endif

test/dm/Makefile +2 -0

index fd9e29f..30df53d 100644
@@ -24,4 +24,6 @@ obj-$(CONFIG_DM_PCI) += pci.o
 obj-$(CONFIG_DM_SPI_FLASH) += sf.o
 obj-$(CONFIG_DM_SPI) += spi.o
 obj-$(CONFIG_DM_USB) += usb.o
+obj-$(CONFIG_DM_PMIC) += power.o
+obj-$(CONFIG_DM_REGULATOR) += power.o
 endif

test/dm/power.c new file +17 -0

new file mode 100644
index 0000000..8c607c6
@@ -0,0 +1,371 @@
+/*
+ * Tests for the driver model pmic and regulator code
+ *
+ * Copyright (c) 2015 Samsung Electronics
+ * Przemyslaw Marczak <[email protected]>
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#include <common.h>
+#include <errno.h>
+#include <dm.h>
+#include <fdtdec.h>
+#include <malloc.h>
+#include <dm/device-internal.h>
+#include <dm/root.h>
+#include <dm/ut.h>

test/dm/power.c new file +37 -0

+/* Test PMIC get method */
+static int dm_test_power_pmic_get(struct dm_test_state *dms)
+{
+       const char *name = "sandbox_pmic";
+       struct udevice *dev;
+
+       ut_assertok(pmic_get(name, &dev));
+       ut_assertnonnull(dev);
+
+       /* Check PMIC's name */
+       ut_asserteq_str(name, dev->name);
+
+       return 0;
+}
+DM_TEST(dm_test_power_pmic_get, DM_TESTF_SCAN_FDT);
+
+/* Test PMIC I/O */
+static int dm_test_power_pmic_io(struct dm_test_state *dms)
+{
+       const char *name = "sandbox_pmic";
+       uint8_t out_buffer, in_buffer;
+       struct udevice *dev;
+       int reg_count, i;
+
+       ut_assertok(pmic_get(name, &dev));
+
+       reg_count = pmic_reg_count(dev);
+       ut_asserteq(reg_count, SANDBOX_PMIC_REG_COUNT);
+
+       /*
+        * Test PMIC I/O - write and read a loop counter.
+        * usually we can't write to all PMIC's registers in the real hardware,
+        * but we can to the sandbox pmic.
+        */
+       for (i = 0; i < reg_count; i++) {
+               out_buffer = i;
+               ut_assertok(pmic_write(dev, i, &out_buffer, 1));

test/dm/power.c new file +69 -0

+enum {
+       BUCK1,
+       BUCK2,
+       LDO1,
+       LDO2,
+       OUTPUT_COUNT,
+};
+
+enum {
+       DEVNAME = 0,
+       PLATNAME,
+       OUTPUT_NAME_COUNT,
+};
+
+static const char *regulator_names[OUTPUT_COUNT][OUTPUT_NAME_COUNT] = {
+       /* devname, platname */
+       { SANDBOX_BUCK1_DEVNAME, SANDBOX_BUCK1_PLATNAME },
+       { SANDBOX_BUCK2_DEVNAME, SANDBOX_BUCK2_PLATNAME },
+       { SANDBOX_LDO1_DEVNAME, SANDBOX_LDO1_PLATNAME},
+       { SANDBOX_LDO2_DEVNAME, SANDBOX_LDO2_PLATNAME},
+};
+
+/* Test regulator get method */
+static int dm_test_power_regulator_get(struct dm_test_state *dms)
+{
+       struct dm_regulator_uclass_platdata *uc_pdata;
+       struct udevice *dev_by_devname;
+       struct udevice *dev_by_platname;
+       const char *devname;
+       const char *platname;
+       int i;
+
+       for (i = 0; i < OUTPUT_COUNT; i++) {
+               /*
+                * Do the test for each regulator's devname and platname,
+                * which are related to a single device.
+                */
+               devname = regulator_names[i][DEVNAME];
+               platname = regulator_names[i][PLATNAME];
+
+               /*
+                * Check, that regulator_get_by_devname() function, returns
+                * a device with the name equal to the requested one.
+                */
+               ut_assertok(regulator_get_by_devname(devname, &dev_by_devname));
+               ut_asserteq_str(devname, dev_by_devname->name);
+
+               /*
+                * Check, that regulator_get_by_platname() function, returns
+                * a device with the name equal to the requested one.
+                */
+               ut_assertok(regulator_get_by_platname(platname, &dev_by_platname));
+               ut_assert(uc_pdata = dev_get_uclass_platdata(dev_by_platname));
+               ut_asserteq_str(platname, uc_pdata->name);
+
+               /*
+                * Check, that the pointers returned by both get functions,
+                * points to the same regulator device.
+                */
+               ut_asserteq_ptr(dev_by_devname, dev_by_platname);
+       }
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_get, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Voltage method */
+static int dm_test_power_regulator_set_get_voltage(struct dm_test_state *dms)
+{

test/dm/power.c new file +31 -0

+
+       val_set = uc_pdata->min_uV;
+       ut_assertok(regulator_set_value(dev, val_set));
+
+       val_get = regulator_get_value(dev);
+       ut_assert(val_get >= 0);
+
+       ut_asserteq(val_set, val_get);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_voltage, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Current method */
+static int dm_test_power_regulator_set_get_current(struct dm_test_state *dms)
+{
+       struct dm_regulator_uclass_platdata *uc_pdata;
+       struct udevice *dev;
+       const char *platname;
+       int val_set, val_get;
+
+       /* Set and get the Current of LDO1 - set to 'min' constraint */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+
+       ut_assert(uc_pdata = dev_get_uclass_platdata(dev));
+
+       val_set = uc_pdata->min_uA;
+       ut_assertok(regulator_set_current(dev, val_set));
+
+       val_get = regulator_get_current(dev);

test/dm/power.c new file +57 -0

+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_current, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Enable method */
+static int dm_test_power_regulator_set_get_enable(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev;
+       bool val_set = true;
+
+       /* Set the Enable of LDO1 - default is disabled */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+       ut_assertok(regulator_set_enable(dev, val_set));
+
+       /* Get the Enable state of LDO1 and compare it with the requested one */
+       ut_asserteq(regulator_get_enable(dev), val_set);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_enable, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get mode method */
+static int dm_test_power_regulator_set_get_mode(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev;
+       int val_set = LDO_OM_SLEEP;
+
+       /* Set the mode id to LDO_OM_SLEEP of LDO1 - default is LDO_OM_OFF */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+       ut_assertok(regulator_set_mode(dev, val_set));
+
+       /* Get the mode id of LDO1 and compare it with the requested one */
+       ut_asserteq(regulator_get_mode(dev), val_set);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_mode, DM_TESTF_SCAN_FDT);
+
+/* Test regulator autoset method */
+static int dm_test_power_regulator_autoset(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev, *dev_autoset;
+
+       /*
+        * Test the BUCK1 with fdt properties
+        * - min-microvolt = max-microvolt = 1200000
+        * - min-microamp = max-microamp = 200000
+        * - always-on = set
+        * - boot-on = not set
+        * Expected output state: uV=1200000; uA=200000; output enabled
+        */

test/dm/power.c new file +81 -0

+       ut_asserteq(regulator_get_current(dev),
+                   SANDBOX_BUCK1_AUTOSET_EXPECTED_UA);
+       ut_asserteq(regulator_get_enable(dev),
+                   SANDBOX_BUCK1_AUTOSET_EXPECTED_ENABLE);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_autoset, DM_TESTF_SCAN_FDT);
+
+/*
+ * Struct setting: to keep the expected output settings.
+ * @voltage: Voltage value [uV]
+ * @current: Current value [uA]
+ * @enable: output enable state: true/false
+ */
+struct setting {
+       int voltage;
+       int current;
+       bool enable;
+};
+
+/*
+ * platname_list: an array of regulator platform names.
+ * For testing regulator_list_autoset() for outputs:
+ * - LDO1
+ * - LDO2
+ */
+static const char *platname_list[] = {
+       SANDBOX_LDO1_PLATNAME,
+       SANDBOX_LDO2_PLATNAME,
+       NULL,
+};
+
+/*
+ * expected_setting_list: an array of regulator output setting, expected after
+ * call of the regulator_list_autoset() for the "platname_list" array.
+ * For testing results of regulator_list_autoset() for outputs:
+ * - LDO1
+ * - LDO2
+ * The settings are defined in: include/power/sandbox_pmic.h
+ */
+static const struct setting expected_setting_list[] = {
+       [0] = { /* LDO1 */
+       .voltage = SANDBOX_LDO1_AUTOSET_EXPECTED_UV,
+       .current = SANDBOX_LDO1_AUTOSET_EXPECTED_UA,
+       .enable  = SANDBOX_LDO1_AUTOSET_EXPECTED_ENABLE,
+       },
+       [1] = { /* LDO2 */
+       .voltage = SANDBOX_LDO2_AUTOSET_EXPECTED_UV,
+       .current = SANDBOX_LDO2_AUTOSET_EXPECTED_UA,
+       .enable  = SANDBOX_LDO2_AUTOSET_EXPECTED_ENABLE,
+       },
+};
+
+static int list_count = ARRAY_SIZE(expected_setting_list);
+
+/* Test regulator list autoset method */
+static int dm_test_power_regulator_autoset_list(struct dm_test_state *dms)
+{
+       struct udevice *dev_list[2], *dev;
+       int i;
+
+       /*
+        * Test the settings of the regulator list:
+        * LDO1 with fdt properties:
+        * - min-microvolt = max-microvolt = 1800000
+        * - min-microamp = max-microamp = 100000
+        * - always-on = not set
+        * - boot-on = set
+        * Expected output state: uV=1800000; uA=100000; output enabled
+        *
+        * LDO2 with fdt properties:
+        * - min-microvolt = max-microvolt = 3300000
+        * - always-on = not set
+        * - boot-on = not set
+        * Expected output state: uV=300000(default); output disabled(default)
+        * The expected settings are defined in: include/power/sandbox_pmic.h.
+        */
+       ut_assertok(regulator_list_autoset(platname_list, dev_list, false));
+
+       for (i = 0; i < list_count; i++) {

test/dm/power.c new file +15 -1

+
+               /* Check, that regulator output Current value is as expected */
+               ut_asserteq(regulator_get_current(dev_list[i]),
+                           expected_setting_list[i].current);
+
+               /* Check, that regulator output Enable state is as expected */
+               ut_asserteq(regulator_get_enable(dev_list[i]),
+                           expected_setting_list[i].enable);
+       }
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_autoset_list, DM_TESTF_SCAN_FDT);
+
+#endif /* CONFIG_DM_REGULATOR */
--

1.9.1

Hi Przemyslaw,

Quoted 26 lines · Przemyslaw Marczak

This change adds new file to sandbox driver model test environment. The file is: test/dm/power.c, and it includes tests for PMIC framework, which includes PMIC uclass and REGULATOR uclass.

All tests are based od Sandbox PMIC emulated device. Some test constants for this device are defined in the header: include/power/sandbox_pmic.h

PMIC tests includes:
- pmic get - tests, that pmic_get() returns the requested device
- pmic I/O - tests I/O by writing and reading some values to PMIC's registers and then compares, that the write/read values are equal.

The regulator tests includes:
- Regulator get by devname/platname
- Voltage set/get
- Current set/get
- Enable set/get
- Mode set/get
- Autoset
- List autoset

For the regulator 'get' test, the returned device pointers are compared, and their names are also compared to the requested one. Every other test, first sets the given attribute and next try to get it. The test pass, when the set/get values are equal.

Quoted 7 lines

Signed-off-by Przemyslaw Marczak <[email protected]>

---
  include/power/sandbox_pmic.h |  33 ++++
  test/dm/Makefile             |   2 +
  test/dm/power.c              | 371 +++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 406 insertions(+)

create mode 100644 test/dm/power.c

This looks great. I just have some minor nits below.

Quoted 81 lines

include/power/sandbox_pmic.h +33 -0

index f9bc10e..01004a0 100644
@@ -186,4 +186,37 @@ enum {
  #define LDO2_UV_REG_DEFAULT    LDO2_UV_TO_REG(OUT_LDO2_UV_DEFAULT)
  #define LDO2_OM_REG_DEFAULT    OUT_OM_SET(OUT_LDO2_OM_DEFAULT)
 
+/* Test data for: test/dm/power.c */
+
+/* BUCK names */
+#define SANDBOX_BUCK1_DEVNAME  "buck1"
+#define SANDBOX_BUCK1_PLATNAME "SUPPLY_1.2V"
+#define SANDBOX_BUCK2_DEVNAME  "buck2"
+#define SANDBOX_BUCK2_PLATNAME "SUPPLY_3.3V"
+/* LDO names */
+#define SANDBOX_LDO1_DEVNAME   "ldo1"
+#define SANDBOX_LDO1_PLATNAME  "VDD_EMMC_1.8V"
+#define SANDBOX_LDO2_DEVNAME   "ldo2"
+#define SANDBOX_LDO2_PLATNAME  "VDD_LCD_3.3V"
+
+/*
+ * Expected regulators setup after call of:
+ * - regulator_autoset()
+ * - regulator_list_autoset()
+ */
+
+/* BUCK1: for testing regulator_autoset() */
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_UV      1200000
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_UA      200000
+#define SANDBOX_BUCK1_AUTOSET_EXPECTED_ENABLE  true
+
+/* LDO1/2 for testing regulator_list_autoset() */
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_UV       1800000
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_UA       100000
+#define SANDBOX_LDO1_AUTOSET_EXPECTED_ENABLE   true
+
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_UV       OUT_LDO2_UV_DEFAULT
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_UA       -ENOSYS
+#define SANDBOX_LDO2_AUTOSET_EXPECTED_ENABLE   false
+
  #endif

test/dm/Makefile +2 -0

index fd9e29f..30df53d 100644
@@ -24,4 +24,6 @@ obj-$(CONFIG_DM_PCI) += pci.o
  obj-$(CONFIG_DM_SPI_FLASH) += sf.o
  obj-$(CONFIG_DM_SPI) += spi.o
  obj-$(CONFIG_DM_USB) += usb.o
+obj-$(CONFIG_DM_PMIC) += power.o
+obj-$(CONFIG_DM_REGULATOR) += power.o
  endif

test/dm/power.c new file +21 -0

new file mode 100644
index 0000000..8c607c6
@@ -0,0 +1,371 @@
+/*
+ * Tests for the driver model pmic and regulator code
+ *
+ * Copyright (c) 2015 Samsung Electronics
+ * Przemyslaw Marczak <[email protected]>
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#include <common.h>
+#include <errno.h>
+#include <dm.h>
+#include <fdtdec.h>
+#include <malloc.h>
+#include <dm/device-internal.h>
+#include <dm/root.h>
+#include <dm/ut.h>
+#include <dm/util.h>
+#include <dm/test.h>
+#include <dm/uclass-internal.h>
+#include <power/pmic.h>

test/dm/power.c line 27

Quoted 6 lines

test/dm/power.c new file +6 -0

+#include <power/regulator.h>
+#include <power/sandbox_pmic.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#ifdef CONFIG_DM_PMIC

How about creating pmic.c and then you can move the ifdef to the Makefile?

Quoted 41 lines

test/dm/power.c new file +41 -0

+/* Test PMIC get method */
+static int dm_test_power_pmic_get(struct dm_test_state *dms)
+{
+       const char *name = "sandbox_pmic";
+       struct udevice *dev;
+
+       ut_assertok(pmic_get(name, &dev));
+       ut_assertnonnull(dev);
+
+       /* Check PMIC's name */
+       ut_asserteq_str(name, dev->name);
+
+       return 0;
+}
+DM_TEST(dm_test_power_pmic_get, DM_TESTF_SCAN_FDT);
+
+/* Test PMIC I/O */
+static int dm_test_power_pmic_io(struct dm_test_state *dms)
+{
+       const char *name = "sandbox_pmic";
+       uint8_t out_buffer, in_buffer;
+       struct udevice *dev;
+       int reg_count, i;
+
+       ut_assertok(pmic_get(name, &dev));
+
+       reg_count = pmic_reg_count(dev);
+       ut_asserteq(reg_count, SANDBOX_PMIC_REG_COUNT);
+
+       /*
+        * Test PMIC I/O - write and read a loop counter.
+        * usually we can't write to all PMIC's registers in the real hardware,
+        * but we can to the sandbox pmic.
+        */
+       for (i = 0; i < reg_count; i++) {
+               out_buffer = i;
+               ut_assertok(pmic_write(dev, i, &out_buffer, 1));
+               ut_assertok(pmic_read(dev, i, &in_buffer, 1));
+               ut_asserteq(out_buffer, in_buffer);
+       }
+

test/dm/power.c line 74

Quoted 6 lines

test/dm/power.c new file +6 -0

+       return 0;
+}
+DM_TEST(dm_test_power_pmic_io, DM_TESTF_SCAN_FDT);
+#endif /* CONFIG_DM_PMIC */
+
+#ifdef CONFIG_DM_REGULATOR

This could go in regulator.c

Quoted 69 lines

test/dm/power.c new file +69 -0

+enum {
+       BUCK1,
+       BUCK2,
+       LDO1,
+       LDO2,
+       OUTPUT_COUNT,
+};
+
+enum {
+       DEVNAME = 0,
+       PLATNAME,
+       OUTPUT_NAME_COUNT,
+};
+
+static const char *regulator_names[OUTPUT_COUNT][OUTPUT_NAME_COUNT] = {
+       /* devname, platname */
+       { SANDBOX_BUCK1_DEVNAME, SANDBOX_BUCK1_PLATNAME },
+       { SANDBOX_BUCK2_DEVNAME, SANDBOX_BUCK2_PLATNAME },
+       { SANDBOX_LDO1_DEVNAME, SANDBOX_LDO1_PLATNAME},
+       { SANDBOX_LDO2_DEVNAME, SANDBOX_LDO2_PLATNAME},
+};
+
+/* Test regulator get method */
+static int dm_test_power_regulator_get(struct dm_test_state *dms)
+{
+       struct dm_regulator_uclass_platdata *uc_pdata;
+       struct udevice *dev_by_devname;
+       struct udevice *dev_by_platname;
+       const char *devname;
+       const char *platname;
+       int i;
+
+       for (i = 0; i < OUTPUT_COUNT; i++) {
+               /*
+                * Do the test for each regulator's devname and platname,
+                * which are related to a single device.
+                */
+               devname = regulator_names[i][DEVNAME];
+               platname = regulator_names[i][PLATNAME];
+
+               /*
+                * Check, that regulator_get_by_devname() function, returns
+                * a device with the name equal to the requested one.
+                */
+               ut_assertok(regulator_get_by_devname(devname, &dev_by_devname));
+               ut_asserteq_str(devname, dev_by_devname->name);
+
+               /*
+                * Check, that regulator_get_by_platname() function, returns
+                * a device with the name equal to the requested one.
+                */
+               ut_assertok(regulator_get_by_platname(platname, &dev_by_platname));
+               ut_assert(uc_pdata = dev_get_uclass_platdata(dev_by_platname));
+               ut_asserteq_str(platname, uc_pdata->name);
+
+               /*
+                * Check, that the pointers returned by both get functions,
+                * points to the same regulator device.
+                */
+               ut_asserteq_ptr(dev_by_devname, dev_by_platname);
+       }
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_get, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Voltage method */
+static int dm_test_power_regulator_set_get_voltage(struct dm_test_state *dms)
+{

test/dm/power.c line 153

Quoted 10 lines

test/dm/power.c new file +10 -0

+       struct dm_regulator_uclass_platdata *uc_pdata;
+       struct udevice *dev;
+       const char *platname;
+       int val_set, val_get;
+
+       /* Set and get Voltage of BUCK1 - set to 'min' constraint */
+       platname = regulator_names[BUCK1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+
+       ut_assert(uc_pdata = dev_get_uclass_platdata(dev));

uc_pdata = dev_get_uclass_platdata(dev)
ut_assert(uc_pdata)

and below

Quoted 35 lines

test/dm/power.c new file +35 -0

+
+       val_set = uc_pdata->min_uV;
+       ut_assertok(regulator_set_value(dev, val_set));
+
+       val_get = regulator_get_value(dev);
+       ut_assert(val_get >= 0);
+
+       ut_asserteq(val_set, val_get);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_voltage, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Current method */
+static int dm_test_power_regulator_set_get_current(struct dm_test_state *dms)
+{
+       struct dm_regulator_uclass_platdata *uc_pdata;
+       struct udevice *dev;
+       const char *platname;
+       int val_set, val_get;
+
+       /* Set and get the Current of LDO1 - set to 'min' constraint */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+
+       ut_assert(uc_pdata = dev_get_uclass_platdata(dev));
+
+       val_set = uc_pdata->min_uA;
+       ut_assertok(regulator_set_current(dev, val_set));
+
+       val_get = regulator_get_current(dev);
+       ut_assert(val_get >= 0);
+
+       ut_asserteq(val_set, val_get);
+

test/dm/power.c line 194

Quoted 6 lines

test/dm/power.c new file +6 -0

+       /* Check LDO2 current limit constraints - should be -ENODATA */
+       platname = regulator_names[LDO2][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+
+       ut_assert(uc_pdata = dev_get_uclass_platdata(dev));
+       ut_asserteq(uc_pdata->min_uA, -ENODATA);

Expected value should come first.

test/dm/power.c line 198

Quoted 4 lines

test/dm/power.c new file +4 -0

+       ut_asserteq(uc_pdata->max_uA, -ENODATA);
+
+       /* Try set the Current of LDO2 - should return -ENOSYS */
+       ut_asserteq(regulator_set_current(dev, 0), -ENOSYS);

Nice test

Quoted 57 lines

test/dm/power.c new file +57 -0

+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_current, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get Enable method */
+static int dm_test_power_regulator_set_get_enable(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev;
+       bool val_set = true;
+
+       /* Set the Enable of LDO1 - default is disabled */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+       ut_assertok(regulator_set_enable(dev, val_set));
+
+       /* Get the Enable state of LDO1 and compare it with the requested one */
+       ut_asserteq(regulator_get_enable(dev), val_set);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_enable, DM_TESTF_SCAN_FDT);
+
+/* Test regulator set and get mode method */
+static int dm_test_power_regulator_set_get_mode(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev;
+       int val_set = LDO_OM_SLEEP;
+
+       /* Set the mode id to LDO_OM_SLEEP of LDO1 - default is LDO_OM_OFF */
+       platname = regulator_names[LDO1][PLATNAME];
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+       ut_assertok(regulator_set_mode(dev, val_set));
+
+       /* Get the mode id of LDO1 and compare it with the requested one */
+       ut_asserteq(regulator_get_mode(dev), val_set);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_set_get_mode, DM_TESTF_SCAN_FDT);
+
+/* Test regulator autoset method */
+static int dm_test_power_regulator_autoset(struct dm_test_state *dms)
+{
+       const char *platname;
+       struct udevice *dev, *dev_autoset;
+
+       /*
+        * Test the BUCK1 with fdt properties
+        * - min-microvolt = max-microvolt = 1200000
+        * - min-microamp = max-microamp = 200000
+        * - always-on = set
+        * - boot-on = not set
+        * Expected output state: uV=1200000; uA=200000; output enabled
+        */

test/dm/power.c line 265

Quoted 10 lines

test/dm/power.c new file +10 -0

+       platname = regulator_names[BUCK1][PLATNAME];
+       ut_assertok(regulator_autoset(platname, &dev_autoset, false));
+
+       /* Check, that the returned device is proper */
+       ut_assertok(regulator_get_by_platname(platname, &dev));
+       ut_asserteq_ptr(dev, dev_autoset);
+
+       /* Check the setup after autoset */
+       ut_asserteq(regulator_get_value(dev),
+                   SANDBOX_BUCK1_AUTOSET_EXPECTED_UV);

Expected value should come first.

Quoted 85 lines

test/dm/power.c new file +85 -0

+       ut_asserteq(regulator_get_current(dev),
+                   SANDBOX_BUCK1_AUTOSET_EXPECTED_UA);
+       ut_asserteq(regulator_get_enable(dev),
+                   SANDBOX_BUCK1_AUTOSET_EXPECTED_ENABLE);
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_autoset, DM_TESTF_SCAN_FDT);
+
+/*
+ * Struct setting: to keep the expected output settings.
+ * @voltage: Voltage value [uV]
+ * @current: Current value [uA]
+ * @enable: output enable state: true/false
+ */
+struct setting {
+       int voltage;
+       int current;
+       bool enable;
+};
+
+/*
+ * platname_list: an array of regulator platform names.
+ * For testing regulator_list_autoset() for outputs:
+ * - LDO1
+ * - LDO2
+ */
+static const char *platname_list[] = {
+       SANDBOX_LDO1_PLATNAME,
+       SANDBOX_LDO2_PLATNAME,
+       NULL,
+};
+
+/*
+ * expected_setting_list: an array of regulator output setting, expected after
+ * call of the regulator_list_autoset() for the "platname_list" array.
+ * For testing results of regulator_list_autoset() for outputs:
+ * - LDO1
+ * - LDO2
+ * The settings are defined in: include/power/sandbox_pmic.h
+ */
+static const struct setting expected_setting_list[] = {
+       [0] = { /* LDO1 */
+       .voltage = SANDBOX_LDO1_AUTOSET_EXPECTED_UV,
+       .current = SANDBOX_LDO1_AUTOSET_EXPECTED_UA,
+       .enable  = SANDBOX_LDO1_AUTOSET_EXPECTED_ENABLE,
+       },
+       [1] = { /* LDO2 */
+       .voltage = SANDBOX_LDO2_AUTOSET_EXPECTED_UV,
+       .current = SANDBOX_LDO2_AUTOSET_EXPECTED_UA,
+       .enable  = SANDBOX_LDO2_AUTOSET_EXPECTED_ENABLE,
+       },
+};
+
+static int list_count = ARRAY_SIZE(expected_setting_list);
+
+/* Test regulator list autoset method */
+static int dm_test_power_regulator_autoset_list(struct dm_test_state *dms)
+{
+       struct udevice *dev_list[2], *dev;
+       int i;
+
+       /*
+        * Test the settings of the regulator list:
+        * LDO1 with fdt properties:
+        * - min-microvolt = max-microvolt = 1800000
+        * - min-microamp = max-microamp = 100000
+        * - always-on = not set
+        * - boot-on = set
+        * Expected output state: uV=1800000; uA=100000; output enabled
+        *
+        * LDO2 with fdt properties:
+        * - min-microvolt = max-microvolt = 3300000
+        * - always-on = not set
+        * - boot-on = not set
+        * Expected output state: uV=300000(default); output disabled(default)
+        * The expected settings are defined in: include/power/sandbox_pmic.h.
+        */
+       ut_assertok(regulator_list_autoset(platname_list, dev_list, false));
+
+       for (i = 0; i < list_count; i++) {
+               /* Check, that the returned device is non-NULL */
+               ut_assert(dev_list[i]);
+
+               /* Check, that the returned device is proper */

test/dm/power.c line 356

Quoted 6 lines

test/dm/power.c new file +6 -0

+               ut_assertok(regulator_get_by_platname(platname_list[i], &dev));
+               ut_asserteq_ptr(dev_list[i], dev);
+
+               /* Check, that regulator output Voltage value is as expected */
+               ut_asserteq(regulator_get_value(dev_list[i]),
+                           expected_setting_list[i].voltage);

Expected value should come first.

Quoted 13 lines

test/dm/power.c new file +13 -0

+
+               /* Check, that regulator output Current value is as expected */
+               ut_asserteq(regulator_get_current(dev_list[i]),
+                           expected_setting_list[i].current);
+
+               /* Check, that regulator output Enable state is as expected */
+               ut_asserteq(regulator_get_enable(dev_list[i]),
+                           expected_setting_list[i].enable);
+       }
+
+       return 0;
+}
+DM_TEST(dm_test_power_regulator_autoset_list, DM_TESTF_SCAN_FDT);

Quoted 5 lines

test/dm/power.c new file +2 -1

+
+#endif /* CONFIG_DM_REGULATOR */
--

1.9.1

Regards,
Simon

Hello!
This patchset cleanups the POWER framework V4, which is applied into u-boot-dm/next tree.

The main changes:
- pmic/regulator uclasses cleanup - each commit message describes the changes in details.
- added sandbox PMIC emulated device support, which consists of three
drivers: pmic I2C emul, pmic I/O and regulator.
- PMIC/REGULATOR tests for sandbox in: tests/dm/power.c

I tried to add the implementation of all pmic/regulator operations for the sandbox PMIC device - I hope that the drivers are not too complicated.

The tests for sandbox includes every pmic/regulator function call, so for now the tests should well cover the framework features.

The patchset is rebased on the top of u-boot-dm/next, and can be fetched from
here: https://github.com/bobenstein/u-boot.git
branch: dm-pmic-v4-sandbox

Best regards,
Przemyslaw Marczak

Przemyslaw Marczak (12):
dm: pmic: code cleanup of PMIC uclass driver
dm: pmic: max77686: update driver code
dm: regulator: uclass driver code cleanup
odroid u3: cleanup the regulator calls
common: cmd pmic: command cleanup
common: cmd regulator: command cleanup
doc: driver-model: pmic-framework.txt - cleanup
sandbox: i2c: search child emul dev and check its uclass id
sandbox: add: sandbox PMIC device drivers: I2C emul, pmic, regulator
test: dm: dts: add sandbox pmic i2c node
sandbox: defconfig: enable support of sandbox PMIC drivers
test: dm: add sandbox PMIC framework tests

 board/samsung/odroid/odroid.c                  |   9 +-
 common/cmd_pmic.c                              | 131 ++++-----
 common/cmd_regulator.c                         | 239 ++++++++--------
 configs/sandbox_defconfig                      |   7 +
 doc/device-tree-bindings/pmic/sandbox.txt      |  35 +++
 doc/device-tree-bindings/regulator/sandbox.txt |  45 +++
 doc/driver-model/pmic-framework.txt            |  20 +-
 drivers/i2c/sandbox_i2c.c                      |  20 +-
 drivers/power/pmic/Kconfig                     |  27 +-
 drivers/power/pmic/Makefile                    |   3 +-
 drivers/power/pmic/i2c_pmic_emul.c             | 145 ++++++++++
 drivers/power/pmic/max77686.c                  |  15 +-
 drivers/power/pmic/pmic-uclass.c               |  25 +-
 drivers/power/pmic/sandbox.c                   |  79 ++++++
 drivers/power/regulator/Kconfig                |  32 ++-
 drivers/power/regulator/Makefile               |   1 +
 drivers/power/regulator/regulator-uclass.c     | 104 ++++---
 drivers/power/regulator/sandbox.c              | 355 +++++++++++++++++++++++
 include/power/pmic.h                           |  39 +--
 include/power/regulator.h                      | 116 ++++----
 include/power/sandbox_pmic.h                   | 222 +++++++++++++++
 test/dm/Makefile                               |   2 +
 test/dm/power.c                                | 371 +++++++++++++++++++++++++
 test/dm/test.dts                               |  38 +++
 24 files changed, 1732 insertions(+), 348 deletions(-)
 create mode 100644 doc/device-tree-bindings/pmic/sandbox.txt
 create mode 100644 doc/device-tree-bindings/regulator/sandbox.txt
 create mode 100644 drivers/power/pmic/i2c_pmic_emul.c
 create mode 100644 drivers/power/pmic/sandbox.c
 create mode 100644 drivers/power/regulator/sandbox.c
 create mode 100644 include/power/sandbox_pmic.h
 create mode 100644 test/dm/power.c

--
1.9.1

Hi Przemyslaw,

Quoted 17 lines · Przemyslaw Marczak

Hello!
This patchset cleanups the POWER framework V4, which is applied into u-boot-dm/next tree.

The main changes:
- pmic/regulator uclasses cleanup - each commit message describes the changes in details.
- added sandbox PMIC emulated device support, which consists of three
drivers: pmic I2C emul, pmic I/O and regulator.
- PMIC/REGULATOR tests for sandbox in: tests/dm/power.c

I tried to add the implementation of all pmic/regulator operations for the sandbox PMIC device - I hope that the drivers are not too complicated.

The tests for sandbox includes every pmic/regulator function call, so for now the tests should well cover the framework features.

Quoted 6 lines

The patchset is rebased on the top of u-boot-dm/next, and can be fetched from
here: https://github.com/bobenstein/u-boot.git
branch: dm-pmic-v4-sandbox

Best regards,
Przemyslaw Marczak

This looks great, thank you. I pushed the current state to u-boot-dm/working.

I have a small bisectability problem though:

buildman -b dm-next samsung -se
boards.cfg is up to date. Nothing to do.
Summary of 29 commits for 16 boards (16 threads, 2 jobs per thread) 01: dm: sf: Update default name of spi flash in structure udevice 02: exynos5: fix build break by adding CONFIG_POWER
03: exynos4-common: remove the unsued CONFIG_CMD_PMIC
04: lib: Kconfig: add entry for errno_str() function
05: dm: pmic: add implementation of driver model pmic uclass 06: dm: regulator: add implementation of driver model regulator uclass 07: dm: pmic: add pmic command
08: dm: regulator: add regulator command
09: pmic: max77686 set the same compatible as in the kernel 10: dm: pmic: add max77686 pmic driver
11: dm: regulator: add max77686 regulator driver
12: dm: regulator: add fixed voltage regulator driver
13: doc: driver-model: pmic and regulator uclass documentation 14: dm: board:samsung: power_init_board: add requirement of CONFIG_DM_PMIC 15: odroid: board: add support to dm pmic api
arm: + odroid

(quoted diff) +2 -0

+board/samsung/odroid/built-in.o: In function `s5pc210_phy_control':
+build/../board/samsung/odroid/odroid.c:444: undefined reference to

regulator_by_platname' +build/../board/samsung/odroid/odroid.c:453: undefined reference to regulator_set_mode'

(quoted diff) +2 -0

+board/samsung/odroid/built-in.o: In function `exynos_power_init':
+build/../board/samsung/odroid/odroid.c:432: undefined reference to

`regulator_by_platname_list_autoset_and_enable'

(quoted diff) +2 -0

+board/samsung/odroid/built-in.o: In function `board_usb_init':
+build/../board/samsung/odroid/odroid.c:490: undefined reference to

`regulator_by_platname'
+build/../board/samsung/odroid/odroid.c:496: undefined reference to
`regulator_set_enable'
+build/../board/samsung/odroid/odroid.c:502: undefined reference to
`regulator_set_value'
+build/../board/samsung/odroid/odroid.c:508: undefined reference to
`regulator_set_value'
+arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG
linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 2.23.1
assertion fail /cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677 +arm-linux-gnueabihf-ld.bfd: error: required section '.rel.plt' not
found in the linker script

(quoted diff) +3 -0

+arm-linux-gnueabihf-ld.bfd: final link failed: Invalid operation
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2

16: odroid: dts: add 'voltage-regulators' description to max77686 node 17: odroid: config: enable dm pmic, dm regulator and max77686 driver
arm: odroid

(quoted diff) +0 -2

-board/samsung/odroid/built-in.o: In function `s5pc210_phy_control':
-build/../board/samsung/odroid/odroid.c:444: undefined reference to

regulator_by_platname' -build/../board/samsung/odroid/odroid.c:453: undefined reference to regulator_set_mode'

(quoted diff) +0 -2

-board/samsung/odroid/built-in.o: In function `exynos_power_init':
-build/../board/samsung/odroid/odroid.c:432: undefined reference to

`regulator_by_platname_list_autoset_and_enable'

(quoted diff) +0 -2

-board/samsung/odroid/built-in.o: In function `board_usb_init':
-build/../board/samsung/odroid/odroid.c:490: undefined reference to

`regulator_by_platname'
-build/../board/samsung/odroid/odroid.c:496: undefined reference to
`regulator_set_enable'
-build/../board/samsung/odroid/odroid.c:502: undefined reference to
`regulator_set_value'
-build/../board/samsung/odroid/odroid.c:508: undefined reference to
`regulator_set_value'
-arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG
linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 2.23.1
assertion fail /cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677 -arm-linux-gnueabihf-ld.bfd: error: required section '.rel.plt' not
found in the linker script

(quoted diff) +0 -3

-arm-linux-gnueabihf-ld.bfd: final link failed: Invalid operation
-make[1]: *** [u-boot] Error 1
-make: *** [sub-make] Error 2

18: dm: pmic: code cleanup of PMIC uclass driver
arm: + odroid
+../drivers/power/pmic/max77686.c: At top level:

(quoted diff) +2 -0

+drivers/power/pmic/built-in.o: In function `max77686_bind':
+build/../drivers/power/pmic/max77686.c:62: undefined reference to

`pmic_bind_childs'
+arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG
linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 2.23.1
assertion fail /cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677 +arm-linux-gnueabihf-ld.bfd: error: required section '.rel.plt' not
found in the linker script

(quoted diff) +3 -0

+arm-linux-gnueabihf-ld.bfd: final link failed: Invalid operation
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2

w+../drivers/power/pmic/max77686.c: In function ?max77686_bind?:
w+../drivers/power/pmic/max77686.c:62:2: warning: implicit declaration of function ?pmic_bind_childs? [-Wimplicit-function-declaration] w+../drivers/power/pmic/max77686.c:71:2: warning: initialization makes pointer from integer without a cast [enabled by default] w+../drivers/power/pmic/max77686.c:71:2: warning: (near initialization for ?max77686_ops.reg_count?) [enabled by default]
19: dm: pmic: max77686: update driver code
arm: odroid
-../drivers/power/pmic/max77686.c: At top level:

(quoted diff) +0 -2

-drivers/power/pmic/built-in.o: In function `max77686_bind':
-build/../drivers/power/pmic/max77686.c:62: undefined reference to

`pmic_bind_childs'
-arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG
linaro-1.13.1-4.7-2013.04-20130415 - Linaro GCC 2013.04) 2.23.1
assertion fail /cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677 -arm-linux-gnueabihf-ld.bfd: error: required section '.rel.plt' not
found in the linker script

(quoted diff) +0 -3

-arm-linux-gnueabihf-ld.bfd: final link failed: Invalid operation
-make[1]: *** [u-boot] Error 1
-make: *** [sub-make] Error 2

w-../drivers/power/pmic/max77686.c: In function ?max77686_bind?:
w-../drivers/power/pmic/max77686.c:62:2: warning: implicit declaration of function ?pmic_bind_childs? [-Wimplicit-function-declaration] w-../drivers/power/pmic/max77686.c:71:2: warning: initialization makes pointer from integer without a cast [enabled by default] w-../drivers/power/pmic/max77686.c:71:2: warning: (near initialization for ?max77686_ops.reg_count?) [enabled by default]
20: dm: regulator: uclass driver code cleanup
arm: + odroid
+In file included from ../board/samsung/odroid/odroid.c:17:0:
+../include/power/regulator.h:356:5: note: expected ?struct udevice **? but argument is of type ?int? +../board/samsung/odroid/odroid.c:432:2: error: too many arguments to function ?regulator_list_autoset? +../include/power/regulator.h:356:5: note: declared here

(quoted diff) +3 -0

+make[2]: *** [board/samsung/odroid/odroid.o] Error 1
+make[1]: *** [board/samsung/odroid] Error 2
+make: *** [sub-make] Error 2

w+../board/samsung/odroid/odroid.c: In function ?exynos_power_init?:
w+../board/samsung/odroid/odroid.c:432:2: warning: passing argument 2 of ?regulator_list_autoset? makes pointer from integer without a cast [enabled by default]
w+../board/samsung/odroid/odroid.c: In function ?s5pc210_phy_control?:
w+../board/samsung/odroid/odroid.c:444:2: warning: implicit declaration of function ?regulator_by_platname? [-Wimplicit-function-declaration]
21: odroid u3: cleanup the regulator calls
arm: odroid
-In file included from ../board/samsung/odroid/odroid.c:17:0:
-../include/power/regulator.h:356:5: note: expected ?struct udevice **? but argument is of type ?int? -../board/samsung/odroid/odroid.c:432:2: error: too many arguments to function ?regulator_list_autoset? -../include/power/regulator.h:356:5: note: declared here

(quoted diff) +0 -3

-make[2]: *** [board/samsung/odroid/odroid.o] Error 1
-make[1]: *** [board/samsung/odroid] Error 2
-make: *** [sub-make] Error 2

w-../board/samsung/odroid/odroid.c: In function ?exynos_power_init?:
w-../board/samsung/odroid/odroid.c:432:2: warning: passing argument 2 of ?regulator_list_autoset? makes pointer from integer without a cast [enabled by default]
w-../board/samsung/odroid/odroid.c: In function ?s5pc210_phy_control?:
w-../board/samsung/odroid/odroid.c:444:2: warning: implicit declaration of function ?regulator_by_platname? [-Wimplicit-function-declaration]
22: common: cmd pmic: command cleanup
23: common: cmd regulator: command cleanup
24: doc: driver-model: pmic-framework.txt - cleanup
25: sandbox: i2c: search child emul dev and check its uclass id 26: sandbox: add: sandbox PMIC device drivers: I2C emul, pmic, regulator 27: test: dm: dts: add sandbox pmic i2c node
28: sandbox: defconfig: enable support of sandbox PMIC drivers 29: test: dm: add sandbox PMIC framework tests