Skip to contentSkip to conversation

ARM: mvebu: add "nor-jedec" flash compatible binding

PATCH New Rafał Miłecki 2 participants 4 messages May 8, 2015 – May 12, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mvebu: add "nor-jedec" flash compatible binding

Starting with commits
8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding") 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection") we have "nor-jedec" binding indicating support for JEDEC identification.

---
 arch/arm/boot/dts/armada-370-db.dts              | 2 +-
 arch/arm/boot/dts/armada-370-synology-ds213j.dts | 2 +-
 arch/arm/boot/dts/armada-375-db.dts              | 2 +-
 arch/arm/boot/dts/armada-385-db-ap.dts           | 2 +-
 arch/arm/boot/dts/armada-388-db.dts              | 2 +-
 arch/arm/boot/dts/armada-388-gp.dts              | 2 +-
 arch/arm/boot/dts/armada-388-rd.dts              | 2 +-
 arch/arm/boot/dts/armada-398-db.dts              | 2 +-
 arch/arm/boot/dts/armada-xp-axpwifiap.dts        | 2 +-
 arch/arm/boot/dts/armada-xp-db.dts               | 2 +-
 arch/arm/boot/dts/armada-xp-gp.dts               | 2 +-
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts    | 2 +-
 arch/arm/boot/dts/armada-xp-synology-ds414.dts   | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
arch/arm/boot/dts/armada-370-db.dts +1 -1
index 19f3bf2..972bfc9 100644
@@ -162,7 +162,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "mx25l25635e";
+					compatible = "mx25l25635e", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <50000000>;
 				};
arch/arm/boot/dts/armada-370-synology-ds213j.dts +1 -1
index b42b767..2d6c2d4 100644
@@ -92,7 +92,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "micron,n25q064";
+					compatible = "micron,n25q064", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 
arch/arm/boot/dts/armada-375-db.dts +1 -1
index 4eabc9c..db52cdb 100644
@@ -81,7 +81,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-385-db-ap.dts +1 -1
index 7219ac3..0f9d063 100644
@@ -70,7 +70,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <54000000>;
 				};
arch/arm/boot/dts/armada-388-db.dts +1 -1
index 51d1623..3b5b8b5 100644
@@ -73,7 +73,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "w25q32";
+					compatible = "w25q32", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-388-gp.dts +1 -1
index 78514ab..df700e6 100644
@@ -69,7 +69,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <50000000>;
 					m25p,fast-read;
arch/arm/boot/dts/armada-388-rd.dts +1 -1
index 1dc6e23..388fd1d 100644
@@ -74,7 +74,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-398-db.dts +1 -1
index bbf8375..ec5ce94 100644
@@ -73,7 +73,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <0>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>;
 					spi-max-frequency = <108000000>;
 
arch/arm/boot/dts/armada-xp-axpwifiap.dts +1 -1
index dfd782b..1cbd1e5 100644
@@ -140,7 +140,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-xp-db.dts +1 -1
index 1037824..a9fd0ef 100644
@@ -222,7 +222,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "m25p64";
+					compatible = "m25p64", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 				};
arch/arm/boot/dts/armada-xp-gp.dts +1 -1
index 565227e..1deec67 100644
@@ -227,7 +227,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-xp-linksys-mamba.dts +1 -1
index a2cf215..e9a746b 100644
@@ -279,7 +279,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "everspin,mr25h256";
+					compatible = "everspin,mr25h256", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <40000000>;
 				};
arch/arm/boot/dts/armada-xp-synology-ds414.dts +1 -1
index 6063428..46830e2 100644
@@ -114,7 +114,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "micron,n25q064";
+					compatible = "micron,n25q064", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 
Signature · 1 line
1.8.4.5
#1 lore raw

PATCH 1/1 ARM: mvebu: add "nor-jedec" flash compatible binding

Hi Rafa?,

Quoted 4 lines · Rafa? Mi?ecki

Starting with commits
8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding") 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection") we have "nor-jedec" binding indicating support for JEDEC identification.

did you actually check that all the NOR flash referenced in the dts supports the JEDEC identification?

If it is the case I will add it in mvebu/dt soon.

Thanks,

Gregory

Quoted 188 lines
---
 arch/arm/boot/dts/armada-370-db.dts              | 2 +-
 arch/arm/boot/dts/armada-370-synology-ds213j.dts | 2 +-
 arch/arm/boot/dts/armada-375-db.dts              | 2 +-
 arch/arm/boot/dts/armada-385-db-ap.dts           | 2 +-
 arch/arm/boot/dts/armada-388-db.dts              | 2 +-
 arch/arm/boot/dts/armada-388-gp.dts              | 2 +-
 arch/arm/boot/dts/armada-388-rd.dts              | 2 +-
 arch/arm/boot/dts/armada-398-db.dts              | 2 +-
 arch/arm/boot/dts/armada-xp-axpwifiap.dts        | 2 +-
 arch/arm/boot/dts/armada-xp-db.dts               | 2 +-
 arch/arm/boot/dts/armada-xp-gp.dts               | 2 +-
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts    | 2 +-
 arch/arm/boot/dts/armada-xp-synology-ds414.dts   | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)
arch/arm/boot/dts/armada-370-db.dts +1 -1
index 19f3bf2..972bfc9 100644
@@ -162,7 +162,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "mx25l25635e";
+					compatible = "mx25l25635e", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <50000000>;
 				};
arch/arm/boot/dts/armada-370-synology-ds213j.dts +1 -1
index b42b767..2d6c2d4 100644
@@ -92,7 +92,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "micron,n25q064";
+					compatible = "micron,n25q064", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 
arch/arm/boot/dts/armada-375-db.dts +1 -1
index 4eabc9c..db52cdb 100644
@@ -81,7 +81,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-385-db-ap.dts +1 -1
index 7219ac3..0f9d063 100644
@@ -70,7 +70,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <54000000>;
 				};
arch/arm/boot/dts/armada-388-db.dts +1 -1
index 51d1623..3b5b8b5 100644
@@ -73,7 +73,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "w25q32";
+					compatible = "w25q32", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-388-gp.dts +1 -1
index 78514ab..df700e6 100644
@@ -69,7 +69,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <50000000>;
 					m25p,fast-read;
arch/arm/boot/dts/armada-388-rd.dts +1 -1
index 1dc6e23..388fd1d 100644
@@ -74,7 +74,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "st,m25p128";
+					compatible = "st,m25p128", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-398-db.dts +1 -1
index bbf8375..ec5ce94 100644
@@ -73,7 +73,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <0>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>;
 					spi-max-frequency = <108000000>;
 
arch/arm/boot/dts/armada-xp-axpwifiap.dts +1 -1
index dfd782b..1cbd1e5 100644
@@ -140,7 +140,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-xp-db.dts +1 -1
index 1037824..a9fd0ef 100644
@@ -222,7 +222,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "m25p64";
+					compatible = "m25p64", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 				};
arch/arm/boot/dts/armada-xp-gp.dts +1 -1
index 565227e..1deec67 100644
@@ -227,7 +227,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "n25q128a13";
+					compatible = "n25q128a13", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <108000000>;
 				};
arch/arm/boot/dts/armada-xp-linksys-mamba.dts +1 -1
index a2cf215..e9a746b 100644
@@ -279,7 +279,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "everspin,mr25h256";
+					compatible = "everspin,mr25h256", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <40000000>;
 				};
arch/arm/boot/dts/armada-xp-synology-ds414.dts +1 -1
index 6063428..46830e2 100644
@@ -114,7 +114,7 @@
 				spi-flash at 0 {
 					#address-cells = <1>;
 					#size-cells = <1>;
-					compatible = "micron,n25q064";
+					compatible = "micron,n25q064", "nor-jedec";
 					reg = <0>; /* Chip select 0 */
 					spi-max-frequency = <20000000>;
 
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 ARM: mvebu: add "nor-jedec" flash compatible binding

Quoted 8 lines · Gregory CLEMENT
Quoted 4 lines · Rafa? Mi?ecki

Starting with commits
8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding") 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection") we have "nor-jedec" binding indicating support for JEDEC identification.

did you actually check that all the NOR flash referenced in the dts supports the JEDEC identification?

Yes, I did, yes, they do.

Quoted 1 line

If it is the case I will add it in mvebu/dt soon.

Please drop this patch as there is a discussion (in tegra patch) about renaming the binding to "jedec,spi-nor".

#3 lore raw

PATCH 1/1 ARM: mvebu: add "nor-jedec" flash compatible binding

Quoted 8 lines · Rafa? Mi?ecki
Quoted 6 lines · Gregory CLEMENT
Quoted 4 lines · Rafa? Mi?ecki

Starting with commits
8ff16cf ("Documentation: devicetree: m25p80: add "nor-jedec" binding") 1103b85 ("mtd: m25p80: bind to "nor-jedec" ID, for auto-detection") we have "nor-jedec" binding indicating support for JEDEC identification.

Quoted 4 lines
Quoted 2 lines

did you actually check that all the NOR flash referenced in the dts supports the JEDEC identification?

Yes, I did, yes, they do.

Oh wait, I just realized I also modified "mr25h256" about which one I'm not sure. I'll drop this one in the V2 unless I find a proper documentation meanwhile.

Signature · 1 line
Rafa?