Skip to contentSkip to conversation

mx6cuboxi: Skip usb initialization when booting without HDMI

PATCH New Fabio Estevam 4 participants 4 messages May 4, 2015 – May 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mx6cuboxi: Skip usb initialization when booting without HDMI

Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.

However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.

---
Changes since v1:
- Improve commit log (avoid repeating the word 'use').

 include/configs/mx6cuboxi.h | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
include/configs/mx6cuboxi.h +12 -4
index 4e07f59..b6f9d4e 100644
@@ -80,6 +80,7 @@
 #define CONFIG_VIDEO_LOGO
 #define CONFIG_VIDEO_BMP_LOGO
 #define CONFIG_IMX_HDMI
+#define CONFIG_CMD_HDMIDETECT
 #define CONFIG_IMX_VIDEO_SKIP
 #define CONFIG_CONSOLE_MUX
 
@@ -94,7 +95,17 @@
 #define CONFIG_USB_MAX_CONTROLLER_COUNT	2
 #define CONFIG_USB_KEYBOARD
 #define CONFIG_SYS_USB_EVENT_POLL
-#define CONFIG_PREBOOT			"usb start"
+#define CONFIG_PREBOOT \
+	"if hdmidet; then " \
+		"usb start; "		       \
+		"setenv stdin  serial,usbkbd; "\
+		"setenv stdout serial,vga; "   \
+		"setenv stderr serial,vga; "   \
+	"else " \
+		"setenv stdin  serial; " \
+		"setenv stdout serial; " \
+		"setenv stderr serial; " \
+	"fi;"
 
 #define CONFIG_SYS_NO_FLASH
 
@@ -117,9 +128,6 @@
 
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"stdin=serial,usbkbd\0" \
-	"stdout=serial,vga\0" \
-	"stderr=serial,vga\0" \
 	"script=boot.scr\0" \
 	"image=zImage\0" \
 	"fdtfile=undefined\0" \
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 mx6cuboxi: Skip usb initialization when booting without HDMI

Quoted 58 lines · Fabio Estevam

Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.

However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.

---
Changes since v1:
- Improve commit log (avoid repeating the word 'use').

 include/configs/mx6cuboxi.h | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)
include/configs/mx6cuboxi.h +12 -4
index 4e07f59..b6f9d4e 100644
@@ -80,6 +80,7 @@
 #define CONFIG_VIDEO_LOGO
 #define CONFIG_VIDEO_BMP_LOGO
 #define CONFIG_IMX_HDMI
+#define CONFIG_CMD_HDMIDETECT
 #define CONFIG_IMX_VIDEO_SKIP
 #define CONFIG_CONSOLE_MUX
 
@@ -94,7 +95,17 @@
 #define CONFIG_USB_MAX_CONTROLLER_COUNT	2
 #define CONFIG_USB_KEYBOARD
 #define CONFIG_SYS_USB_EVENT_POLL
-#define CONFIG_PREBOOT			"usb start"
+#define CONFIG_PREBOOT \
+	"if hdmidet; then " \
+		"usb start; "		       \
+		"setenv stdin  serial,usbkbd; "\
+		"setenv stdout serial,vga; "   \
+		"setenv stderr serial,vga; "   \
+	"else " \
+		"setenv stdin  serial; " \
+		"setenv stdout serial; " \
+		"setenv stderr serial; " \
+	"fi;"
 
 #define CONFIG_SYS_NO_FLASH
 
@@ -117,9 +128,6 @@
 
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
 #define CONFIG_EXTRA_ENV_SETTINGS \
-	"stdin=serial,usbkbd\0" \
-	"stdout=serial,vga\0" \
-	"stderr=serial,vga\0" \
 	"script=boot.scr\0" \
 	"image=zImage\0" \
 	"fdtfile=undefined\0" \
Signature · 1 line
1.9.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150504/df7a6998/attachment.sig>

#2 lore raw

PATCH v2 1/1 mx6cuboxi: Skip usb initialization when booting without HDMI

Hi Stefano,

Quoted 11 lines · Vagrant Cascadian
Quoted 8 lines · Fabio Estevam

Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.

However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.

Could this one be applied?

Thanks,

Fabio Estevam

#3 lore raw

PATCH v2 1/1 mx6cuboxi: Skip usb initialization when booting without HDMI

Hi Fabio,

Quoted 10 lines · Fabio Estevam

Hi Stefano,

Quoted 7 lines · Vagrant Cascadian
Quoted 6 lines · Fabio Estevam

Starting USB initialization is useful for those who use Cuboxi/Hummingboard with HDMI and USB keyboard.

However, when booting without a HDMI connection we can skip the usb initialization, which makes the boot faster.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Could this one be applied?

Yes !

Applied to u-boot-imx.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================