Skip to contentSkip to conversation

"drm: Add reference counting to blob properties" breaks Tegra124 Jetson TK1 in linux-next

DISCUSSION Paul Walmsley 5 participants 5 messages May 12, 2015 1 message not in the archive Tegra architecture support

lore
Share & tools
lore

Paul Walmsley

author Reviewed-by Maarten Lankhorst
#0 lore raw

Hi folks

Tegra124 Jetson TK1 hangs during boot in next-20150508 and beyond:

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150508/20150508101018/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150511/20150511004533/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Reverting commit 672cb1d6aec7da2799afd1b529d5136d84ed2561 ("drm: Add reference counting to blob properties") gets it booting again:

http://nvt.pwsan.com/pub/pwalmsley-tester/testlogs/test_20150511204703_3838232431c2636ff539f2354c630c0ca3d4b7ad/20150511204703/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

I'm not a DRM expert but maybe one of you knows what's going on here?

- Paul

commit 672cb1d6aec7da2799afd1b529d5136d84ed2561

Author: Daniel Stone <daniels-ZGY8ohtN/[email protected]>
Date:   Mon Apr 20 19:22:55 2015 +0100

drm: Add reference counting to blob properties

Reference-count drm_property_blob objects, changing the API to ref/unref.

Signed-off-by Daniel Stone <daniels-ZGY8ohtN/[email protected]>
Reviewed-by Maarten Lankhorst <maarten.lankhorst-VuQAYsv1563Yd54FQh9/[email protected]>
Signed-off-by Daniel Vetter <daniel.vetter-/[email protected]>

--
nvpublic

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Paul,

Quoted 8 lines · Paul Walmsley

Hi folks

Tegra124 Jetson TK1 hangs during boot in next-20150508 and beyond:

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150508/20150508101018/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150511/20150511004533/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Weirdly enough, it seems to work in kernelci:
http://kernelci.org/boot/tegra124-jetson-tk1_rootfs:nfs/job/next/kernel/next-20150511/defconfig/tegra_defconfig/lab/lab-khilman/?_id=5550ef6259b5147b64e060b4

Though maybe it's just good fortune that Kevin doesn't have a display plugged into his TK1.

Quoted 5 lines

Reverting commit 672cb1d6aec7da2799afd1b529d5136d84ed2561 ("drm: Add reference counting to blob properties") gets it booting again:

http://nvt.pwsan.com/pub/pwalmsley-tester/testlogs/test_20150511204703_3838232431c2636ff539f2354c630c0ca3d4b7ad/20150511204703/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

I'm not a DRM expert but maybe one of you knows what's going on here?

Thanks for the catch. I have a Nyan-Big Chromebook here, so will try to work it out locally and let you know.

Sorry for the inconvenience!

Cheers,
Daniel

#3 lore raw
In reply to a message not in the archive
Quoted 7 lines · Paul Walmsley

Hi folks

Tegra124 Jetson TK1 hangs during boot in next-20150508 and beyond:

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150508/20150508101018/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150511/20150511004533/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Any stuck task warnings or similar? Does lockdep catch something? -Daniel

Quoted 29 lines

Reverting commit 672cb1d6aec7da2799afd1b529d5136d84ed2561 ("drm: Add reference counting to blob properties") gets it booting again:

http://nvt.pwsan.com/pub/pwalmsley-tester/testlogs/test_20150511204703_3838232431c2636ff539f2354c630c0ca3d4b7ad/20150511204703/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

I'm not a DRM expert but maybe one of you knows what's going on here?

- Paul

commit 672cb1d6aec7da2799afd1b529d5136d84ed2561

Author: Daniel Stone <daniels-ZGY8ohtN/[email protected]>
Date:   Mon Apr 20 19:22:55 2015 +0100

drm: Add reference counting to blob properties

Reference-count drm_property_blob objects, changing the API to ref/unref.

Signed-off-by Daniel Stone <daniels-ZGY8ohtN/[email protected]>
Reviewed-by Maarten Lankhorst <maarten.lankhorst-VuQAYsv1563Yd54FQh9/[email protected]>
Signed-off-by Daniel Vetter <daniel.vetter-/[email protected]>

--
nvpublic

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#4 lore raw
In reply to Paul Walmsley

Hi Paul,

Quoted 11 lines · Paul Walmsley

Tegra124 Jetson TK1 hangs during boot in next-20150508 and beyond:

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150508/20150508101018/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150511/20150511004533/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Reverting commit 672cb1d6aec7da2799afd1b529d5136d84ed2561 ("drm: Add reference counting to blob properties") gets it booting again:

http://nvt.pwsan.com/pub/pwalmsley-tester/testlogs/test_20150511204703_3838232431c2636ff539f2354c630c0ca3d4b7ad/20150511204703/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

I'm not a DRM expert but maybe one of you knows what's going on here?

Thierry found and fixed the rather stupid bug: not using the cached 'dev' variable in the one place it would've been useful!

http://paste.debian.net/175522/ is the fix, which has been squashed in to the branch and should appear in -next from today.

Thanks for the report.

Cheers,
Daniel
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw

Hi Daniel,

Quoted 13 lines · Daniel Stone

Hi Paul,

Quoted 10 lines · Paul Walmsley

Tegra124 Jetson TK1 hangs during boot in next-20150508 and beyond:

http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150508/20150508101018/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt
http://nvt.pwsan.com/experimental/linux-next/testlogs/test_next-20150511/20150511004533/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Reverting commit 672cb1d6aec7da2799afd1b529d5136d84ed2561 ("drm: Add reference counting to blob properties") gets it booting again:

http://nvt.pwsan.com/pub/pwalmsley-tester/testlogs/test_20150511204703_3838232431c2636ff539f2354c630c0ca3d4b7ad/20150511204703/boot/tegra124-jetson-tk1/tegra124-jetson-tk1/tegra_defconfig_log.txt

Quoted 8 lines
Quoted 1 line

I'm not a DRM expert but maybe one of you knows what's going on here?

Thierry found and fixed the rather stupid bug: not using the cached 'dev' variable in the one place it would've been useful!

http://paste.debian.net/175522/ is the fix, which has been squashed in to the branch and should appear in -next from today.

Thanks for the report.

Great! Thanks everyone for the very fast fix.

- Paul