selftest: Add futex functional tests

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be of more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests, but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <[email protected]>

---

Quoted 29 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be of more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests, but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <[email protected]>

Quoted 1 line

---

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Quoted 32 lines · Shuah Khan

Quoted 29 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be of more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests, but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII text
0001-selftests-Add-futex-functional-tests.patch:                 unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:         unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch: unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:   unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:                      unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of © in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to fix my scripts to avoid the issue in the future.

If you want to use the patches directly, please have a look at 1 of 5 and just remove the "Content..." header, and I think you'll find "git am" will apply it without complaint.

Quoted 85 lines · Darren Hart

Quoted 36 lines · Shuah Khan

Quoted 33 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be of
more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests, but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference
to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII
text
0001-selftests-Add-futex-functional-tests.patch:                 unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:         unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch: unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:   unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:                      unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume
this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of
© in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to
fix my scripts to avoid the issue in the future.

Quoted 6 lines

If you want to use the patches directly, please have a look at 1 of 5 and
just remove the "Content..." header, and I think you'll find "git am" will
apply it without complaint.

Hi Daren,

Removing the Content header got me past the utf error. However, git am complains:

git am --signoff ../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbox
Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Could you look into these. Rest of the patches applied fine.

Quoted 106 lines · Shuah Khan

Quoted 85 lines · Darren Hart

Quoted 36 lines · Shuah Khan

Quoted 33 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be of
more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests, but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference
to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII
text
0001-selftests-Add-futex-functional-tests.patch:                 unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:         unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch: unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:   unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:                      unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume
this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of
© in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to
fix my scripts to avoid the issue in the future.

Quoted 6 lines

If you want to use the patches directly, please have a look at 1 of 5 and
just remove the "Content..." header, and I think you'll find "git am" will
apply it without complaint.

Hi Daren,

Removing the Content header got me past the utf error. However, git am complains:

git am --signoff ../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbox
Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Quoted 1 line

Could you look into these. Rest of the patches applied fine.

Hi Shuah,

This was due to a newline at the end of:
tools/testing/selftests/futex/functional/run.sh

Which unfortunately checkpatch.pl doesn't catch. My fault for not applying the series from the generated patches first. Sorry for the hassle.

I have corrected this in the first patch and pushed v3 of the series to:

git://git.infradead.org/users/dvhart/linux.git futextest-v3

$ git diff infradead/futextest-v2 infradead/futextest-v3

tools/testing/selftests/futex/functional/run.sh +0 -0

index 46827a8..e87dbe2 100755

Quoted 144 lines · Darren Hart

Quoted 117 lines · Shuah Khan

Quoted 94 lines · Darren Hart

Quoted 38 lines · Shuah Khan

Quoted 35 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be
of
more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests,
but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference
to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I
dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git
send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII
text
0001-selftests-Add-futex-functional-tests.patch:
unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:
unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch:
unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:
unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:
unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume
this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of
© in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to
fix my scripts to avoid the issue in the future.

Quoted 6 lines

If you want to use the patches directly, please have a look at 1 of 5 and
just remove the "Content..." header, and I think you'll find "git am" will
apply it without complaint.

Hi Daren,

Removing the Content header got me past the utf error. However, git am complains:

git am --signoff

../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbo x
Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Quoted 1 line

Could you look into these. Rest of the patches applied fine.

Hi Shuah,

This was due to a newline at the end of:
tools/testing/selftests/futex/functional/run.sh

Which unfortunately checkpatch.pl doesn't catch. My fault for not applying
the series from the generated patches first. Sorry for the hassle.

I have corrected this in the first patch and pushed v3 of the series to:

git://git.infradead.org/users/dvhart/linux.git futextest-v3

$ git diff infradead/futextest-v2 infradead/futextest-v3

tools/testing/selftests/futex/functional/run.sh +0 -0

index 46827a8..e87dbe2 100755

tools/testing/selftests/futex/functional/run.sh echo · line 80

Quoted 4 lines

tools/testing/selftests/futex/functional/run.sh +0 -1

@@ -77,4 +77,3 @@ echo
 echo
 ./futex_wait_uninitialized_heap $COLOR
 ./futex_wait_private_mapped_file $COLOR
-

No need for a new pull request. Have you seen these errors before:

make[2]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex' for DIR in functional; do make -C $DIR all ; done
make[3]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional'
gcc -g -O2 -Wall -D_GNU_SOURCE -I../include -I../../ -lpthread -lrt
futex_requeue_pi.c ../include/futextest.h -o futex_requeue_pi
/tmp/cc2UgUVs.o: In function `create_rt_thread':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:102:
undefined reference to `pthread_create'
/tmp/cc2UgUVs.o: In function `unit_test':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:342:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:347:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:346:
undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
<builtin>: recipe for target 'futex_requeue_pi' failed make[3]: *** [futex_requeue_pi] Error 1
make[3]: Leaving directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional' Makefile:7: recipe for target 'all' failed

I am running make kselftest target when I saw the above build failures. kselftest run doesn't fail which is good, however futex tests won't run with this failure.

Quoted 180 lines · Shuah Khan

Quoted 144 lines · Darren Hart

Quoted 117 lines · Shuah Khan

Quoted 94 lines · Darren Hart

Quoted 38 lines · Shuah Khan

Quoted 35 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be
of
more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests,
but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference
to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I
dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git
send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII
text
0001-selftests-Add-futex-functional-tests.patch:
unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:
unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch:
unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:
unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:
unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume
this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of
© in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to
fix my scripts to avoid the issue in the future.

Quoted 6 lines

If you want to use the patches directly, please have a look at 1 of 5 and
just remove the "Content..." header, and I think you'll find "git am" will
apply it without complaint.

Hi Daren,

Removing the Content header got me past the utf error. However, git am complains:

git am --signoff

../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbo x
Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Quoted 1 line

Could you look into these. Rest of the patches applied fine.

Hi Shuah,

This was due to a newline at the end of:
tools/testing/selftests/futex/functional/run.sh

Which unfortunately checkpatch.pl doesn't catch. My fault for not applying
the series from the generated patches first. Sorry for the hassle.

I have corrected this in the first patch and pushed v3 of the series to:

git://git.infradead.org/users/dvhart/linux.git futextest-v3

$ git diff infradead/futextest-v2 infradead/futextest-v3

tools/testing/selftests/futex/functional/run.sh +0 -0

index 46827a8..e87dbe2 100755

tools/testing/selftests/futex/functional/run.sh echo · line 80

Quoted 4 lines

tools/testing/selftests/futex/functional/run.sh +0 -1

@@ -77,4 +77,3 @@ echo
 echo
 ./futex_wait_uninitialized_heap $COLOR
 ./futex_wait_private_mapped_file $COLOR
-

No need for a new pull request. Have you seen these errors before:

make[2]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex' for DIR in functional; do make -C $DIR all ; done
make[3]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional'
gcc -g -O2 -Wall -D_GNU_SOURCE -I../include -I../../ -lpthread -lrt
futex_requeue_pi.c ../include/futextest.h -o futex_requeue_pi
/tmp/cc2UgUVs.o: In function `create_rt_thread':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:102:
undefined reference to `pthread_create'
/tmp/cc2UgUVs.o: In function `unit_test':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:342:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:347:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:346:
undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
<builtin>: recipe for target 'futex_requeue_pi' failed make[3]: *** [futex_requeue_pi] Error 1
make[3]: Leaving directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional' Makefile:7: recipe for target 'all' failed

Quoted 3 lines

I am running make kselftest target when I saw the above build failures. kselftest run doesn't fail which is good, however futex tests won't run with this failure.

I have not seen these errors whilst developing with futextest for the kernel. That looks like you may be missing the pthread development headers from your build machine.

Those are provided by libc6-dev on my Debian systems.

Quoted 186 lines · Darren Hart

Quoted 180 lines · Shuah Khan

Quoted 144 lines · Darren Hart

Quoted 117 lines · Shuah Khan

Quoted 94 lines · Darren Hart

Quoted 38 lines · Shuah Khan

Quoted 35 lines · Darren Hart

The futextest testsuite [1] provides functional, stress, and performance tests for the various futex op codes. Those tests will be
of
more use to futex developers if they are included with the kernel source.

Copy the core infrastructure and the functional tests into selftests,
but adapt them for inclusion in the kernel:

- Update the Makefile to include the run_tests target, remove reference
to the performance and stress tests from the contributed sources.
- Replace my dead IBM email address with my current Intel email address.
- Remove the warrantee and write-to paragraphs from the license blurbs.
- Remove the NAME section as the filename is easily determined. ;-)
- Make the whitespace usage consistent in a couple of places.
- Cleanup various CodingStyle violations.

A future effort will explore moving the performance and stress tests into the kernel.

1. http://git.kernel.org/cgit/linux/kernel/git/dvhart/futextest.git

Cc Shuah Khan <[email protected]>

Cc [email protected]

Cc Ingo Molnar <[email protected]>

Cc Peter Zijlstra <[email protected]>

Cc Thomas Gleixner <[email protected]>

Cc Davidlohr Bueso <[email protected]>

Cc KOSAKI Motohiro <[email protected]>

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

Quoted 1 line

---

Quoted 7 lines

Daren,

I am seeing

fatal: cannot convert from y to UTF-8

when I try to apply the patch. Did you use git send-email?

Hi Shuah,

I've seen that from one of my contributors earlier this month as well. I
dropped the Content... Header and it applied without problems.

I created the patch using git format-patch and then sent them using git
send-email - via a script I've been using for years now...

Checking the files locally:

$ file *
0000-cover-letter.patch:                                         ASCII
text
0001-selftests-Add-futex-functional-tests.patch:
unified
diff output, UTF-8 Unicode text
0002-selftest-futex-Update-Makefile-to-use-lib.mk.patch:
unified
diff output, ASCII text
0003-selftest-futex-Increment-ksft-pass-and-fail-counters.patch:
unified
diff output, ASCII text
0004-selftest-Add-futex-tests-to-the-top-level-Makefile.patch:
unified
diff output, ASCII text
0005-kselftest-Add-exit-code-defines.patch:
unified
diff output, ASCII text

This shows that only the first in UTF-8 and the rest are ASCII. I presume
this is due to the Copyright notices in the original files:

Copyright © International Business Machines Corp., 2006-2008

Which use © instead of (C). I just checked and there are 545 instances of
© in the kernel itself, so this should not present a problem.

I apologize for the glitch in applying. If you use the pull request I included that will avoid the mail transport issues, and I will be sure to
fix my scripts to avoid the issue in the future.

Quoted 6 lines

If you want to use the patches directly, please have a look at 1 of 5 and
just remove the "Content..." header, and I think you'll find "git am" will
apply it without complaint.

Hi Daren,

Removing the Content header got me past the utf error. However, git am complains:

git am --signoff

../4.2_patches/futex_tests/PATCH_1_5selftestsAddfutexfunctionaltests.mbo x
Applying: selftests: Add futex functional tests /mnt/data/lkml/linux-kselftest/.git/rebase-apply/patch:1457: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Quoted 1 line

Could you look into these. Rest of the patches applied fine.

Hi Shuah,

This was due to a newline at the end of:
tools/testing/selftests/futex/functional/run.sh

Which unfortunately checkpatch.pl doesn't catch. My fault for not applying
the series from the generated patches first. Sorry for the hassle.

I have corrected this in the first patch and pushed v3 of the series to:

git://git.infradead.org/users/dvhart/linux.git futextest-v3

$ git diff infradead/futextest-v2 infradead/futextest-v3

tools/testing/selftests/futex/functional/run.sh +0 -0

index 46827a8..e87dbe2 100755

tools/testing/selftests/futex/functional/run.sh echo · line 80

Quoted 4 lines

tools/testing/selftests/futex/functional/run.sh +0 -1

@@ -77,4 +77,3 @@ echo
 echo
 ./futex_wait_uninitialized_heap $COLOR
 ./futex_wait_private_mapped_file $COLOR
-

No need for a new pull request. Have you seen these errors before:

make[2]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex' for DIR in functional; do make -C $DIR all ; done
make[3]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional'
gcc -g -O2 -Wall -D_GNU_SOURCE -I../include -I../../ -lpthread -lrt
futex_requeue_pi.c ../include/futextest.h -o futex_requeue_pi
/tmp/cc2UgUVs.o: In function `create_rt_thread':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:102:
undefined reference to `pthread_create'
/tmp/cc2UgUVs.o: In function `unit_test':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:342:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:347:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional/fu tex_requeue_pi.c:346:
undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
<builtin>: recipe for target 'futex_requeue_pi' failed make[3]: *** [futex_requeue_pi] Error 1
make[3]: Leaving directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional' Makefile:7: recipe for target 'all' failed

Quoted 3 lines

I am running make kselftest target when I saw the above build failures. kselftest run doesn't fail which is good, however futex tests won't run with this failure.

Quoted 6 lines

I have not seen these errors whilst developing with futextest for the kernel. That looks like you may be missing the pthread development headers from your build machine.

Those are provided by libc6-dev on my Debian systems.

I do have lib6-dev installed. timers uses pthread compiles fine. So does mqueue. I am not sure what is going on with futex tests though. I am guessing it has to do with library link order.

The following fixed it for me:

(quoted diff) +1 -1

-LDFLAGS := $(LDFLAGS) -lpthread -lrt
+LDFLAGS := $(LDFLAGS) -pthread -lrt

Could you please make this change and resend the patch series. I prefer patch series over pull request.

thanks,
-- Shuah

Quoted 53 lines

Quoted 40 lines

Quoted 36 lines

No need for a new pull request. Have you seen these errors before:

make[2]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex' for DIR in functional; do make -C $DIR all ; done
make[3]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functiona l'
gcc -g -O2 -Wall -D_GNU_SOURCE -I../include -I../../ -lpthread -lrt
futex_requeue_pi.c ../include/futextest.h -o futex_requeue_pi
/tmp/cc2UgUVs.o: In function `create_rt_thread':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:102:
undefined reference to `pthread_create'
/tmp/cc2UgUVs.o: In function `unit_test':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:342:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:347:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:346:
undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
<builtin>: recipe for target 'futex_requeue_pi' failed make[3]: *** [futex_requeue_pi] Error 1
make[3]: Leaving directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functiona l'
Makefile:7: recipe for target 'all' failed

Quoted 3 lines

I am running make kselftest target when I saw the above build failures. kselftest run doesn't fail which is good, however futex tests won't run with this failure.

Quoted 7 lines

I have not seen these errors whilst developing with futextest for the kernel. That looks like you may be missing the pthread development headers
from your build machine.

Those are provided by libc6-dev on my Debian systems.

I do have lib6-dev installed. timers uses pthread compiles fine. So does mqueue. I am not sure what is going on with futex tests though. I am guessing it has to do with library link order. The following fixed it for me:

tools/testing/selftests/futex/functional/Makefile +1 -1

-LDFLAGS := $(LDFLAGS) -lpthread -lrt
+LDFLAGS := $(LDFLAGS) -pthread -lrt

Quoted 4 lines

Could you please make this change and resend the patch series. I prefer patch series over pull request.
thanks,
-- Shuah

Sorry full diff:

tools/testing/selftests/futex/functional/Makefile +0 -0

index e64d43b..b8a2e9b 100644
@@ -1,6 +1,6 @@

INCLUDES := -I../include -I../../
CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE $(INCLUDES)

Quoted 69 lines · Shuah Khan

Quoted 53 lines

Quoted 40 lines

Quoted 36 lines

No need for a new pull request. Have you seen these errors before:

make[2]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex' for DIR in functional; do make -C $DIR all ; done
make[3]: Entering directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functiona l'
gcc -g -O2 -Wall -D_GNU_SOURCE -I../include -I../../ -lpthread -lrt
futex_requeue_pi.c ../include/futextest.h -o futex_requeue_pi
/tmp/cc2UgUVs.o: In function `create_rt_thread':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:102:
undefined reference to `pthread_create'
/tmp/cc2UgUVs.o: In function `unit_test':
/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:342:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:347:
undefined reference to `pthread_join' /mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functional /fu
tex_requeue_pi.c:346:
undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
<builtin>: recipe for target 'futex_requeue_pi' failed make[3]: *** [futex_requeue_pi] Error 1
make[3]: Leaving directory '/mnt/data/lkml/linux-kselftest/tools/testing/selftests/futex/functiona l'
Makefile:7: recipe for target 'all' failed

Quoted 3 lines

I am running make kselftest target when I saw the above build failures. kselftest run doesn't fail which is good, however futex tests won't run with this failure.

Quoted 7 lines

I have not seen these errors whilst developing with futextest for the kernel. That looks like you may be missing the pthread development headers
from your build machine.

Those are provided by libc6-dev on my Debian systems.

I do have lib6-dev installed. timers uses pthread compiles fine. So does mqueue. I am not sure what is going on with futex tests though. I am guessing it has to do with library link order. The following fixed it for me:

tools/testing/selftests/futex/functional/Makefile +1 -1

-LDFLAGS := $(LDFLAGS) -lpthread -lrt
+LDFLAGS := $(LDFLAGS) -pthread -lrt

Quoted 4 lines

Could you please make this change and resend the patch series. I prefer patch series over pull request.
thanks,
-- Shuah

Sorry full diff:

tools/testing/selftests/futex/functional/Makefile +0 -0

index e64d43b..b8a2e9b 100644
@@ -1,6 +1,6 @@

INCLUDES := -I../include -I../../
CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE $(INCLUDES)

tools/testing/selftests/futex/functional/Makefile line 3

Quoted 2 lines

tools/testing/selftests/futex/functional/Makefile +1 -1

-LDFLAGS := $(LDFLAGS) -lpthread -lrt
+LDFLAGS := $(LDFLAGS) -pthread -lrt

I'm happy to do that, but I would like to make sure I'm doing the right thing.

I'm building with:

$ gcc --version
gcc (Debian 4.9.2-10) 4.9.2

What's there now works for me:

        LDFLAGS := $(LDFLAGS) -lpthread -lrt

What you propose also works for me:

        LDFLAGS := $(LDFLAGS) -pthread -lrt

I notice that most other test cases list -lrt first, including timers:

        LDFLAGS += -lrt -lpthread

Which works for me for timers - does that work for you? I assume so. It also works for futexes for me. I've found references out there suggesting -lrt should always come before -lpthread.

I suspect you are correct as -pthread provides flags for both the preprocessor and the linker, however, I'm still concerned about the ordering.

John - did you deliberately choose to use "-lrt -lpthread" ?

I'm happy to do that, but I would like to make sure I'm doing the right thing.

Hi!

Quoted 2 lines

I'm happy to do that, but I would like to make sure I'm doing the right thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Quoted 6 lines · Cyril Hrubis

Hi!

Quoted 2 lines

I'm happy to do that, but I would like to make sure I'm doing the right thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Unfortunately, all these options are functional for me, while some are not for Shuah, so I'm currently having to rely on documentation which seems pretty sparse.

Quoted 16 lines · Darren Hart

Quoted 6 lines · Cyril Hrubis

Hi!

Quoted 2 lines

I'm happy to do that, but I would like to make sure I'm doing the right thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

Quoted 9 lines

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Unfortunately, all these options are functional for me, while some are not for Shuah, so I'm currently having to rely on documentation which seems pretty sparse.

Hi Daren,

My goals are really simple. make kselftest doesn't break. All tests compile and run and install or fail gracefully when dependencies aren't met. As long as the above are met, I don't really worry about what individual test Makefiles do.

From 0b7284551d6419520d5ce8833e177ba5b8be2286 Mon Sep 17 00:00:00 2001

Quoted 27 lines · Shuah Khan

Quoted 16 lines · Darren Hart

Quoted 6 lines · Cyril Hrubis

Hi!

Quoted 2 lines

I'm happy to do that, but I would like to make sure I'm doing the right thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

Quoted 9 lines

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Unfortunately, all these options are functional for me, while some are not for Shuah, so I'm currently having to rely on documentation which seems pretty sparse.

Quoted 6 lines

Hi Daren,

My goals are really simple. make kselftest doesn't break. All tests compile and run and install or fail gracefully when dependencies aren't met. As long as the above are met, I don't really worry about what individual test Makefiles do.

Understood. Given the variability across distros/compiler versions, the "doesn't break" part isn't as straight forward as it should be. I could fix this so it builds for you and me, but I'm trying to build confidence that I'm doing this "correctly" so it doesn't break in other scenarios - since I'm not seeing any breakage on my systems.

Shuah, which distro and compiler version are you seeing the build failure on? I'd like to at least reproduce that so I can be confident my next version will at least build in your environment.

Currently, the only direction I have is gcc man page and Cyril's advocacy for -pthread. Does the following work for you (it still does for me)?

Quoted 1 line

From 0b7284551d6419520d5ce8833e177ba5b8be2286 Mon Sep 17 00:00:00 2001

Message-Id: <0b7284551d6419520d5ce8833e177ba5b8be2286.1431449782.git.dvhart-VuQAYsv1563Yd54FQh9/[email protected]>
From: Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>
Date: Tue, 12 May 2015 09:54:39 -0700
Subject: [PATCH] selftests/futex: Add -pthread to CFLAGS and LDFLAGS

Certain environments fail to build with the "-lpthread -lrt" LDFLAGS. Using "-pthread" instead of "-lpthread" resolves this and is the documented mechanism in the gcc man page.

Signed-off-by Darren Hart <dvhart-VuQAYsv1563Yd54FQh9/[email protected]>

---
 tools/testing/selftests/futex/functional/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

tools/testing/selftests/futex/functional/Makefile +0 -0

index e64d43b..9d6b75e 100644

Quoted 5 lines

Quoted 2 lines

I'm happy to do that, but I would like to make sure I'm doing the right thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Hi!

Quoted 15 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 4 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

Quoted 4 lines

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

The portable way i.e. POSIX would be getting compiler flags with getconf but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Quoted 33 lines · Cyril Hrubis

Hi!

Quoted 15 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 4 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to add more?

Quoted 4 lines

I'm also struggling to find any kind of prescribed documentation on this beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

Quoted 3 lines

The portable way i.e. POSIX would be getting compiler flags with getconf but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Thanks Cyril, that's perfect.

I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS into the initial patch and resubmit the patch series as v4.

Quoted 45 lines · Darren Hart

Quoted 32 lines · Cyril Hrubis

Hi!

Quoted 17 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 5 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags
for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to
add more?

Quoted 5 lines

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Quoted 8 lines

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

The portable way i.e. POSIX would be getting compiler flags with getconf
but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Thanks Cyril, that's perfect.

Quoted 3 lines

I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS into the initial patch and resubmit the patch series as v4.

Daren,

While you are generating new version, could you also please add .gitignore for the futex binaries, so they get ignored by git.

Quoted 50 lines · Shuah Khan

Quoted 48 lines · Darren Hart

Quoted 32 lines · Cyril Hrubis

Hi!

Quoted 17 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 5 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags
for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to
add more?

Quoted 5 lines

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Quoted 8 lines

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

The portable way i.e. POSIX would be getting compiler flags with getconf
but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Thanks Cyril, that's perfect.

I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS into the initial patch and resubmit the patch series as v4.

Quoted 4 lines

Daren,

While you are generating new version, could you also please add .gitignore for the futex binaries, so they get ignored by git.

Will do.

Quoted 52 lines · Darren Hart

Quoted 50 lines · Shuah Khan

Quoted 48 lines · Darren Hart

Quoted 32 lines · Cyril Hrubis

Hi!

Quoted 17 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 5 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags
for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to
add more?

Quoted 5 lines

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Quoted 8 lines

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

The portable way i.e. POSIX would be getting compiler flags with getconf
but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Thanks Cyril, that's perfect.

I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS into the initial patch and resubmit the patch series as v4.

Quoted 7 lines

Quoted 4 lines

Daren,

While you are generating new version, could you also please add .gitignore for the futex binaries, so they get ignored by git.

Will do.

Daren,

Do you plan to add futex test install support in a later patch series? When you sent this patch series, install support was work in progress. 4.1 has the kselftest install feature.

Feel free to defer it for a later patch series if you like. Would be good to get the futex install support into 4.2 if it is possible.

Quoted 67 lines · Shuah Khan

Quoted 52 lines · Darren Hart

Quoted 50 lines · Shuah Khan

Quoted 48 lines · Darren Hart

Quoted 32 lines · Cyril Hrubis

Hi!

Quoted 17 lines

Quoted 1 line

Quoted 1 line

I'm happy to do that, but I would like to make sure I'm doing the

right

Quoted 5 lines

Quoted 1 line

thing.

The right thing here is to add -pthread to CFLAGS which sets both flags
for preprocessor and linker (see man gcc).

Hi Cyril,

Thanks. I read that, and mentioned it, but my concern with -pthread in the
CFLAGS and LDFLAGS is that it is a non-standard compiler flag. I understand we have a number of gcc-isms in our build - but do we want to
add more?

Quoted 5 lines

I'm also struggling to find any kind of prescribed documentation on this
beyond the short blurb in the gcc man page which describes what this option does, but not when to use it. I'll need something concrete to justify changes to testcase Makefiles to Shuah.

Sorry to mislead you with the pointing at gcc man page.

It is a Linux standard. Have a look at pthreads manual page:
http://man7.org/linux/man-pages/man7/pthreads.7.html

"On Linux, programs that use the Pthreads API should be compiled using cc -pthread."

Quoted 8 lines

Or any pthread_foo() manual page that starts with:

"Compile and link with -pthread."

The portable way i.e. POSIX would be getting compiler flags with getconf
but as this is a Linux kernel testsuite I would not bother with that. Hmm, and it looks like this is not implemented on Linux anyway.

Thanks Cyril, that's perfect.

I'll roll my latest example patch adding -pthread to LDFLAGS and CFLAGS into the initial patch and resubmit the patch series as v4.

Quoted 7 lines

Quoted 4 lines

Daren,

While you are generating new version, could you also please add .gitignore for the futex binaries, so they get ignored by git.

Will do.

Daren,

Do you plan to add futex test install support in a later patch series? When you sent this patch series, install support was work in progress. 4.1 has the kselftest install feature.

Quoted 3 lines

Feel free to defer it for a later patch series if you like. Would be good to get the futex install support into 4.2 if it is possible.

I am blind. Never mind. futex tests are installed.