Skip to contentSkip to conversation

[meta-qt5][PATCH]

PATCH In review Andrey Rusalin 2 participants 3 messages May 13, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andrey Rusalin

author
#1 lore raw

PATCH 1/1 [meta-qt5][PATCH]

-------- Forwarded Message --------
Subject: [meta-qt5][PATCH]
Date: Wed, 13 May 2015 13:44:59 +0300
From: arusalin <[email protected]>
To: [email protected]

Signature · 2 lines
Best Regards,
Andrey Rusalin.

From 7040c6382af3d99f53b3f9fa45336cb911438923 Mon Sep 17 00:00:00 2001
From: Andrey Rusalin <[email protected]>
Date: Wed, 13 May 2015 14:25:42 +0400
Subject: [PATCH] Fixed dependency for sql-mysql option of qtbase package

---
 recipes-qt/qt5/qtbase.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qtbase.inc +1 -1
index 50cb505..d2654ef 100644
@@ -84,7 +84,7 @@ PACKAGECONFIG[cups] = "-cups,-no-cups,cups"
 PACKAGECONFIG[dbus] = "-dbus,-no-dbus,dbus"
 PACKAGECONFIG[xcb] = "-xcb -xcb-xlib -system-xcb,-no-xcb,libxcb xcb-util-wm xcb-util-image xcb-util-keysyms xcb-util-renderutil"
 PACKAGECONFIG[sql-ibase] = "-sql-ibase,-no-sql-ibase"
-PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql"
+PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql5"
 PACKAGECONFIG[sql-psql] = "-sql-psql,-no-sql-psql,postgresql"
 PACKAGECONFIG[sql-odbc] = "-sql-odbc,-no-sql-odbc"
 PACKAGECONFIG[sql-oci] = "-sql-oci,-no-sql-oci"
Signature · 1 line
1.9.1
#2 lore raw
Quoted 2 lines · Andrey Rusalin

Missing SOB line and patchwork doesn't pick forwarded inline patches correctly.

I've fixed both when cherry-picking to master-next, but please reply that you agree with your SOB.

Quoted 49 lines

-------- Forwarded Message --------
Subject: [meta-qt5][PATCH]
Date: Wed, 13 May 2015 13:44:59 +0300
From: arusalin <[email protected]>
To: [email protected]

Signature · 15 lines
Best Regards,
Andrey Rusalin.





From 7040c6382af3d99f53b3f9fa45336cb911438923 Mon Sep 17 00:00:00 2001
From: Andrey Rusalin <[email protected]>
Date: Wed, 13 May 2015 14:25:42 +0400
Subject: [PATCH] Fixed dependency for sql-mysql option of qtbase package

---
 recipes-qt/qt5/qtbase.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qtbase.inc +1 -1
index 50cb505..d2654ef 100644
@@ -84,7 +84,7 @@ PACKAGECONFIG[cups] = "-cups,-no-cups,cups"
 PACKAGECONFIG[dbus] = "-dbus,-no-dbus,dbus"
 PACKAGECONFIG[xcb] = "-xcb -xcb-xlib -system-xcb,-no-xcb,libxcb xcb-util-wm xcb-util-image xcb-util-keysyms xcb-util-renderutil"
 PACKAGECONFIG[sql-ibase] = "-sql-ibase,-no-sql-ibase"
-PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql"
+PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql5"
 PACKAGECONFIG[sql-psql] = "-sql-psql,-no-sql-psql,postgresql"
 PACKAGECONFIG[sql-odbc] = "-sql-odbc,-no-sql-odbc"
 PACKAGECONFIG[sql-oci] = "-sql-oci,-no-sql-oci"
Signature · 9 lines
1.9.1



-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
author
#3 lore raw

I agree with SOB. Also correct patch is attached.

Quoted 54 lines · Martin Jansa
Quoted 1 line · Andrey Rusalin

Missing SOB line and patchwork doesn't pick forwarded inline patches correctly.

I've fixed both when cherry-picking to master-next, but please reply that you agree with your SOB.

Quoted 46 lines

-------- Forwarded Message --------
Subject: [meta-qt5][PATCH]
Date: Wed, 13 May 2015 13:44:59 +0300
From: arusalin <[email protected]>
To: [email protected]

Signature · 14 lines
Best Regards,
Andrey Rusalin.




 From 7040c6382af3d99f53b3f9fa45336cb911438923 Mon Sep 17 00:00:00 2001
From: Andrey Rusalin <[email protected]>
Date: Wed, 13 May 2015 14:25:42 +0400
Subject: [PATCH] Fixed dependency for sql-mysql option of qtbase package

---
  recipes-qt/qt5/qtbase.inc | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qtbase.inc +1 -1
index 50cb505..d2654ef 100644
@@ -84,7 +84,7 @@ PACKAGECONFIG[cups] = "-cups,-no-cups,cups"
  PACKAGECONFIG[dbus] = "-dbus,-no-dbus,dbus"
  PACKAGECONFIG[xcb] = "-xcb -xcb-xlib -system-xcb,-no-xcb,libxcb xcb-util-wm xcb-util-image xcb-util-keysyms xcb-util-renderutil"
  PACKAGECONFIG[sql-ibase] = "-sql-ibase,-no-sql-ibase"
-PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql"
+PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql5"
  PACKAGECONFIG[sql-psql] = "-sql-psql,-no-sql-psql,postgresql"
  PACKAGECONFIG[sql-odbc] = "-sql-odbc,-no-sql-odbc"
  PACKAGECONFIG[sql-oci] = "-sql-oci,-no-sql-oci"
Signature · 8 lines
1.9.1


-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 2 lines
Best Regards,
Andrey Rusalin.

From 8b7d3580732c5ad9a8148cdca6a6413ecf0bbd49 Mon Sep 17 00:00:00 2001
From: Andrey Rusalin <[email protected]>
Date: Wed, 13 May 2015 17:15:21 +0400
Subject: [PATCH] Fixed dependency for sql-mysql option of qtbase package

Signed-off-by Andrey Rusalin <[email protected]>
---
 recipes-qt/qt5/qtbase.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-qt/qt5/qtbase.inc +1 -1
index 50cb505..d2654ef 100644
@@ -84,7 +84,7 @@ PACKAGECONFIG[cups] = "-cups,-no-cups,cups"
 PACKAGECONFIG[dbus] = "-dbus,-no-dbus,dbus"
 PACKAGECONFIG[xcb] = "-xcb -xcb-xlib -system-xcb,-no-xcb,libxcb xcb-util-wm xcb-util-image xcb-util-keysyms xcb-util-renderutil"
 PACKAGECONFIG[sql-ibase] = "-sql-ibase,-no-sql-ibase"
-PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql"
+PACKAGECONFIG[sql-mysql] = "-sql-mysql,-no-sql-mysql,mysql5"
 PACKAGECONFIG[sql-psql] = "-sql-psql,-no-sql-psql,postgresql"
 PACKAGECONFIG[sql-odbc] = "-sql-odbc,-no-sql-odbc"
 PACKAGECONFIG[sql-oci] = "-sql-oci,-no-sql-oci"
Signature · 1 line
1.9.1