mtd: readtest: don't clobber error reports

PATCH In review Brian Norris 2 participants 3 messages May 12, 2015 – May 14, 2015 Memory technology devices (MTD)

lore

Share & tools

lore

Brian Norris

author

2015-05-12 21:34 UTC #0 lore raw

PATCH 1/1 mtd: readtest: don't clobber error reports

Commit 2a6a28e7922c ("mtd: Make MTD tests cancelable") accidentally clobbered any read failure reports.

Coverity CID #1296020

Signed-off-by Brian Norris <[email protected]>

---
regression in v4.1-rc1, so I'll probably want to queue this for 4.1

 drivers/mtd/tests/readtest.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/mtd/tests/readtest.c +4 -2

index a3196b750a22..58df07acdbdb 100644
@@ -191,9 +191,11 @@ static int __init mtd_readtest_init(void)
 				err = ret;
 		}
 
-		err = mtdtest_relax();
-		if (err)
+		ret = mtdtest_relax();
+		if (ret) {
+			err = ret;
 			goto out;
+		}
 	}
 
 	if (err)

Signature · 1 line

1.9.1

Richard Weinberger

maintainer

2015-05-14 08:27 UTC #1 lore raw

Am 12.05.2015 um 23:33 schrieb Brian Norris:

Quoted 8 lines

Commit 2a6a28e7922c ("mtd: Make MTD tests cancelable") accidentally clobbered any read failure reports.
Coverity CID #1296020
Signed-off-by Brian Norris <[email protected]>
---
regression in v4.1-rc1, so I'll probably want to queue this for 4.1

Sounds sane. Thanks for fixing!

Thanks,
//richard

Brian Norris

author Applied

2015-05-14 16:57 UTC #2 lore raw

Quoted 11 lines · Richard Weinberger

Am 12.05.2015 um 23:33 schrieb Brian Norris:
Quoted 8 lines
Commit 2a6a28e7922c ("mtd: Make MTD tests cancelable") accidentally clobbered any read failure reports.
Coverity CID #1296020
Signed-off-by Brian Norris <[email protected]>
---
regression in v4.1-rc1, so I'll probably want to queue this for 4.1
Sounds sane. Thanks for fixing!

Applied to linux-mtd.git.

Brian