Skip to contentSkip to conversation

fix net/sched compile error

PATCH In review Brian Haley 3 participants 3 messages May 14, 2015

Subsystems (3)
Networking Network drivers Traffic control (tc)
lore
Share & tools
lore

Brian Haley

author
#0 lore raw

PATCH 1/1 fix net/sched compile error

Fix compile error in net/sched/cls_flower.c

net/sched/cls_flower.c: In function ‘fl_set_key’:
net/sched/cls_flower.c:240:3: error: implicit declaration of function
‘tcf_change_indev’ [-Werror=implicit-function-declaration]

       err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641

Signed-off-by Brian Haley <[email protected]>
net/sched/cls_flower.c +3 -3
index 9bc654c..8c8f34e 100644
@@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
 static int fl_set_key(struct net *net, struct nlattr **tb,
 		      struct fl_flow_key *key, struct fl_flow_key *mask)
 {
-	int err;
-
+#ifdef CONFIG_NET_CLS_IND
 	if (tb[TCA_FLOWER_INDEV]) {
-		err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
+		int err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
 		if (err < 0)
 			return err;
 		key->indev_ifindex = err;
 		mask->indev_ifindex = 0xffffffff;
 	}
+#endif
 
 	fl_set_key_val(tb, key->eth.dst, TCA_FLOWER_KEY_ETH_DST,
 		       mask->eth.dst, TCA_FLOWER_KEY_ETH_DST_MASK,
maintainer
#1 lore raw

From: Brian Haley <[email protected]>
Date: Thu, 14 May 2015 12:33:11 -0400

Quoted 10 lines

Fix compile error in net/sched/cls_flower.c

net/sched/cls_flower.c: In function ‘fl_set_key’:
net/sched/cls_flower.c:240:3: error: implicit declaration of function ‘tcf_change_indev’ [-Werror=implicit-function-declaration]
err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641

Signed-off-by Brian Haley <[email protected]>

Please format your Subject line correctly.

After '[PATCH] ' or similar, you should begin with a subsystem or driver name prefix, following by a colon character and a space.

In this case, "cls_flower: " would be appropriate.

So something like "[PATCH] cls_flower: Fix compile error."

#2 lore raw
In reply to Brian Haley

Hello.

Quoted 16 lines · Brian Haley

Fix compile error in net/sched/cls_flower.c

net/sched/cls_flower.c: In function ‘fl_set_key’:
net/sched/cls_flower.c:240:3: error: implicit declaration of function
‘tcf_change_indev’ [-Werror=implicit-function-declaration]

        err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641

Signed-off-by Brian Haley <[email protected]>
net/sched/cls_flower.c +0 -0
index 9bc654c..8c8f34e 100644

net/sched/cls_flower.c static void fl_set_key_val(struct nlattr **tb, · line 239

Quoted 9 lines
net/sched/cls_flower.c +2 -3
@@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
  static int fl_set_key(struct net *net, struct nlattr **tb,
                struct fl_flow_key *key, struct fl_flow_key *mask)
  {
-    int err;
-
+#ifdef CONFIG_NET_CLS_IND
      if (tb[TCA_FLOWER_INDEV]) {
-        err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
+        int err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);

Empty line needed here.

net/sched/cls_flower.c static void fl_set_key_val(struct nlattr **tb, · line 245

Quoted 6 lines
net/sched/cls_flower.c +1 -0
          if (err < 0)
              return err;
          key->indev_ifindex = err;
          mask->indev_ifindex = 0xffffffff;
      }
+#endif

[...]

WBR, Sergei