mtd: Explicitly include correct DT includes

PATCH Applied Rob Herring 4 participants 5 messages Jul 14, 2023 – Jul 27, 2023

Subsystems (22)

Arm Qualcomm mailing list Arm i.MX and Layerscape Memory technology devices (MTD) MIPS +18 more subsystems

lore

Share & tools

lore

Rob Herring

author

2023-07-14 17:48 UTC #0 lore raw

PATCH 1/1 mtd: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Signed-off-by Rob Herring <[email protected]>

---
 drivers/mtd/devices/mchp23k256.c                | 2 +-
 drivers/mtd/devices/mchp48l640.c                | 2 +-
 drivers/mtd/devices/mtd_dataflash.c             | 1 -
 drivers/mtd/maps/physmap-bt1-rom.c              | 1 -
 drivers/mtd/maps/physmap-gemini.c               | 2 +-
 drivers/mtd/maps/physmap-ixp4xx.c               | 2 +-
 drivers/mtd/maps/physmap-ixp4xx.h               | 1 +
 drivers/mtd/maps/physmap-versatile.c            | 2 +-
 drivers/mtd/maps/sun_uflash.c                   | 2 +-
 drivers/mtd/nand/ecc-mxic.c                     | 2 +-
 drivers/mtd/nand/ecc.c                          | 2 +-
 drivers/mtd/nand/onenand/onenand_omap2.c        | 2 +-
 drivers/mtd/nand/raw/ams-delta.c                | 2 +-
 drivers/mtd/nand/raw/davinci_nand.c             | 1 -
 drivers/mtd/nand/raw/denali_dt.c                | 1 -
 drivers/mtd/nand/raw/fsl_ifc_nand.c             | 1 +
 drivers/mtd/nand/raw/fsl_upm.c                  | 3 ++-
 drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c      | 2 +-
 drivers/mtd/nand/raw/ingenic/ingenic_ecc.c      | 1 +
 drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 1 -
 drivers/mtd/nand/raw/marvell_nand.c             | 3 ++-
 drivers/mtd/nand/raw/meson_nand.c               | 1 -
 drivers/mtd/nand/raw/mpc5121_nfc.c              | 4 ++--
 drivers/mtd/nand/raw/mtk_nand.c                 | 1 -
 drivers/mtd/nand/raw/mxc_nand.c                 | 1 -
 drivers/mtd/nand/raw/ndfc.c                     | 3 ++-
 drivers/mtd/nand/raw/omap2.c                    | 2 +-
 drivers/mtd/nand/raw/pl35x-nand-controller.c    | 4 +---
 drivers/mtd/nand/raw/qcom_nandc.c               | 2 +-
 drivers/mtd/nand/raw/rockchip-nand-controller.c | 1 -
 drivers/mtd/nand/raw/s3c2410.c                  | 1 -
 drivers/mtd/nand/raw/sh_flctl.c                 | 1 -
 drivers/mtd/nand/raw/socrates_nand.c            | 3 ++-
 drivers/mtd/nand/raw/sunxi_nand.c               | 1 -
 drivers/mtd/nand/raw/xway_nand.c                | 3 ++-
 drivers/mtd/spi-nor/controllers/nxp-spifi.c     | 1 -
 36 files changed, 29 insertions(+), 36 deletions(-)

drivers/mtd/devices/mchp23k256.c +1 -1

index 3a6ea7a6a30c..d533475fda15 100644
@@ -15,7 +15,7 @@
 #include <linux/sizes.h>
 #include <linux/spi/flash.h>
 #include <linux/spi/spi.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 
 #define MAX_CMD_SIZE		4

drivers/mtd/devices/mchp48l640.c +1 -1

index 40cd5041174c..f576e6a890e8 100644
@@ -22,7 +22,7 @@
 #include <linux/sizes.h>
 #include <linux/spi/flash.h>
 #include <linux/spi/spi.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 
 struct mchp48_caps {
 	unsigned int size;

drivers/mtd/devices/mtd_dataflash.c +0 -1

index 1d3b2a94581f..0c1b93303618 100644
@@ -13,7 +13,6 @@
 #include <linux/err.h>
 #include <linux/math64.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 #include <linux/spi/spi.h>
 #include <linux/spi/flash.h>

drivers/mtd/maps/physmap-bt1-rom.c +0 -1

index 58782cfaf71c..60dccc48f99e 100644
@@ -14,7 +14,6 @@
 #include <linux/mtd/xip.h>
 #include <linux/mux/consumer.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/string.h>
 #include <linux/types.h>

drivers/mtd/maps/physmap-gemini.c +1 -1

index d4a46e159d38..9d3b4bf84a1a 100644
@@ -8,10 +8,10 @@
  */
 #include <linux/export.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/mtd/map.h>
 #include <linux/mtd/xip.h>
 #include <linux/mfd/syscon.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/bitops.h>
 #include <linux/pinctrl/consumer.h>

drivers/mtd/maps/physmap-ixp4xx.c +1 -1

index 6a054229a8a0..c561468f95f6 100644
@@ -11,7 +11,7 @@
  */
 #include <linux/export.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/platform_device.h>
 #include <linux/mtd/map.h>
 #include <linux/mtd/xip.h>
 #include "physmap-ixp4xx.h"

drivers/mtd/maps/physmap-ixp4xx.h +1 -0

index b0fc49b7f3ed..46824c57e58a 100644
@@ -1,5 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #include <linux/of.h>
+#include <linux/platform_device.h>
 #include <linux/mtd/map.h>
 
 #ifdef CONFIG_MTD_PHYSMAP_IXP4XX

drivers/mtd/maps/physmap-versatile.c +1 -1

index a1b8b7b25f88..8e15d514c82d 100644
@@ -9,9 +9,9 @@
 #include <linux/io.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/mtd/map.h>
 #include <linux/mfd/syscon.h>
+#include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/bitops.h>
 #include "physmap-versatile.h"

drivers/mtd/maps/sun_uflash.c +1 -1

index 860b19f77090..2bfdf1b7e18a 100644
@@ -14,7 +14,7 @@
 #include <linux/errno.h>
 #include <linux/ioport.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <asm/prom.h>
 #include <linux/uaccess.h>

drivers/mtd/nand/ecc-mxic.c +1 -1

index 22a760e6024e..47e10945b8d2 100644
@@ -18,7 +18,7 @@
 #include <linux/mtd/nand.h>
 #include <linux/mtd/nand-ecc-mxic.h>
 #include <linux/mutex.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>

drivers/mtd/nand/ecc.c +1 -1

index 5250764cedee..8f996e8d61b8 100644
@@ -95,9 +95,9 @@
 
 #include <linux/module.h>
 #include <linux/mtd/nand.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/of_platform.h>
 
 static LIST_HEAD(on_host_hw_engines);

drivers/mtd/nand/onenand/onenand_omap2.c +1 -1

index ff7af98604df..7db53b59605d 100644
@@ -13,7 +13,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/onenand.h>
 #include <linux/mtd/partitions.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/omap-gpmc.h>
 #include <linux/platform_device.h>
 #include <linux/interrupt.h>

drivers/mtd/nand/raw/ams-delta.c +1 -1

index fa621ffa6490..919816a7aca7 100644
@@ -22,7 +22,7 @@
 #include <linux/mtd/nand-gpio.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/sizes.h>

drivers/mtd/nand/raw/davinci_nand.c +0 -1

index 415d6aaa8255..e75d81cf8c21 100644
@@ -18,7 +18,6 @@
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
 #include <linux/slab.h>
-#include <linux/of_device.h>
 #include <linux/of.h>
 
 #include <linux/platform_data/mtd-davinci.h>

drivers/mtd/nand/raw/denali_dt.c +0 -1

index 915047e3fbc2..edac8749bb93 100644
@@ -13,7 +13,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/reset.h>

drivers/mtd/nand/raw/fsl_ifc_nand.c +1 -0

index fa537fee6701..20bb1e0cb5eb 100644
@@ -8,6 +8,7 @@
  */
 
 #include <linux/module.h>
+#include <linux/platform_device.h>
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <linux/of_address.h>

drivers/mtd/nand/raw/fsl_upm.c +2 -1

index 086426139173..5bf73efe42e7 100644
@@ -13,7 +13,8 @@
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
 #include <linux/mtd/mtd.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 #include <linux/io.h>
 #include <linux/slab.h>
 #include <asm/fsl_lbc.h>

drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c +1 -1

index 500e7a28d2e4..e71ad2fcec23 100644
@@ -13,7 +13,7 @@
 #include <linux/module.h>
 #include <linux/mtd/partitions.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/dma/mxs-dma.h>
 #include "gpmi-nand.h"

drivers/mtd/nand/raw/ingenic/ingenic_ecc.c +1 -0

index 9054559e52dd..525c34c281b6 100644
@@ -9,6 +9,7 @@
 #include <linux/clk.h>
 #include <linux/init.h>
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>

drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c +0 -1

index b9f135297aa0..6748226b8bd1 100644
@@ -13,7 +13,6 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/gpio/consumer.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>

drivers/mtd/nand/raw/marvell_nand.c +2 -1

index 30c15e4e1cc0..7d0204ea305b 100644
@@ -77,9 +77,10 @@
 #include <linux/module.h>
 #include <linux/clk.h>
 #include <linux/mtd/rawnand.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/iopoll.h>
 #include <linux/interrupt.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>

drivers/mtd/nand/raw/meson_nand.c +0 -1

index d3faf8086631..ef821b43b3d4 100644
@@ -19,7 +19,6 @@
 #include <linux/module.h>
 #include <linux/iopoll.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/sched/task_stack.h>
 
 #define NFC_REG_CMD		0x00

drivers/mtd/nand/raw/mpc5121_nfc.c +2 -2

index ab05ee65702c..6e8e790f84e7 100644
@@ -21,10 +21,10 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #include <asm/mpc5121.h>

drivers/mtd/nand/raw/mtk_nand.c +0 -1

index b2fa6b2074ab..b6eb8cb6b5e9 100644
@@ -16,7 +16,6 @@
 #include <linux/module.h>
 #include <linux/iopoll.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/mtd/nand-ecc-mtk.h>
 
 /* NAND controller register definition */

drivers/mtd/nand/raw/mxc_nand.c +0 -1

index 3d4b2e8294ea..0cd98d5714fc 100644
@@ -20,7 +20,6 @@
 #include <linux/irq.h>
 #include <linux/completion.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 #define DRIVER_NAME "mxc_nand"

drivers/mtd/nand/raw/ndfc.c +2 -1

index 57f3db32122d..3bb32a7c6d67 100644
@@ -22,8 +22,9 @@
 #include <linux/mtd/ndfc.h>
 #include <linux/slab.h>
 #include <linux/mtd/mtd.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <asm/io.h>
 
 #define NDFC_MAX_CS    4

drivers/mtd/nand/raw/omap2.c +1 -1

index db22b3af16d8..e057c03a197d 100644
@@ -22,7 +22,7 @@
 #include <linux/iopoll.h>
 #include <linux/slab.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/of_platform.h>
 
 #include <linux/platform_data/elm.h>

drivers/mtd/nand/raw/pl35x-nand-controller.c +1 -3

index 28b7bd7e22eb..8da5fee321b5 100644
@@ -23,9 +23,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
-#include <linux/of_address.h>
-#include <linux/of_device.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/clk.h>

drivers/mtd/nand/raw/qcom_nandc.c +1 -1

index 72d6168d8a1b..df245353b12b 100644
@@ -3,6 +3,7 @@
  * Copyright (c) 2016, The Linux Foundation. All rights reserved.
  */
 #include <linux/clk.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/bitops.h>
 #include <linux/dma/qcom_adm.h>

@@ -12,7 +13,6 @@
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/delay.h>
 #include <linux/dma/qcom_bam_dma.h>

drivers/mtd/nand/raw/rockchip-nand-controller.c +0 -1

index 2312e27362cb..0ec03ffb4846 100644
@@ -15,7 +15,6 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>

drivers/mtd/nand/raw/s3c2410.c +0 -1

index ac80aaf5b4e3..3d3d5c9814ff 100644
@@ -26,7 +26,6 @@
 #include <linux/clk.h>
 #include <linux/cpufreq.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>

drivers/mtd/nand/raw/sh_flctl.c +0 -1

index 63bf20c41719..08211e96ce64 100644
@@ -17,7 +17,6 @@
 #include <linux/interrupt.h>
 #include <linux/io.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 #include <linux/sh_dma.h>

drivers/mtd/nand/raw/socrates_nand.c +2 -1

index a8b720ffe9e8..76d50eb9f1db 100644
@@ -8,8 +8,9 @@
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/io.h>
 
 #define FPGA_NAND_CMD_MASK		(0x7 << 28)

drivers/mtd/nand/raw/sunxi_nand.c +0 -1

index 9884304634f6..c6cd7713bee7 100644
@@ -19,7 +19,6 @@
 #include <linux/moduleparam.h>
 #include <linux/platform_device.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/mtd/mtd.h>
 #include <linux/mtd/rawnand.h>
 #include <linux/mtd/partitions.h>

drivers/mtd/nand/raw/xway_nand.c +2 -1

index 6b1e2a2bba15..51d802a165ed 100644
@@ -7,7 +7,8 @@
 
 #include <linux/mtd/rawnand.h>
 #include <linux/of_gpio.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 
 #include <lantiq_soc.h>

drivers/mtd/spi-nor/controllers/nxp-spifi.c +0 -1

index 794c7b7d5c92..337e83bf3362 100644
@@ -17,7 +17,6 @@
 #include <linux/mtd/partitions.h>
 #include <linux/mtd/spi-nor.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/spi/spi.h>

Signature · 1 line

2.40.1

Miquel Raynal

maintainer

2023-07-15 15:48 UTC #1 lore raw

Hi Rob,

[email protected] wrote on Fri, 14 Jul 2023 11:47:49 -0600:

Quoted 2 lines

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus.

was?

Otherwise LGTM, I will fix it when applying.

Quoted 8 lines

As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Signed-off-by Rob Herring <[email protected]>

Thanks,
Miquèl

Linus Walleij

Reviewed-by on v1 1/1

2023-07-15 17:57 UTC #2 lore raw

In reply to Rob Herring

Quoted 10 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.
Signed-off-by Rob Herring <[email protected]>

Thanks for going back and fixing up this!

Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

Heiko Stuebner

maintainer Acked-by on v1 1/1

2023-07-15 21:43 UTC #3 lore raw

In reply to Rob Herring

Am Freitag, 14. Juli 2023, 19:47:49 CEST schrieb Rob Herring:

Quoted 9 lines

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Quoted 4 lines

Signed-off-by Rob Herring <[email protected]>
---
 drivers/mtd/nand/raw/rockchip-nand-controller.c | 1 -

Acked-by Heiko Stuebner <[email protected]>

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Miquel Raynal

maintainer Applied

2023-07-27 15:18 UTC #4 lore raw

In reply to Rob Herring

Quoted 9 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Quoted 3 lines

Signed-off-by Rob Herring <[email protected]>
Reviewed-by Linus Walleij <[email protected]>
Acked-by Heiko Stuebner <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel