Skip to contentSkip to conversation

imx: ventana: use stack relocation

PATCH New Tim Harvey 3 participants 3 messages May 14, 2015 – May 15, 2015

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 imx: ventana: use stack relocation

Certain features we desire require a larger stack than is available by using iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that we can use these features.

Signed-off-by Tim Harvey <[email protected]>
---
 board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
 configs/gwventana_defconfig                 | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
board/gateworks/gw_ventana/gw_ventana_spl.c +0 -3
index 289a0b8..8d41bb4 100644
@@ -565,9 +565,6 @@ void board_init_f(ulong dummy)
 
 	/* Clear the BSS. */
 	memset(__bss_start, 0, __bss_end - __bss_start);
-
-	/* load/boot image from boot device */
-	board_init_r(NULL, 0);
 }
 
 void reset_cpu(ulong addr)
configs/gwventana_defconfig +2 -0
index d6bbdc1..b28fe4b 100644
@@ -3,3 +3,5 @@ CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL"
 CONFIG_ARM=y
 CONFIG_TARGET_GW_VENTANA=y
 CONFIG_SYS_MALLOC_F=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_ADDR=0x18000000
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 imx: ventana: use stack relocation

Quoted 9 lines · Tim Harvey

Certain features we desire require a larger stack than is available by using iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that we can use these features.

Signed-off-by Tim Harvey <[email protected]>
---
 board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
 configs/gwventana_defconfig                 | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by Simon Glass <[email protected]>
#2 lore raw

PATCH 1/1 imx: ventana: use stack relocation

In reply to Tim Harvey

Hi Tim,

Quoted 30 lines · Tim Harvey

Certain features we desire require a larger stack than is available by using iRAM (most notably for us, env_mmc). Relocate the stack to DRAM so that we can use these features.

Signed-off-by Tim Harvey <[email protected]>
---
 board/gateworks/gw_ventana/gw_ventana_spl.c | 3 ---
 configs/gwventana_defconfig                 | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)
board/gateworks/gw_ventana/gw_ventana_spl.c +0 -3
index 289a0b8..8d41bb4 100644
@@ -565,9 +565,6 @@ void board_init_f(ulong dummy)
 
 	/* Clear the BSS. */
 	memset(__bss_start, 0, __bss_end - __bss_start);
-
-	/* load/boot image from boot device */
-	board_init_r(NULL, 0);
 }
 
 void reset_cpu(ulong addr)
configs/gwventana_defconfig +0 -0
index d6bbdc1..b28fe4b 100644

configs/gwventana_defconfig CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL" · line 7

Quoted 5 lines
configs/gwventana_defconfig +2 -0
@@ -3,3 +3,5 @@ CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6QDL"
 CONFIG_ARM=y
 CONFIG_TARGET_GW_VENTANA=y
 CONFIG_SYS_MALLOC_F=y
+CONFIG_SPL_STACK_R=y
+CONFIG_SPL_STACK_R_ADDR=0x18000000

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================