Skip to contentSkip to conversation

enlightenment: updating on which platforms ptrace is disabled

PATCH New Gergely Imreh 2 participants 2 messages May 8, 2015 – May 16, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enlightenment: updating on which platforms ptrace is disabled

uclibc is missing definitions in sys/ptrace.h for certain plaforms. The xtensa platform is also affected (linked autobuild failure), fixed by disabling ptrace for that too. This choice of disabling ptrace for all uclibc choices is probably conservative: while uclibc-ng fails, uclibc Git Xstensa seeems to compile successfully.

http://autobuild.buildroot.org/results/d03/d035e3735e414acb26ae79a8cf55a562c89d01e8/

Testing previously affected platforms, powerpc does not fail anymore while building enlightenment on either uclibc-0.9.33.x or uclibc-ng, so re-enabling support for it.

The sparc build fails on other issues earlier in the build, so couldn't directly test enlightenment; probably the safe choice is leaving it as is.

The tests were run by using the config from the linked autobuild, changing platform, and running make enlightenment.

---
 package/enlightenment/enlightenment.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/enlightenment/enlightenment.mk +2 -2
index ddebe06..e8d6143 100644
@@ -29,8 +29,8 @@ ENLIGHTENMENT_CONF_OPTS = \
 	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
 	--disable-rpath
 
-# uClibc has an old incomplete sys/ptrace.h for powerpc & sparc
-ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
+# uClibc has an incomplete sys/ptrace.h for sparc and xtensa
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_sparc)$(BR2_xtensa),yy)
 ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
 endif
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 enlightenment: updating on which platforms ptrace is disabled

Hi Gergely,

Le 08/05/2015 16:46, Gergely Imreh a ?crit :

Quoted 5 lines

uclibc is missing definitions in sys/ptrace.h for certain plaforms. The xtensa platform is also affected (linked autobuild failure), fixed by disabling ptrace for that too. This choice of disabling ptrace for all uclibc choices is probably conservative: while uclibc-ng fails, uclibc Git Xstensa seeems to compile successfully.

What is the version of uclibc-ng ? did you try with the latest 1.0.2 ?

Quoted 6 lines

http://autobuild.buildroot.org/results/d03/d035e3735e414acb26ae79a8cf55a562c89d01e8/

Testing previously affected platforms, powerpc does not fail anymore while building enlightenment on either uclibc-0.9.33.x or uclibc-ng, so re-enabling support for it.

The powerpc issue has been fixed for Buildroot's internal toolchains by [1] but it's not for (old) external toolchains. However, an exception in autobuilders can be added for these toolchains.

Quoted 17 lines

The sparc build fails on other issues earlier in the build, so couldn't directly test enlightenment; probably the safe choice is leaving it as is.

The tests were run by using the config from the linked autobuild, changing platform, and running make enlightenment.

---
 package/enlightenment/enlightenment.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/enlightenment/enlightenment.mk +0 -0
index ddebe06..e8d6143 100644

package/enlightenment/enlightenment.mk ENLIGHTENMENT_CONF_OPTS = \ · line 33

Quoted 7 lines
package/enlightenment/enlightenment.mk +2 -2
@@ -29,8 +29,8 @@ ENLIGHTENMENT_CONF_OPTS = \
 	--with-eet-eet=$(HOST_DIR)/usr/bin/eet \
 	--disable-rpath
 
-# uClibc has an old incomplete sys/ptrace.h for powerpc & sparc
-ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_powerpc)$(BR2_sparc),yy)
+# uClibc has an incomplete sys/ptrace.h for sparc and xtensa
+ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC)$(BR2_sparc)$(BR2_xtensa),yy)

This change enable ptrace for powerpc and disable ptrace for xtensa. It would be good if it can be done in a separate patch.

Best regards,
Romain

[1]
http://git.buildroot.net/buildroot/commit/?id=e0a4d9fa6fa68b95181fbaf1babcbb3cf2c9c63b

Quoted 4 lines
package/enlightenment/enlightenment.mk +0 -0
 ENLIGHTENMENT_CONF_ENV += ac_cv_header_sys_ptrace_h=no
 endif