Skip to contentSkip to conversation

block:Add proper error checking to the function, add_disk

PATCH RESEND Jens Axboe 1 participant 1 message May 17, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jens Axboe

author
#1 lore raw
Quoted 7 lines · Nicholas Krause

This adds proper error checking and handling to the function, add_disk by changing the return from void to a int. In addition we also change various WARN_ON statements in this function to proper if statements that now return a error code if there condition arises during this function's run. Finally we change the function prototype in genhd.h to return an int now rather then void.

Nick, I'm not going to keep looking at these. It's quite clear you are out of your depth, hence the review to reward ratio (as a maintainer) is just too high. This is the 3rd iteration of this patch in a few days, all different, and no comments or version logs. So please stop fixing FIXME patches for the block are, thanks.

This message does not require a reply.

Signature · 1 line
Jens Axboe