mx6sabresd: Enable HDMI video in bootargs
PATCH 1/1 mx6sabresd: Enable HDMI video in bootargs
--- include/configs/mx6sabre_common.h | 7 ++++++- include/configs/mx6sabresd.h | 6 ++++++ 2 files changed, 12 insertions(+), 1 deletion(-)
include/configs/mx6sabre_common.h +6 -1
@@ -121,6 +121,10 @@#define EMMC_ENV ""#endif +#ifndef VIDEO_ARGS +#define VIDEO_ARGS "" +#endif +#define CONFIG_EXTRA_ENV_SETTINGS \ "script=boot.scr\0" \ "image=zImage\0" \
@@ -149,7 +153,8 @@"fi\0" \EMMC_ENV \"mmcargs=setenv bootargs console=${console},${baudrate} " \ -"root=${mmcroot}\0" \ +"root=${mmcroot} " \ +VIDEO_ARGS "\0" \"loadbootscript=" \"fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \"bootscript=echo Running bootscript from mmc ...; " \
include/configs/mx6sabresd.h +6 -0
@@ -31,6 +31,12 @@#define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ +#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \ + "video=mxcfb1:off " \ + "video=mxcfb2:off " \ + "video=mxcfb3:off " \ + "fbmem=28M" +#include "mx6sabre_common.h" #define CONFIG_SYS_FSL_USDHC_NUM 3
Signature · 1 line
1.7.10.4
PATCH 1/1 mx6sabresd: Enable HDMI video in bootargs
Hi Nikolay,
include/configs/mx6sabresd.h line 39
Quoted 6 lines · Nikolay Dimitrov
include/configs/mx6sabresd.h +6
-0+#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \ + "video=mxcfb1:off " \ + "video=mxcfb2:off " \ + "video=mxcfb3:off " \ + "fbmem=28M" +
This is too specific to the FSL kernel. For mainline kernel users, this is not needed and the strings would be different.
I would suggest you to patch this in Yocto instead.
Regards,
Fabio Estevam
PATCH 1/1 mx6sabresd: Enable HDMI video in bootargs
Hi Fabio,
Quoted 14 lines · Fabio Estevam
Hi Nikolay,
include/configs/mx6sabresd.h line 39
Quoted 6 lines · Nikolay Dimitrov
include/configs/mx6sabresd.h +6
-0+#define VIDEO_ARGS "video=mxcfb0:dev=hdmi,1280x720M at 60,if=RGB24 " \ + "video=mxcfb1:off " \ + "video=mxcfb2:off " \ + "video=mxcfb3:off " \ + "fbmem=28M" +This is too specific to the FSL kernel. For mainline kernel users, this is not needed and the strings would be different.
Quoted 1 line
I would suggest you to patch this in Yocto instead.
Thanks for your comments. I was thinking about what's the best way to approach this need, and last time we discussed similar topic, I was asked about upstreaming my changes... so here I am doing it.
Fixing it in u-boot-fslc or as a ad-hoc patch will also work for me.
Still - isn't the mainline kernel user expected to be able to use the HDMI interface of the board?
Regards,
Nikolay
PATCH 1/1 mx6sabresd: Enable HDMI video in bootargs
Hi Nikolay,
Quoted 2 lines · Nikolay Dimitrov
Still - isn't the mainline kernel user expected to be able to use the HDMI interface of the board?
Yes, and it works by default. No need to pass 'video=' arguments.
Regards,
Fabio Estevam
PATCH 1/1 mx6sabresd: Enable HDMI video in bootargs
Hi Fabio,
Quoted 8 lines · Fabio Estevam
Hi Nikolay,
Quoted 2 lines · Nikolay Dimitrov
Still - isn't the mainline kernel user expected to be able to use the HDMI interface of the board?
Yes, and it works by default. No need to pass 'video=' arguments.
I was just able to test it on Debian 8 armhf, and I can confirm it works.
@Stefano: Please discard my patch.
Kind regards,
Nikolay