ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

1/1

Pali Rohár
[email protected]
Pali Rohár
[email protected]
#ifdef CONFIG_ACPI
        /* In the event of an ACPI backlight being available, don't
         * register the platform controller.
         */
        if (acpi_video_backlight_support())
                return 0;
        /* no warning message if acpi_backlight=vendor or a quirk is used */
        if (!acpi_video_verify_backlight_support())
                return;
{
        if (acpi_osi_is_win8() && acpi_video_use_native_backlight() &&
            backlight_device_registered(BACKLIGHT_RAW))
                return false;
        return acpi_video_backlight_support();
}
#ifdef CONFIG_ACPI
        /* In the event of an ACPI backlight being available,
don't * register the platform controller.
         */
        if (acpi_video_backlight_support())
                return 0;
        /* no warning message if acpi_backlight=vendor or a
quirk is used */ if (!acpi_video_verify_backlight_support())
                return;
{
        if (acpi_osi_is_win8() &&
acpi_video_use_native_backlight() &&
backlight_device_registered(BACKLIGHT_RAW)) return false;
        return acpi_video_backlight_support();
}
{
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	else
		return use_native_backlight_dmi;
}
Pali Rohár
[email protected]
        /* In the event of an ACPI backlight being
        available,
         */
        
        if (acpi_video_backlight_support())
        
                return 0;
        /* no warning message if acpi_backlight=vendor or a
                return;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
{
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	else
		return use_native_backlight_dmi;
}
Pali Rohár
[email protected]
        /* In the event of an ACPI backlight being
        available,
         */
        
        if (acpi_video_backlight_support())
        
                return 0;
        /* no warning message if acpi_backlight=vendor or a
                return;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
{
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	else
		return use_native_backlight_dmi;
}
{
        if (acpi_osi_is_win8() && acpi_video_use_native_backlight() &&
            backlight_device_registered(BACKLIGHT_RAW))
                return false;
        return acpi_video_backlight_support();
}
        /* In the event of an ACPI backlight being
        available,
         */
        
        if (acpi_video_backlight_support())
        
                return 0;
        /* no warning message if acpi_backlight=vendor or
        a
                return;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	
	else
	
		return use_native_backlight_dmi;
{
        if (acpi_osi_is_win8() &&
acpi_video_use_native_backlight() &&
backlight_device_registered(BACKLIGHT_RAW)) return false;
        return acpi_video_backlight_support();
}
Pali Rohár
[email protected]
        /* In the event of an ACPI backlight being
        available,
         */
        
        if (acpi_video_backlight_support())
        
                return 0;
        /* no warning message if acpi_backlight=vendor or
        a
                return;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	
	else
	
		return use_native_backlight_dmi;
{
        if (acpi_osi_is_win8() &&
acpi_video_use_native_backlight() &&
backlight_device_registered(BACKLIGHT_RAW)) return false;
        return acpi_video_backlight_support();
}
#ifdef CONFIG_ACPI
        /* In the event of an ACPI backlight being available, don't
         * register the platform controller.
         */

        if (acpi_video_backlight_support())
                return 0;
        /* In the event of an ACPI backlight being
        available,
         */
        
        if (acpi_video_backlight_support())
        
                return 0;
        /* no warning message if acpi_backlight=vendor
        or a
                return;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
	if (use_native_backlight_param != -1)
		return use_native_backlight_param;
	
	else
	
		return use_native_backlight_dmi;
        if (acpi_osi_is_win8() &&
        return acpi_video_backlight_support();
#ifdef CONFIG_ACPI
        /* In the event of an ACPI backlight being available,
don't * register the platform controller.
         */

        if (acpi_video_backlight_support())
                return 0;
Pali Rohár
[email protected]
index ca52ad2ae7d1..15534345bd57 100644
@@ -396,6 +396,24 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * Some of the Thinkpads' firmware will issue a backlight change operation
+ * region request unconditionally on AC plug/unplug, this is undesirable and
+ * should be ignored. Then there is a Dell laptop whose vendor backlight
+ * interface also makes use of operation region request to change backlight
+ * level and we have to keep it work. The rule used here is: if the vendor
+ * backlight interface is not in use and the ACPI backlight interface is
+ * broken, we ignore the requests; oterwise, we keep processing them.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	if (acpi_video_backlight_support() &&
+	    !acpi_video_verify_backlight_support())
+		return true;
+
+	return false;
+}
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +422,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}

@@ -396,6 +396,24 @@ int intel_opregion_notify_adapter(struct
 drm_device *dev, pci_power_t state) return -EINVAL;
 }
 
+/*
+ * Some of the Thinkpads' firmware will issue a backlight

+static bool should_ignore_backlight_request(void)
+{
+	if (acpi_video_backlight_support() &&
+	    !acpi_video_verify_backlight_support())
+		return true;
+
+	return false;
+}
+
 static u32 asle_set_backlight(struct drm_device *dev, u32

 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +422,7 @@ static u32 asle_set_backlight(struct
 drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used,

-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}

Pali Rohár
[email protected]
---
 drivers/gpu/drm/i915/intel_opregion.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
index ca52ad2ae7d1..d8de1d5140a7 100644
@@ -396,6 +396,16 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * If the vendor backlight interface is not in use and ACPI backlight interface
+ * is broken, do not bother processing backlight change requests from firmware.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	return acpi_video_backlight_support() &&
+	       !acpi_video_verify_backlight_support();
+}
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +414,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}

1.9.3
---
 drivers/gpu/drm/i915/intel_opregion.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
index ca52ad2ae7d1..d8de1d5140a7 100644
@@ -396,6 +396,16 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * If the vendor backlight interface is not in use and ACPI backlight interface
+ * is broken, do not bother processing backlight change requests from firmware.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	return acpi_video_backlight_support() &&
+	       !acpi_video_verify_backlight_support();
+}
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +414,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
---
 drivers/gpu/drm/i915/intel_opregion.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)
index ca52ad2ae7d1..d8de1d5140a7 100644
@@ -396,6 +396,16 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * If the vendor backlight interface is not in use and ACPI backlight interface
+ * is broken, do not bother processing backlight change requests from firmware.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	return acpi_video_backlight_support() &&
+	       !acpi_video_verify_backlight_support();
+}
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +414,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
index ca52ad2ae7d1..15534345bd57 100644
@@ -396,6 +396,24 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * Some of the Thinkpads' firmware will issue a backlight change operation
+ * region request unconditionally on AC plug/unplug, this is undesirable and
+ * should be ignored. Then there is a Dell laptop whose vendor backlight
+ * interface also makes use of operation region request to change backlight
+ * level and we have to keep it work. The rule used here is: if the vendor
+ * backlight interface is not in use and the ACPI backlight interface is

+ * broken, we ignore the requests; oterwise, we keep processing them.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	if (acpi_video_backlight_support() &&
+	    !acpi_video_verify_backlight_support())
+		return true;
+
+	return false;
+}

	return acpi_video_backlight_support() && !acpi_video_verify_backlight_support();
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +422,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}
--

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
index ca52ad2ae7d1..15534345bd57 100644
@@ -396,6 +396,24 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
+/*
+ * Some of the Thinkpads' firmware will issue a backlight change operation
+ * region request unconditionally on AC plug/unplug, this is undesirable and
+ * should be ignored. Then there is a Dell laptop whose vendor backlight
+ * interface also makes use of operation region request to change backlight
+ * level and we have to keep it work. The rule used here is: if the vendor
+ * backlight interface is not in use and the ACPI backlight interface is

+ * broken, we ignore the requests; oterwise, we keep processing them.
+ */
+static bool should_ignore_backlight_request(void)
+{
+	if (acpi_video_backlight_support() &&
+	    !acpi_video_verify_backlight_support())
+		return true;
+
+	return false;
+}

	return acpi_video_backlight_support() && !acpi_video_verify_backlight_support();
+
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;

@@ -404,11 +422,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	/*
-	 * If the acpi_video interface is not supposed to be used, don't
-	 * bother processing backlight level change requests from firmware.
-	 */
-	if (!acpi_video_verify_backlight_support()) {
+	if (should_ignore_backlight_request()) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}
--


ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

Pali Rohár

Hans de Goede

Pali Rohár

Hans de Goede

Pali Rohár

Pali Rohár

Hans de Goede

Pali Rohár

Hans de Goede

Pali Rohár

Aaron Lu

Pali Rohár

Aaron Lu

Rafael J. Wysocki

Daniel Vetter

Rafael J. Wysocki

Aaron Lu