Skip to contentSkip to conversation

arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties

PATCH Applied Eugen Hristev 3 participants 5 messages Aug 14, 2023 – Dec 1, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties

dtbs_check throws a warning at the dsi node:
Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above.

If panel is deleted then the cells must also be deleted since they are tied together, as the child node in this DT does not have a reg.

Fixes cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +2 -0
index bf97b60ae4d1..649477af2f41 100644
@@ -91,6 +91,8 @@ cros_ec_pwm: pwm {
 
 &dsi0 {
 	status = "okay";
+	/delete-property/#size-cells;
+	/delete-property/#address-cells;
 	/delete-node/panel@0;
 	ports {
 		port {
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Il 14/08/23 09:10, Eugen Hristev ha scritto:

Quoted 7 lines

dtbs_check throws a warning at the dsi node:
Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above.

Quoted 5 lines

If panel is deleted then the cells must also be deleted since they are tied together, as the child node in this DT does not have a reg.

Fixes cabc71b08eb5 ("arm64: dts: mt8183: Add kukui-jacuzzi-damu board")
maintainer Applied
#2 lore raw
In reply to Eugen Hristev
Quoted 8 lines · Eugen Hristev

dtbs_check throws a warning at the dsi node:
Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above.

[...]

Applied, thanks!

[1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties

      commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa

Best regards,

Signature · 1 line
AngeloGioacchino Del Regno <[email protected]>
#3 lore raw
Quoted 11 lines · AngeloGioacchino Del Regno
Quoted 8 lines · Eugen Hristev

dtbs_check throws a warning at the dsi node:
Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above.

[...]

Quoted 8 lines

Applied, thanks!

[1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties

      commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa

You know, your SoB implies review. Unless you want to say you usually apply code without reviewing it...

Best regards,
Krzysztof

#4 lore raw

Il 30/11/23 10:01, Krzysztof Kozlowski ha scritto:

Quoted 18 lines · AngeloGioacchino Del Regno
Quoted 16 lines · Eugen Hristev
Quoted 8 lines

dtbs_check throws a warning at the dsi node:
Warning (avoid_unnecessary_addr_size): /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Other DTS have a panel child node with a reg, so the parent dtsi must have the address-cells and size-cells, however this specific DT has the panel removed, but not the cells, hence the warning above.

[...]

Applied, thanks!

[1/1] arm64: dts: mediatek: mt8183-kukui-jacuzzi: fix dsi unnecessary cells properties

       commit: 4b66a34afe29d991155081b2f1e10482bd00cbaa
Quoted 6 lines
Quoted 2 lines

You know, your SoB implies review. Unless you want to say you usually apply code without reviewing it...

Yeah, of course it does imply review ... but if there's no actual problem with me also sending a R-b tag, it's more practical for me, because:
1. I have mail filters to show me what I reviewed, and
2. Matthias also can see what I reviewed....

...but I get it that in the specific case of *this* patch, I've sent a R-b just before applying, so I agree in that this was actually really really useless to do.

so.. whoops :-)

Thanks, btw!
Angelo