Skip to contentSkip to conversation

coccinelle: irqf_oneshot.cocci: Improve the generated commit log

PATCH New Fabio Estevam 4 participants 4 messages May 24, 2015 – May 25, 2015 Coccinelle/Semantic Patches (SmPL)

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 coccinelle: irqf_oneshot.cocci: Improve the generated commit log

From: Fabio Estevam <[email protected]>

Improve the commit log of the generated patch by mentioning the commit log that makes threaded IRQs without a primary handler to be requested with the IRQF_ONESHOT flag.

Signed-off-by Fabio Estevam <[email protected]>
---
 scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/coccinelle/misc/irqf_oneshot.cocci +5 -2
index b17ac8b..b421150 100644
@@ -1,5 +1,8 @@
-/// Make sure threaded IRQs without a primary handler are always requested with
-/// IRQF_ONESHOT
+/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
+/// threaded IRQs without a primary handler need to be requested with
+/// IRQF_ONESHOT, otherwise the request will fail.
+///
+/// So pass the IRQF_ONESHOT flag in this case.
 ///
 //
 // Confidence: Good
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 coccinelle: irqf_oneshot.cocci: Improve the generated commit log

Valentin? (It's his semantic patch)

julia

Quoted 30 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Improve the commit log of the generated patch by mentioning the commit log that makes threaded IRQs without a primary handler to be requested with the IRQF_ONESHOT flag.

Signed-off-by Fabio Estevam <[email protected]>
---
 scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/coccinelle/misc/irqf_oneshot.cocci +5 -2
index b17ac8b..b421150 100644
@@ -1,5 +1,8 @@
-/// Make sure threaded IRQs without a primary handler are always requested with
-/// IRQF_ONESHOT
+/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
+/// threaded IRQs without a primary handler need to be requested with
+/// IRQF_ONESHOT, otherwise the request will fail.
+///
+/// So pass the IRQF_ONESHOT flag in this case.
 ///
 //
 // Confidence: Good
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 coccinelle: irqf_oneshot.cocci: Improve the generated commit log

Quoted 28 lines · Julia Lawall

Valentin? (It's his semantic patch)

julia

Quoted 22 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Improve the commit log of the generated patch by mentioning the commit log that makes threaded IRQs without a primary handler to be requested with the IRQF_ONESHOT flag.

Signed-off-by Fabio Estevam <[email protected]>
---
 scripts/coccinelle/misc/irqf_oneshot.cocci | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
scripts/coccinelle/misc/irqf_oneshot.cocci +4 -2
index b17ac8b..b421150 100644
@@ -1,5 +1,8 @@
-/// Make sure threaded IRQs without a primary handler are always requested with
-/// IRQF_ONESHOT
+/// Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
+/// threaded IRQs without a primary handler need to be requested with
+/// IRQF_ONESHOT, otherwise the request will fail.
+///
Quoted 8 lines
Quoted 8 lines
scripts/coccinelle/misc/irqf_oneshot.cocci +1 -1
+/// So pass the IRQF_ONESHOT flag in this case.
 ///
 //
 // Confidence: Good
--

1.9.1

Acked- by: Valentin Rothberg <[email protected]>

Kind regards,
Valentin

#3 lore raw

PATCH 1/1 coccinelle: irqf_oneshot.cocci: Improve the generated commit log

Dne 25.5.2015 v 14:30 Valentin Rothberg napsal(a):

Quoted 7 lines · Julia Lawall
Quoted 6 lines

Valentin? (It's his semantic patch)

julia

On Sun, 24 May 2015, Fabio Estevam wrote:

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

From: Fabio Estevam <[email protected]>

Improve the commit log of the generated patch by mentioning the commit log that makes threaded IRQs without a primary handler to be requested with the IRQF_ONESHOT flag.

Signed-off-by Fabio Estevam <[email protected]>

Acked- by: Valentin Rothberg <[email protected]>

Thanks, applied to kbuild.git#misc.

Michal