Skip to contentSkip to conversation

ARM: dts: Update video-phy node with syscon phandle for Exynos3250

PATCH New Beata Michalska 4 participants 6 messages Mar 19, 2015 – May 26, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

---
 arch/arm/boot/dts/exynos3250.dtsi |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/exynos3250.dtsi +1 -0
index ac6b0ae..6c89670 100644
@@ -137,6 +137,7 @@
 			compatible = "samsung,s5pv210-mipi-video-phy";
 			reg = <0x10020710 8>;
 			#phy-cells = <1>;
+			syscon = <&pmu_system_controller>;
 		};
 
 		pd_cam: cam-power-domain at 10023C00 {
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

2015-03-19 19:56 GMT+09:00 Beata Michalska <[email protected]>:

Quoted 8 lines

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

Tested on Gear 2 (Exynos3250) board.

I'll queue it and send later to Kukjin.

Best regards,
Krzysztof

#2 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <[email protected]>:

Quoted 8 lines

2015-03-19 19:56 GMT+09:00 Beata Michalska <[email protected]>:

Quoted 7 lines

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

Quoted 6 lines
Quoted 1 line

Tested on Gear 2 (Exynos3250) board.

Oh, I was too fast. It seems that "reg" property is not needed anymore. Can you remove it?

Best regards,
Krzysztof

#3 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

Quoted 11 lines · Krzysztof Kozlowski

2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <[email protected]>:

Quoted 10 lines

2015-03-19 19:56 GMT+09:00 Beata Michalska <[email protected]>:

Quoted 8 lines

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

Quoted 8 lines
Quoted 4 lines

Tested on Gear 2 (Exynos3250) board.

Oh, I was too fast. It seems that "reg" property is not needed anymore. Can you remove it?

After removing the reg property as Krzysztof suggested.

Best regards,
Javier

#4 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

Quoted 18 lines · Javier Martinez Canillas
Quoted 16 lines · Krzysztof Kozlowski

2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <[email protected]>:

Quoted 14 lines

2015-03-19 19:56 GMT+09:00 Beata Michalska <[email protected]>:

Quoted 8 lines

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

Tested on Gear 2 (Exynos3250) board.

Quoted 8 lines
Quoted 3 lines

Oh, I was too fast. It seems that "reg" property is not needed anymore. Can you remove it?

After removing the reg property as Krzysztof suggested.

will apply with changing as per you guys' review comment ;-)

Thanks,
Kukjin

#5 lore raw

PATCH 1/1 ARM: dts: Update video-phy node with syscon phandle for Exynos3250

Hi,

Quoted 23 lines · Kukjin Kim
Quoted 22 lines · Javier Martinez Canillas
Quoted 19 lines · Krzysztof Kozlowski

2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <[email protected]>:

Quoted 8 lines

2015-03-19 19:56 GMT+09:00 Beata Michalska <[email protected]>:

Quoted 7 lines

As a follow-up to recent changes to Exynos mipi video phy driver, introducing support for PMU regmap in commit e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression by adding support for PMU regmap") add a syscon phandle to video-phy node to bring back to life both MIPI DSI displays and MIPI CSIS-2 camera sensors on Exynos3250.

Quoted 6 lines
Quoted 1 line

Tested on Gear 2 (Exynos3250) board.

Oh, I was too fast. It seems that "reg" property is not needed anymore. Can you remove it?

Quoted 9 lines
Quoted 4 lines

After removing the reg property as Krzysztof suggested.

will apply with changing as per you guys' review comment ;-)

Thanks,
Kukjin

Apologies for not jumping in earlier, but I've been away for a while, with basically no e-mail access. Would You like me to resend the patch with the 'reg' property removed or will You handle it while applying the change ?

Best Regards
Beata