serial: samsung: only use earlycon for console
Subsystems (2)
PATCH 1/1 serial: samsung: only use earlycon for console
A configuration that enables earlycon but not the core console code causes a link error:
drivers/built-in.o: In function `setup_earlycon':
drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
That error can be triggered by the newly added samsung earlycon support, which is missing a 'select' statement.
As suggested by Peter Hurley, solves the problem by moving the 'select SERIAL_EARLYCON' statement to the samsung console driver option, as it is done by all other console drivers.
drivers/tty/serial/Kconfig +1 -1
@@ -241,7 +241,6 @@ config SERIAL_SAMSUNG tristate "Samsung SoC serial support" depends on PLAT_SAMSUNG || ARCH_EXYNOS select SERIAL_CORE - select SERIAL_EARLYCON help Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, providing /dev/ttySAC0, 1 and 2 (note, some machines may not
@@ -277,6 +276,7 @@ config SERIAL_SAMSUNG_CONSOLE bool "Support for console on Samsung SoC serial port" depends on SERIAL_SAMSUNG=y select SERIAL_CORE_CONSOLE + select SERIAL_EARLYCON help Allow selection of the S3C24XX on-board serial ports for use as an virtual console.
PATCH 1/1 serial: samsung: only use earlycon for console
Quoted 6 lines · Arnd Bergmann
A configuration that enables earlycon but not the core console code causes a link error:
drivers/built-in.o: In function `setup_earlycon':
drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
Quoted 6 lines
That error can be triggered by the newly added samsung earlycon support, which is missing a 'select' statement.
As suggested by Peter Hurley, solves the problem by moving the 'select
SERIAL_EARLYCON' statement to the samsung console driver option, as it is done by all other console drivers.
Thanks.