pci: imx: display message if no pcie link

PATCH In review Tim Harvey 4 participants 8 messages May 8, 2015 – May 28, 2015

Subsystems (2)

Arm i.MX and Layerscape PCI

lore

Share & tools

lore

Tim Harvey

author

2015-05-08 22:17 UTC #0 lore raw

PATCH 1/1 pci: imx: display message if no pcie link

If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.

Signed-off-by Tim Harvey <[email protected]>

---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/pci/pcie_imx.c +3 -1

index fd7e4d4..ca485ba 100644
@@ -588,7 +588,9 @@ static int imx_pcie_link_up(void)
 		udelay(10);
 		count++;
 		if (count >= 2000) {
-			debug("phy link never came up\n");
+#ifdef CONFIG_PCI_SCAN_SHOW
+			puts("PCI:   pcie phy link never came up\n");
+#endif
 			debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
 			      readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0),
 			      readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));

Signature · 1 line

1.9.1

Scott Wood

2015-05-22 20:50 UTC #1 lore raw

Quoted 7 lines · Tim Harvey

If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by Tim Harvey <[email protected]>
---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?

-Scott

Tim Harvey

author

2015-05-22 21:17 UTC #2 lore raw

Quoted 9 lines · Scott Wood

Quoted 7 lines · Tim Harvey
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by Tim Harvey <[email protected]>
---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Quoted 4 lines

Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
-Scott

Scott,

Just lucky I guess ;P

Who is the right person to send this to? If a subsection doesn't have a clear maintainer like drivers/pci would it be Tom?

Tim

Tom Rini

2015-05-22 21:26 UTC #3 lore raw

In reply to Scott Wood

Quoted 11 lines · Scott Wood

Quoted 7 lines · Tim Harvey
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by Tim Harvey <[email protected]>
---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?

I probably typo'd "sb" as "sc" when doing my triage. Did you have any other imx related patches by chance?

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150522/3da0ff0c/attachment.sig>

Scott Wood

2015-05-22 21:38 UTC #4 lore raw

Quoted 10 lines · Tom Rini

Quoted 9 lines · Scott Wood
Quoted 7 lines · Tim Harvey
If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by Tim Harvey <[email protected]>
---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Quoted 5 lines

Quoted 2 lines
Why was this and another PCI patch assigned to me in patchwork (I've since cleared the delegation)?
I probably typo'd "sb" as "sc" when doing my triage. Did you have any other imx related patches by chance?

Just the two PCI patches and some SPI MTD patches.

-Scott

Tim Harvey

author

2015-05-27 13:21 UTC #5 lore raw

PATCH 1/1 pci: imx: display message if no pcie link

In reply to Tim Harvey

Quoted 24 lines · Tim Harvey

If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.

Signed-off-by Tim Harvey <[email protected]>

---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/pci/pcie_imx.c +3 -2

index fd7e4d4..ca485ba 100644
@@ -588,7 +588,9 @@ static int imx_pcie_link_up(void)
                udelay(10);
                count++;
                if (count >= 2000) {
-                       debug("phy link never came up\n");
+#ifdef CONFIG_PCI_SCAN_SHOW
+                       puts("PCI:   pcie phy link never came up\n");
+#endif
                        debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
                              readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0),
                              readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));
--

Quoted 2 lines

1.9.1

Stefano,

I probably should have sent this one to you directly being an imx driver.

Regards,

Tim

Stefano Babic

2015-05-27 13:30 UTC #6 lore raw

PATCH 1/1 pci: imx: display message if no pcie link

Hi Tim,

Quoted 30 lines · Tim Harvey

Quoted 24 lines · Tim Harvey

If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.

Signed-off-by Tim Harvey <[email protected]>

---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/pci/pcie_imx.c +3 -2

index fd7e4d4..ca485ba 100644
@@ -588,7 +588,9 @@ static int imx_pcie_link_up(void)
                udelay(10);
                count++;
                if (count >= 2000) {
-                       debug("phy link never came up\n");
+#ifdef CONFIG_PCI_SCAN_SHOW
+                       puts("PCI:   pcie phy link never came up\n");
+#endif
                        debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
                              readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0),
                              readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));
--

Quoted 2 lines

1.9.1

Stefano,

Quoted 2 lines

I probably should have sent this one to you directly being an imx driver.

I have seen the patch and the related discussion who should take care of it ;-)

Do not worry - I set myself as delegate for this and I will merge it soon.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2015-05-28 09:45 UTC #7 lore raw

PATCH 1/1 pci: imx: display message if no pcie link

In reply to Tim Harvey

Quoted 14 lines · Tim Harvey

If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was detected.
Signed-off-by Tim Harvey <[email protected]>
---
 drivers/pci/pcie_imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pci/pcie_imx.c +0 -0
index fd7e4d4..ca485ba 100644

drivers/pci/pcie_imx.c static int imx_pcie_link_up(void) · line 596

Quoted 10 lines

drivers/pci/pcie_imx.c +3 -1

@@ -588,7 +588,9 @@ static int imx_pcie_link_up(void)
 		udelay(10);
 		count++;
 		if (count >= 2000) {
-			debug("phy link never came up\n");
+#ifdef CONFIG_PCI_SCAN_SHOW
+			puts("PCI:   pcie phy link never came up\n");
+#endif
 			debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
 			      readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0),
 			      readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================