imx: missing CONFIG_NET after consolidation patches

PATCH New Stefano Babic 5 participants 14 messages May 27, 2015 – Jun 2, 2015

Share & tools

Stefano Babic

author

2015-05-27 09:29 UTC #0 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.

=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive

Setting CONFIG_NET solves this issue.

Reported-by Heiko Schoker <[email protected]>

Signed-off-by Stefano Babic <[email protected]>

---
 include/configs/mx6_common.h | 3 +++
 1 file changed, 3 insertions(+)

include/configs/mx6_common.h +3 -0

index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
 #define CONFIG_FSL_ESDHC
 #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET
+
 #endif

Signature · 1 line

1.9.1

Heiko Schocher

2015-05-28 05:28 UTC #1 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hello Stefano,

Am 27.05.2015 11:29, schrieb Stefano Babic:

Quoted 12 lines

commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive

Quoted 3 lines

Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>

s/ok/och ;-)

Quoted 4 lines

Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)

Thanks!

bye,
Heiko

Quoted 14 lines

include/configs/mx6_common.h +3 -0

index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET
+
  #endif

Signature · 2 lines

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Joe Hershberger

2015-05-28 17:53 UTC #2 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

In reply to Stefano Babic

Hi Stefano,

Quoted 25 lines · Stefano Babic

commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
 include/configs/mx6_common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644

include/configs/mx6_common.h line 109

Quoted 5 lines

include/configs/mx6_common.h +2 -0

@@ -105,4 +105,7 @@
 #define CONFIG_FSL_ESDHC
 #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET

This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig

Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900

Apparently some of the boards that supported NET previously were not properly added to their defconfigs.

In any case, for this board, you should add the NET config to the defconfig, not the header.

include/configs/mx6_common.h line 110

Quoted 1 line

include/configs/mx6_common.h +0 -0
 #endif

Thanks,
-Joe

Bin Meng

2015-05-29 02:33 UTC #3 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi Joe,

Quoted 31 lines · Joe Hershberger

Hi Stefano,
Quoted 28 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
 include/configs/mx6_common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
 #define CONFIG_FSL_ESDHC
 #define CONFIG_FSL_USDHC
 

Quoted 6 lines

include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig

Looks CONFIG_NET was added by commit ed36323

commit ed36323f6d217050f82a2200475959b8557a47e4

Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900

kconfig: add blank Kconfig files

Quoted 11 lines

Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 1 line
include/configs/mx6_common.h +0 -0
 #endif

But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.

Regards,
Bin

Heiko Schocher

2015-05-29 05:19 UTC #4 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hello Bin,

Am 29.05.2015 04:33, schrieb Bin Meng:

Quoted 59 lines

Hi Joe,
Quoted 31 lines · Joe Hershberger
Hi Stefano,
Quoted 28 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 6 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.

Quoted 6 lines

Quoted 2 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.

Reason is the following commit:

commit fd3056337e6fcc140f400e11edd33f6f1cb37de1

Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500

net: Use env callbacks for net variables

if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Bin Meng

2015-05-29 07:16 UTC #5 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi Heiko,

Quoted 79 lines · Heiko Schocher

Hello Bin,
Am 29.05.2015 04:33, schrieb Bin Meng:
Quoted 64 lines
Hi Joe,
Quoted 33 lines · Joe Hershberger
Hi Stefano,
Quoted 29 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 7 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 7 lines
Quoted 3 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.
Reason is the following commit:

Quoted 8 lines

commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500
net: Use env callbacks for net variables
if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...

Ah, yes! I was confused by Joe's comments regarding to CONFIG_NET being the cause of this.

My understanding is that since we already introduced CONFIG_NET, we should not have these network commands (ping, tftp) built in if CONFIG_NET is not there. Looks CONFIG_NET is only used in NET_CALLBACKS. Is CONFIG_NET really necessary here?

+#ifdef CONFIG_NET
+#define NET_CALLBACKS \

+       "bootfile:bootfile," \
+       "ipaddr:ipaddr," \
+       "gatewayip:gatewayip," \
+       "netmask:netmask," \
+       "serverip:serverip," \
+       "nvlan:nvlan," \
+       "vlan:vlan," \
+       DNS_CALLBACK

+#else
+#define NET_CALLBACKS
+#endif

Regards,
Bin

Joe Hershberger

2015-05-29 07:43 UTC #6 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi Bin,

Quoted 91 lines · Bin Meng

Hi Heiko,
Quoted 79 lines · Heiko Schocher
Hello Bin,
Am 29.05.2015 04:33, schrieb Bin Meng:
Quoted 64 lines
Hi Joe,
Quoted 33 lines · Joe Hershberger
Hi Stefano,
Quoted 29 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 7 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 7 lines
Quoted 3 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.
Reason is the following commit:
Quoted 8 lines
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500
net: Use env callbacks for net variables
if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...

Quoted 6 lines

Ah, yes! I was confused by Joe's comments regarding to CONFIG_NET being the cause of this.
My understanding is that since we already introduced CONFIG_NET, we should not have these network commands (ping, tftp) built in if CONFIG_NET is not there.

I think you are thinking of CONFIG_CMD_NET... if it is not defined, then you will not have those commands. We are in a transitional period and all of the NET features vs. the commands are not using the new / appropriate configs yet. Many are not properly moved over to Kconfig. We'll get there, but this change to Kconfig is fairly incomplete.

Quoted 2 lines

Looks CONFIG_NET is only used in NET_CALLBACKS. Is CONFIG_NET really necessary here?

Yes... well either CONFIG_NET or CONFIG_CMD_NET. They should be basically equivalent.

Review

Quoted 13 lines

(quoted diff) +13 -0

+#ifdef CONFIG_NET
+#define NET_CALLBACKS \
+       "bootfile:bootfile," \
+       "ipaddr:ipaddr," \
+       "gatewayip:gatewayip," \
+       "netmask:netmask," \
+       "serverip:serverip," \
+       "nvlan:nvlan," \
+       "vlan:vlan," \
+       DNS_CALLBACK
+#else
+#define NET_CALLBACKS
+#endif

Cheers,
-Joe

Simon Glass

2015-06-01 17:14 UTC #7 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi,

Quoted 107 lines · Joe Hershberger

Hi Bin,
Quoted 91 lines · Bin Meng
Hi Heiko,
Quoted 79 lines · Heiko Schocher
Hello Bin,
Am 29.05.2015 04:33, schrieb Bin Meng:
Quoted 64 lines
Hi Joe,
Quoted 33 lines · Joe Hershberger
Hi Stefano,
Quoted 29 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 7 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 7 lines
Quoted 3 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.
Reason is the following commit:
Quoted 8 lines
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500
net: Use env callbacks for net variables
if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...
Quoted 6 lines
Ah, yes! I was confused by Joe's comments regarding to CONFIG_NET being the cause of this.
My understanding is that since we already introduced CONFIG_NET, we should not have these network commands (ping, tftp) built in if CONFIG_NET is not there.
I think you are thinking of CONFIG_CMD_NET... if it is not defined, then you will not have those commands. We are in a transitional period and all of the NET features vs. the commands are not using the new / appropriate configs yet. Many are not properly moved over to Kconfig. We'll get there, but this change to Kconfig is fairly incomplete.

Quoted 5 lines

Quoted 2 lines
Looks CONFIG_NET is only used in NET_CALLBACKS. Is CONFIG_NET really necessary here?
Yes... well either CONFIG_NET or CONFIG_CMD_NET. They should be basically equivalent.

Any ideas on how to resolving this?

Regards,
Simon

Joe Hershberger

2015-06-01 17:17 UTC #8 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi Simon,

Quoted 110 lines · Simon Glass

Hi,
Quoted 107 lines · Joe Hershberger
Hi Bin,
Quoted 91 lines · Bin Meng
Hi Heiko,
Quoted 79 lines · Heiko Schocher
Hello Bin,
Am 29.05.2015 04:33, schrieb Bin Meng:
Quoted 64 lines
Hi Joe,
Quoted 33 lines · Joe Hershberger
Hi Stefano,
Quoted 29 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 7 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 7 lines
Quoted 3 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.
Reason is the following commit:
Quoted 8 lines
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500
net: Use env callbacks for net variables
if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...
Quoted 6 lines
Ah, yes! I was confused by Joe's comments regarding to CONFIG_NET being the cause of this.
My understanding is that since we already introduced CONFIG_NET, we should not have these network commands (ping, tftp) built in if CONFIG_NET is not there.
I think you are thinking of CONFIG_CMD_NET... if it is not defined, then you will not have those commands. We are in a transitional period and all of the NET features vs. the commands are not using the new / appropriate configs yet. Many are not properly moved over to Kconfig. We'll get there, but this change to Kconfig is fairly incomplete.

Quoted 7 lines

Quoted 5 lines
Quoted 2 lines
Looks CONFIG_NET is only used in NET_CALLBACKS. Is CONFIG_NET really necessary here?
Yes... well either CONFIG_NET or CONFIG_CMD_NET. They should be basically equivalent.
Any ideas on how to resolving this?

Sorry, forgot Cc's on this. Here's the patch:
https://patchwork.ozlabs.org/patch/478414/

Michal wants a subject change. I have a new version, but I think I'm gonna just push it to u-boot-net.git and send a pull request since the patches are so big.

Cheers,
-Joe

Bin Meng

2015-06-02 00:41 UTC #9 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

In reply to Simon Glass

Hi Simon,

Quoted 110 lines · Simon Glass

Hi,
Quoted 107 lines · Joe Hershberger
Hi Bin,
Quoted 91 lines · Bin Meng
Hi Heiko,
Quoted 79 lines · Heiko Schocher
Hello Bin,
Am 29.05.2015 04:33, schrieb Bin Meng:
Quoted 64 lines
Hi Joe,
Quoted 33 lines · Joe Hershberger
Hi Stefano,
Quoted 29 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
Quoted 7 lines
include/configs/mx6_common.h line 109
Quoted 2 lines
include/configs/mx6_common.h +2 -0
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Looks CONFIG_NET was added by commit ed36323
commit ed36323f6d217050f82a2200475959b8557a47e4
Author: Masahiro Yamada <[email protected]>
Date:   Tue Sep 16 16:32:58 2014 +0900
kconfig: add blank Kconfig files
Quoted 9 lines
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.
Quoted 7 lines
Quoted 3 lines
include/configs/mx6_common.h line 110
Quoted 1 line
include/configs/mx6_common.h +0 -0
  #endif
But I failed to understand why adding CONFIG_NET could resolve the "*** ERROR: `ipaddr" not set' problem. A grep of "^CONFIG_NET" gives me nothing helpful.
Reason is the following commit:
Quoted 8 lines
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1
Author: Joe Hershberger <[email protected]>
Date:   Wed May 20 14:27:23 2015 -0500
net: Use env callbacks for net variables
if CONFIG_NET is not defined, NET_CALLBACKS is empty, which results in the above error message ...
Quoted 6 lines
Ah, yes! I was confused by Joe's comments regarding to CONFIG_NET being the cause of this.
My understanding is that since we already introduced CONFIG_NET, we should not have these network commands (ping, tftp) built in if CONFIG_NET is not there.
I think you are thinking of CONFIG_CMD_NET... if it is not defined, then you will not have those commands. We are in a transitional period and all of the NET features vs. the commands are not using the new / appropriate configs yet. Many are not properly moved over to Kconfig. We'll get there, but this change to Kconfig is fairly incomplete.

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Looks CONFIG_NET is only used in NET_CALLBACKS. Is CONFIG_NET really necessary here?
Yes... well either CONFIG_NET or CONFIG_CMD_NET. They should be basically equivalent.
Any ideas on how to resolving this?

I will send a patch doing the same fix that Joe did on the qemu-x86 soon.

Regards,
Bin

Heiko Schocher

2015-05-29 05:28 UTC #10 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

In reply to Joe Hershberger

Hello Joe,

Am 28.05.2015 19:53, schrieb Joe Hershberger:

Quoted 36 lines

Hi Stefano,
Quoted 25 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
include/configs/mx6_common.h line 109
Quoted 5 lines
include/configs/mx6_common.h +2 -0
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig

Quoted 8 lines

Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
In any case, for this board, you should add the NET config to the defconfig, not the header.

Hmm.. this seems missing for all imx boards ...

$ grep -lr CONFIG_NET configs | xargs grep MX
$

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Joe Hershberger

2015-05-29 06:09 UTC #11 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hi Heiko,

Quoted 49 lines · Heiko Schocher

Hello Joe,
Am 28.05.2015 19:53, schrieb Joe Hershberger:
Quoted 45 lines
Hi Stefano,
Quoted 26 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
  include/configs/mx6_common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
include/configs/mx6_common.h line 109
Quoted 5 lines
include/configs/mx6_common.h +2 -0
@@ -105,4 +105,7 @@
  #define CONFIG_FSL_ESDHC
  #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.

Quoted 7 lines

Quoted 2 lines
In any case, for this board, you should add the NET config to the defconfig, not the header.
Hmm.. this seems missing for all imx boards ...
$ grep -lr CONFIG_NET configs | xargs grep MX

It seems that in ed36323f, Masahiro added the CONFIG_NET config to Kconfig, but most things depended on (and defined) CONFIG_CMD_NET, which he added to Kconfig in 60296a8. In both cases, none of the boards had either CONFIG_CMD_NET or CONFIG_NET moved to defconfigs. As a result most boards are lacking complete networking support except those that happen to have been touched for other reasons related to networking (such as the CONFIG_NET_RANDOM_ETHADDR patch).

This is made worse by the fact that I used CONFIG_NET (the one missing in far more boards) in the fd30563 commit.

I will work up a patch that addresses this and restores networking to all boards that formerly supported networking. Expect it tomorrow or so.

Cheers,
-Joe

Heiko Schocher

2015-05-29 06:15 UTC #12 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

Hello Joe,

Am 29.05.2015 08:09, schrieb Joe Hershberger:

Quoted 68 lines

Hi Heiko,
Quoted 49 lines · Heiko Schocher
Hello Joe,
Am 28.05.2015 19:53, schrieb Joe Hershberger:
Quoted 45 lines
Hi Stefano,
Quoted 26 lines · Stefano Babic
commit fd3056337e6fcc140f400e11edd33f6f1cb37de1 "Use env callbacks for net variables" has a side effect on i.MX6 boards because they do not set CONFIG_NET:
the ip address results not set, but it is stored in the environment.
=> pri ipaddr
ipaddr=192.168.178.66
=> ping 192.168.178.1
*** ERROR: `ipaddr' not set
ping failed; host 192.168.178.1 is not alive
Setting CONFIG_NET solves this issue.
Reported-by Heiko Schoker <[email protected]>
Signed-off-by Stefano Babic <[email protected]>
---
   include/configs/mx6_common.h | 3 +++
   1 file changed, 3 insertions(+)
include/configs/mx6_common.h +0 -0
index 233c6d2..3d859cf 100644
include/configs/mx6_common.h line 109
Quoted 5 lines
include/configs/mx6_common.h +2 -0
@@ -105,4 +105,7 @@
   #define CONFIG_FSL_ESDHC
   #define CONFIG_FSL_USDHC
 
+/* NET */
+#define CONFIG_NET
This config was added to Kconfig here:
60296a8 commands: add more command entries in Kconfig
Author: Masahiro Yamada <[email protected]>
Date:   Thu Nov 13 19:29:08 2014 +0900
Apparently some of the boards that supported NET previously were not properly added to their defconfigs.
Quoted 7 lines
Quoted 2 lines
In any case, for this board, you should add the NET config to the defconfig, not the header.
Hmm.. this seems missing for all imx boards ...
$ grep -lr CONFIG_NET configs | xargs grep MX
It seems that in ed36323f, Masahiro added the CONFIG_NET config to Kconfig, but most things depended on (and defined) CONFIG_CMD_NET, which he added to Kconfig in 60296a8. In both cases, none of the boards had either CONFIG_CMD_NET or CONFIG_NET moved to defconfigs. As a result most boards are lacking complete networking support except those that happen to have been touched for other reasons related to networking (such as the CONFIG_NET_RANDOM_ETHADDR patch).

Quoted 2 lines

This is made worse by the fact that I used CONFIG_NET (the one missing in far more boards) in the fd30563 commit.

Uh..

Quoted 3 lines

I will work up a patch that addresses this and restores networking to all boards that formerly supported networking. Expect it tomorrow or so.

Ok, thanks!

bye,
Heiko

Signature · 2 lines

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Stefano Babic

author

2015-05-29 07:31 UTC #13 lore raw

PATCH 1/1 imx: missing CONFIG_NET after consolidation patches

In reply to Joe Hershberger

Hi Joe,

Quoted 11 lines · Joe Hershberger

Quoted 3 lines
Hmm.. this seems missing for all imx boards ...
$ grep -lr CONFIG_NET configs | xargs grep MX
It seems that in ed36323f, Masahiro added the CONFIG_NET config to Kconfig, but most things depended on (and defined) CONFIG_CMD_NET, which he added to Kconfig in 60296a8. In both cases, none of the boards had either CONFIG_CMD_NET or CONFIG_NET moved to defconfigs. As a result most boards are lacking complete networking support except those that happen to have been touched for other reasons related to networking (such as the CONFIG_NET_RANDOM_ETHADDR patch).

ok, got it.

Quoted 7 lines

This is made worse by the fact that I used CONFIG_NET (the one missing in far more boards) in the fd30563 commit.
I will work up a patch that addresses this and restores networking to all boards that formerly supported networking. Expect it tomorrow or so.

Thanks !

Best regards,
Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================