[0905_14] Siano: USB - move the device id table to the cards module
Quoted 22 lines · Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <[email protected]>
Subject: Re: [PATCH] [0905_14] Siano: USB - move the device id table to the cards module
To: "Uri Shkolnik" <[email protected]>
Cc: "LinuxML" <[email protected]>
Date: Monday, May 18, 2009, 9:41 AM
Em Thu, 14 May 2009 12:29:35 -0700
(PDT)
Uri Shkolnik <[email protected]>
escreveu:The idea of moving it to
sms-cards.cis interesting, however, I don't think
this will work fine, since having the usb probing code at one module and the
table on another will break for udev.Also, by applying this patch, module loader would be broken:
WARNING: "
smsusb_id_table" [/home/v4l/master/v4l/smsusb.ko] undefined!
Quoted 9 lines
I can see a few alternatives:
1) keep as-is;
2) move usb init code to sms-cards;
3) break sms-cards into smaller files, like sms-cards-usb (for usb devices);
4) having the table declared as static into some header file.
Mauro,
That patch has been suppressed by me @ the patchwork shortly after I submit it.
The ID tables (for USB and for SDIO) devices will remain in their corresponding interfaces drivers.
The cards/targets will keep to be managed by board ID (sms-cards.h), no need to further break the sms-cards to mini-modules, there is nothing to gain with that architecture.
10x,
Uri