Skip to contentSkip to conversation

net: Fix NET_RANDOM_ETHADDR dependencies

PATCH New Michal Simek 2 participants 5 messages May 25, 2015 – Jun 1, 2015

Subsystems (2)
Networking Library code
lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 net: Fix NET_RANDOM_ETHADDR dependencies

NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to Kconfig to ensure that library is also compiled.

Signed-off-by Michal Simek <[email protected]>

---

 lib/Kconfig | 3 +++
 net/Kconfig | 1 +
 2 files changed, 4 insertions(+)
lib/Kconfig +3 -0
index 5b6cf3d68df1..3c8de869b1f6 100644
@@ -44,6 +44,9 @@ config REGEX
 	  regex support to some commands, for example "env grep" and
 	  "setexpr".
 
+config LIB_RAND
+	bool
+
 source lib/rsa/Kconfig
 
 menu "Hashing Support"
net/Kconfig +1 -0
index 524b7e4da23b..9a9846e18744 100644
@@ -10,6 +10,7 @@ if NET
 
 config NET_RANDOM_ETHADDR
 	bool "Random ethaddr if unset"
+	select LIB_RAND
 	help
 	  Selecting this will allow the Ethernet interface to function
 	  even when the ethaddr variable for that interface is unset.
Signature · 1 line
2.3.5
#3 lore raw

PATCH 1/1 net: Fix NET_RANDOM_ETHADDR dependencies

In reply to Michal Simek

Hi Michal,

Quoted 29 lines · Michal Simek

NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to Kconfig to ensure that library is also compiled.

Signed-off-by Michal Simek <[email protected]>

---

 lib/Kconfig | 3 +++
 net/Kconfig | 1 +
 2 files changed, 4 insertions(+)
lib/Kconfig +3 -0
index 5b6cf3d68df1..3c8de869b1f6 100644
@@ -44,6 +44,9 @@ config REGEX
          regex support to some commands, for example "env grep" and
          "setexpr".
 
+config LIB_RAND
+       bool
+
 source lib/rsa/Kconfig
 
 menu "Hashing Support"
net/Kconfig +0 -0
index 524b7e4da23b..9a9846e18744 100644

net/Kconfig if NET · line 16

Quoted 7 lines
net/Kconfig +1 -0
@@ -10,6 +10,7 @@ if NET
 
 config NET_RANDOM_ETHADDR
        bool "Random ethaddr if unset"
+       select LIB_RAND
        help
          Selecting this will allow the Ethernet interface to function
          even when the ethaddr variable for that interface is unset.

Do you want me to run the moveconfig tool on this? I have a feeling it will just conflict anyway if not run on top of my other 2 patches for the defconfigs.

Cheers,
-Joe

author
#4 lore raw

PATCH 1/1 net: Fix NET_RANDOM_ETHADDR dependencies

Quoted 33 lines · Joe Hershberger

Hi Michal,

Quoted 30 lines · Michal Simek

NET_RANDOM_ETHADDR depends on lib/rand.c. This patch adds dependency to Kconfig to ensure that library is also compiled.

Signed-off-by Michal Simek <[email protected]>

---

 lib/Kconfig | 3 +++
 net/Kconfig | 1 +
 2 files changed, 4 insertions(+)
lib/Kconfig +3 -0
index 5b6cf3d68df1..3c8de869b1f6 100644
@@ -44,6 +44,9 @@ config REGEX
          regex support to some commands, for example "env grep" and
          "setexpr".
 
+config LIB_RAND
+       bool
+
 source lib/rsa/Kconfig
 
 menu "Hashing Support"
net/Kconfig +0 -0
index 524b7e4da23b..9a9846e18744 100644
@@ -10,6 +10,7 @@ if NET
Quoted 10 lines

net/Kconfig if NET · line 16

Quoted 6 lines
net/Kconfig +1 -0
 config NET_RANDOM_ETHADDR
        bool "Random ethaddr if unset"
+       select LIB_RAND
        help
          Selecting this will allow the Ethernet interface to function
          even when the ethaddr variable for that interface is unset.

Do you want me to run the moveconfig tool on this? I have a feeling it will just conflict anyway if not run on top of my other 2 patches for the defconfigs.

Definitely feel free to run it yourself.

Thanks,
Michal