Skip to contentSkip to conversation

fs_pin: Fix uninitialized value in fs_pin

PATCH New Kinglong Mee 1 participant 1 message Jun 2, 2015

Subsystems (3)
VFS NFS client NFS server
lore
Share & tools
lore

Kinglong Mee

author
#0 lore raw

PATCH v3 1/5 fs_pin: Fix uninitialized value in fs_pin

Avoid using kmalloc for memory allocationg without initialized, done in fs_pin at stack space may contains strange value.

v1 --> v3,
Adds macro for header file

Signed-off-by Kinglong Mee <[email protected]>
---
 include/linux/fs_pin.h | 6 ++++++
 1 file changed, 6 insertions(+)
include/linux/fs_pin.h +6 -0
index 3886b3b..0dde7b7 100644
@@ -1,3 +1,6 @@
+#ifndef _LINUX_FS_PIN_H
+#define _LINUX_FS_PIN_H
+
 #include <linux/wait.h>
 
 struct fs_pin {

@@ -16,9 +19,12 @@ static inline void init_fs_pin(struct fs_pin *p, void (*kill)(struct fs_pin *))
 	INIT_HLIST_NODE(&p->s_list);
 	INIT_HLIST_NODE(&p->m_list);
 	p->kill = kill;
+	p->done = 0;
 }
 
 void pin_remove(struct fs_pin *);
 void pin_insert_group(struct fs_pin *, struct vfsmount *, struct hlist_head *);
 void pin_insert(struct fs_pin *, struct vfsmount *);
 void pin_kill(struct fs_pin *);
+
+#endif
Signature · 1 line
2.4.2