NVMe: Add reset controller sysfs entry
A message that is not in the archive (sent off-list or not yet received): D195D453.84EA%[email protected]
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Quoted 9 lines · Keith Busch
Quoted 8 lines · David Sariel
Quoted 4 lines
Hi Keith, Jens,
Is everything ok with the patch? Do you need anything else from me? Thanks
DLooks goot to me. This is as far as I can take it though.
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 9 lines · Keith Busch
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Eww. Jens, can you please just apply this patch so that we're not having such a mess?
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 5 lines · Christoph Hellwig
Quoted 4 lines · Keith Busch
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
Quoted 8 lines
Quoted 5 lines
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Eww. Jens, can you please just apply this patch so that we're not having such a mess?
Yeah, I'll apply it now for 4.2.
Signature · 1 line
Jens Axboe
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 12 lines · Jens Axboe
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Keith Busch
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Quoted 4 lines
Quoted 2 lines
Eww. Jens, can you please just apply this patch so that we're not having such a mess?
Yeah, I'll apply it now for 4.2.
Well, that was a bit of a mess. Attached is my quick attempt at combining the two, and reusing the reset code from the ioctl path as well. One functional change was NOT flushing the work if we don't queue it in nvme_reset(), the previous code from Keith did that. Otherwise it should be straight forward.
Please review, I'll hold off on committing this.
Signature · 9 lines
Jens Axboe -------------- next part -------------- A non-text attachment was scrubbed... Name: nvme-reset.patch Type: text/x-patch Size: 3651 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-nvme/attachments/20150604/ff0c718e/attachment.bin>
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 16 lines · Jens Axboe
Quoted 15 lines · Jens Axboe
Quoted 13 lines · Christoph Hellwig
Quoted 9 lines · Keith Busch
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Eww. Jens, can you please just apply this patch so that we're not having such a mess?
Quoted 8 lines
Quoted 1 line
Yeah, I'll apply it now for 4.2.
Well, that was a bit of a mess. Attached is my quick attempt at combining the two, and reusing the reset code from the ioctl path as well. One functional change was NOT flushing the work if we don't queue it in
nvme_reset(), the previous code from Keith did that. Otherwise it should be straight forward.Please review, I'll hold off on committing this.
Hi Jens,
Thanks for fixing the merge. This tests successfully on my machine. I didn't have a strong opinion either way on what a user sees when requesting resets while a reset is in progress, and what you've merged looks good to me.
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 28 lines · Keith Busch
Quoted 24 lines · Jens Axboe
Quoted 12 lines · Jens Axboe
Quoted 11 lines · Christoph Hellwig
Quoted 9 lines · Keith Busch
Quoted 2 lines · Brandon Schulz
Do you plan to merge this into your legacy tree somewhere that we can reference in Bugzillas/etc. with the Linux distro vendors?
There is a strong preference with vendors to see fixes upstream prior to backporting but this is a long-standing percieved weakness in Linux vs. other operating systems; no one wants to reboot their machine for a f/w upgrade ... so, okay, I'll apply it to legacy and see if I can lobby OSVs to take out-of-stream fixes.
Quoted 4 lines
Quoted 2 lines
Eww. Jens, can you please just apply this patch so that we're not having such a mess?
Yeah, I'll apply it now for 4.2.
Well, that was a bit of a mess. Attached is my quick attempt at combining the two, and reusing the reset code from the ioctl path as well. One functional change was NOT flushing the work if we don't queue it in
nvme_reset(), the previous code from Keith did that. Otherwise it should be straight forward.
Quoted 8 lines
Quoted 1 line
Please review, I'll hold off on committing this.
Hi Jens,
Thanks for fixing the merge. This tests successfully on my machine. I didn't have a strong opinion either way on what a user sees when requesting resets while a reset is in progress, and what you've merged looks good to me.
Great, thanks Keith. Can I add your signed-off-by? It'd be most fair to attribute the patch to you, since the ioctl part is now just calling your reset function and all I did was shuffle some stuff around.
Signature · 1 line
Jens Axboe
PATCH 1/1 NVMe: Add reset controller sysfs entry
Quoted 9 lines · Jens Axboe
Quoted 4 lines · Keith Busch
Thanks for fixing the merge. This tests successfully on my machine. I didn't have a strong opinion either way on what a user sees when requesting resets while a reset is in progress, and what you've merged looks good to me.
Great, thanks Keith. Can I add your signed-off-by? It'd be most fair to attribute the patch to you, since the ioctl part is now just calling your reset function and all I did was shuffle some stuff around.
Sounds good to me. Thanks!