iio: twl4030-madc: Pass the IRQF_ONESHOT flag
PATCH 1/1 iio: twl4030-madc: Pass the IRQF_ONESHOT flag
From: Fabio Estevam <[email protected]>
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available in scripts/coccinelle/misc/irqf_oneshot.cocci.
--- drivers/iio/adc/twl4030-madc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/iio/adc/twl4030-madc.c +2 -1
@@ -835,7 +835,8 @@ static int twl4030_madc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 ); ret =devm_request_threaded_irq (&pdev->dev, irq,NULL , twl4030_madc_threaded_irq_handler, -IRQF_TRIGGER_RISING ,"twl4030_madc" , madc); +IRQF_TRIGGER_RISING |IRQF_ONESHOT , +"twl4030_madc" , madc);if (ret) {dev_err (&pdev->dev,"could not request irq\n" ); goto err_i2c;
Signature · 1 line
1.9.1
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
1c6c69525b40("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested withIRQF_ONESHOT, otherwise the request will fail.
Quoted 6 lines
So pass the
IRQF_ONESHOTflag in this case.The semantic patch that makes this change is available in
scripts/coccinelle/misc/irqf_oneshot.cocci.Signed-off-by Fabio Estevam <[email protected]>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Quoted 19 lines
--- drivers/iio/adc/twl4030-madc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/iio/adc/twl4030-madc.c +2
-1@@ -835,7 +835,8 @@ static int twl4030_madc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 ); ret =devm_request_threaded_irq (&pdev->dev, irq,NULL , twl4030_madc_threaded_irq_handler, -IRQF_TRIGGER_RISING ,"twl4030_madc" , madc); +IRQF_TRIGGER_RISING |IRQF_ONESHOT , +"twl4030_madc" , madc);if (ret) {dev_err (&pdev->dev,"could not request irq\n" ); goto err_i2c;