directfb: add an option for debugging support

DirectFB debugging support is enabled by default. This new option makes it possible to disable it (--disable-debug-support) and build the library with no debug feature at all.

NB: When debugging support is disabled, the target installation path is suffixed with -pure.

Signed-off-by C?dric Marie <[email protected]>

---
 package/directfb/Config.in   | 7 +++++++
 package/directfb/directfb.mk | 4 ++++
 2 files changed, 11 insertions(+)

package/directfb/Config.in +0 -0

index 7759f8f..0015c0c 100644

package/directfb/Config.in +2 -0

+
 config BR2_PACKAGE_DIRECTFB_DEBUG
 	bool "directfb debugging"
+	depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT
 	help
 	  Compile DirectFB with lots of debug output
 

package/directfb/directfb.mk +4 -0

index e3dc506..cf0609c 100644
@@ -39,9 +39,13 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion
 DIRECTFB_DEPENDENCIES += linux-fusion
 endif
 
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
 ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
 DIRECTFB_CONF_OPTS += --enable-debug
 endif
+else
+DIRECTFB_CONF_OPTS += --disable-debug-support
+endif
 
 ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y)
 DIRECTFB_CONF_OPTS += --enable-trace

I think the explanation you gave in your first mail would be valuable
here.

Certainly, the fact that the target installation path is suffixed with -pure
should be clarified.

Do all the packages that depend on directfb still build correctly with
this
-pure suffix?

Hi,

Le 2015-06-10 23:45, Arnout Vandecappelle a ?crit :

Quoted 1 line

I think the explanation you gave in your first mail would be valuable here.

OK. I didn't want to give too much details in the end, but you're right.

Quoted 5 lines

Certainly, the fact that the target installation path is suffixed with -pure should be clarified.

Do all the packages that depend on directfb still build correctly with this
-pure suffix?

The public library is not moved: /usr/lib/libdirectfb.so Only internal libraries are placed in a different directory:
/usr/lib/directfb-x.y.z-pure/
It contains following directories: gfxdrivers, inputdrivers, interfaces, systems, wm.
It makes no difference for applications using DFB.

Would you be satisfied with that description below, as a commit message?

DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These functions can be called inside DirectFB, or by an external DirectFB driver in another package.
The second one enables verbose mode in DirectFB, using these functions.

Buildroot currently provides an option for the second one only. The first one - which is necessary for the second one - is always enabled, because this is the default value.

The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible to disable debugging support (--disable-debug-support) in order to build the library with no debug feature at all.

When debugging support is disabled, the target installation path of internal libraries (/usr/lib/directfb-<version>) is suffixed with -pure. The public library (/usr/lib/libdirectfb.so) remains unchanged.

Some external DirectFB drivers will install in /usr/lib/directfb-<version>-pure in release mode. For that reason, it is important that DirectFB can be configured to use this directory.

Yes, but I was in fact mainly talking about the help text of the new option.

Hi,

Le 11/06/2015 22:32, Arnout Vandecappelle a ?crit :

Quoted 1 line

Yes, but I was in fact mainly talking about the help text of the new option.

Oops, sorry.
But I suppose I shouldn't give so much details in the help text, as in the commit message.
What do you think is important to mention?

Here is a proposal, feel free to comment/modify:

Compile DirectFB with debugging support. It provides functions to print debug information, for DirectFB as well as external DirectFB drivers. When disabled, DirectFB has got no debug feature at all, and the directory that

contains the internal libraries is suffixed with -pure (/usr/lib/directfb-<version>-pure/).

NB: I'm not really satisfied with "internal libraries", but I can't find the right expression for that. It contains gfx drivers, but not only...

When disabled, DirectFB does not print any debug information. The drivers will
be installed to and loaded from /usr/lib/directfb-<version>-pure instead of
/usr/lib/directfb-<version>.

gfx drivers, input drivers, window systems drivers, ... I think it's
drivers
:-) Only interfaces doesn't fit.