Skip to contentSkip to conversation

locale.5: remove the FIXME for timezone

PATCH In review Marko Myllynen 2 participants 2 messages Jun 9, 2015 – Jun 12, 2015 1 message not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 locale.5: remove the FIXME for timezone

Hi Michael,

the timezone of LC_TIME is not in POSIX, only 6 (out of ~300) glibc locales define it, the glibc code comment below from glibc.git/programs/ld-time.c seems to suggest it's not a good idea, and there's been a proposal in upstream [1] to remove the existing timezone definitions from glibc locales so I think it's actually better to leave this one undocumented:

/* XXX We don't perform any tests on the timezone value since this is
simply useless, stupid $&$!@... */

1) https://sourceware.org/ml/libc-alpha/2015-06/msg00098.html

Move the remaining LC_COLLATE FIXMEs together while at it.

---
 man5/locale.5 |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
man5/locale.5 +4 -6
index 2a2edc1..556c745 100644
@@ -512,6 +512,10 @@ in the first column.
 
 The following keywords are allowed:
 .\" FIXME The following LC_COLLATE keywords are not documented:
+.\" 	reorder-after
+.\" 	reorder-end
+.\" 	reorder-sections-after
+.\" 	reorder-sections-end
 .\" 	script
 .\" 	symbol-equivalence
 .TP
@@ -534,11 +538,6 @@ or
 The order definition consists of lines that describe the order
 and is terminated with the keyword
 .IR order_end .
-.\" FIXME The following LC_COLLATE keywords are not documented:
-.\" 	reorder-after
-.\" 	reorder-end
-.\" 	reorder-sections-after
-.\" 	reorder-sections-end
 .PP
 The
 .B LC_COLLATE
@@ -1073,7 +1072,6 @@ The following keywords are allowed:
 .\"	era_d_fmt
 .\"	era_d_t_fmt
 .\"	era_t_fmt
-.\"	timezone
 .TP
 .I abday
 followed by a list of abbreviated names of the days of the week.

Thanks,

Signature · 5 lines
Marko Myllynen
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 8 lines · Marko Myllynen

Hi Michael,

the timezone of LC_TIME is not in POSIX, only 6 (out of ~300) glibc locales define it, the glibc code comment below from glibc.git/programs/ld-time.c seems to suggest it's not a good idea, and there's been a proposal in upstream [1] to remove the existing timezone definitions from glibc locales so I think it's actually better to leave this one undocumented:

Thanks, Marko. Applied.

Cheers,

Michael

Quoted 49 lines

/* XXX We don't perform any tests on the timezone value since this is
simply useless, stupid $&$!@... */

1) https://sourceware.org/ml/libc-alpha/2015-06/msg00098.html

Move the remaining LC_COLLATE FIXMEs together while at it.

---
 man5/locale.5 |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
man5/locale.5 +4 -6
index 2a2edc1..556c745 100644
@@ -512,6 +512,10 @@ in the first column.
 
 The following keywords are allowed:
 .\" FIXME The following LC_COLLATE keywords are not documented:
+.\" 	reorder-after
+.\" 	reorder-end
+.\" 	reorder-sections-after
+.\" 	reorder-sections-end
 .\" 	script
 .\" 	symbol-equivalence
 .TP
@@ -534,11 +538,6 @@ or
 The order definition consists of lines that describe the order
 and is terminated with the keyword
 .IR order_end .
-.\" FIXME The following LC_COLLATE keywords are not documented:
-.\" 	reorder-after
-.\" 	reorder-end
-.\" 	reorder-sections-after
-.\" 	reorder-sections-end
 .PP
 The
 .B LC_COLLATE
@@ -1073,7 +1072,6 @@ The following keywords are allowed:
 .\"	era_d_fmt
 .\"	era_d_t_fmt
 .\"	era_t_fmt
-.\"	timezone
 .TP
 .I abday
 followed by a list of abbreviated names of the days of the week.

Thanks,

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html