directfb: add an option for debugging support
PATCH 1/1 directfb: add an option for debugging support
DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These functions can be called inside DirectFB, or by an external DirectFB driver in another package.
The second one enables verbose mode in DirectFB, using these functions.
Buildroot currently provides an option for the second one only. The first one - which is necessary for the second one - is always enabled, because this is the default value.
The new option (BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible to disable debugging support (--disable-debug-support) in order to build the library with no debug feature at all.
When debugging support is disabled, the target installation path of drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The public library (/usr/lib/libdirectfb.so) remains unchanged.
Some external DirectFB drivers will install into /usr/lib/directfb-<version>-pure in release mode. For that reason, it is important that DirectFB can be configured to use this directory.
--- package/directfb/Config.in | 14 ++++++++++++++ package/directfb/directfb.mk | 4 ++++ 2 files changed, 18 insertions(+)
package/directfb/Config.in +14 -0
@@ -20,8 +20,22 @@ config BR2_PACKAGE_DIRECTFB_MULTI comment "directfb multi application needs a Linux kernel to be built" depends on !BR2_LINUX_KERNEL +config BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT + bool "directfb debugging support" + default y + help + Compile DirectFB with debugging support. It provides + functions to print debug information, for DirectFB as well as + external DirectFB drivers. + + When disabled, DirectFB does not print any debug information. + The drivers will be installed to and loaded from + /usr/lib/directfb-<version>-pure instead of + /usr/lib/directfb-<version>. + config BR2_PACKAGE_DIRECTFB_DEBUG bool "directfb debugging" + depends on BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT help Compile DirectFB with lots of debug output
package/directfb/directfb.mk +4 -0
@@ -39,9 +39,13 @@ DIRECTFB_CONF_OPTS += --enable-multi --enable-fusion DIRECTFB_DEPENDENCIES += linux-fusion endif +ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y) ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y) DIRECTFB_CONF_OPTS += --enable-debug endif +else +DIRECTFB_CONF_OPTS += --disable-debug-support +endif ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y) DIRECTFB_CONF_OPTS += --enable-trace
Signature · 1 line
2.1.4
PATCH 1/1 directfb: add an option for debugging support
Quoted 25 lines · C?dric Marie
DirectFB provides two options for debug:
* --enable-debug-support (default is yes)
* --enable-debug (default is no)
The first one provides the functions to print debug information. These functions can be called inside DirectFB, or by an external DirectFB driver in another package.
The second one enables verbose mode in DirectFB, using these functions.Buildroot currently provides an option for the second one only. The first one - which is necessary for the second one - is always enabled, because this is the default value.
The new option (
BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT) makes it possible to disable debugging support (--disable-debug-support) in order to build the library with no debug feature at all.When debugging support is disabled, the target installation path of drivers (/usr/lib/directfb-<version>) is suffixed with -pure. The public library (
/usr/lib/libdirectfb.so) remains unchanged.Some external DirectFB drivers will install into /usr/lib/directfb-<version>-pure in release mode. For that reason, it is important that DirectFB can be configured to use this directory.
Signed-off-by C?dric Marie <[email protected]>
[snip]
Quoted 4 lines
+ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG_SUPPORT),y)
ifeq ($(BR2_PACKAGE_DIRECTFB_DEBUG),y)
DIRECTFB_CONF_OPTS+= --enable-debug
endif
There should be a --enable-debug-support somewhere around here,
Regards,
Arnout
Quoted 7 lines
package/directfb/directfb.mk +3
-0+else +DIRECTFB_CONF_OPTS += --disable-debug-support +endif ifeq ($(BR2_PACKAGE_DIRECTFB_TRACE),y) DIRECTFB_CONF_OPTS += --enable-trace
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 directfb: add an option for debugging support
Le 2015-06-15 00:07, Arnout Vandecappelle a ?crit?:
Quoted 1 line
There should be a --enable-debug-support somewhere around here,
You're right, that would be safer. In case they change the default value.
I will add it.
But I can't see any clear rule for that...
--enable-multi, --enable-fusion, --enable-debug, --enable-trace have no disable counterpart.
--enable-x11, --enable-unique, --enable-gif do have a --disable counterpart.
Moreover, there is a --disable-multi for host-directfb, while it is assumed to be the default for directfb (--enable-multi with no counterpart).
Signature · 1 line
C?dric
PATCH 1/1 directfb: add an option for debugging support
Quoted 6 lines · C?dric Marie
Le 2015-06-15 00:07, Arnout Vandecappelle a ?crit :
Quoted 1 line
There should be a --enable-debug-support somewhere around here,
You're right, that would be safer. In case they change the default value. I will add it.
Quoted 7 lines
But I can't see any clear rule for that...
--enable-multi, --enable-fusion, --enable-debug, --enable-trace have no disable counterpart.
--enable-x11, --enable-unique, --enable-gif do have a --disable counterpart.Moreover, there is a --disable-multi for host-directfb, while it is assumed to be the default for directfb (--enable-multi with no counterpart).
Historical accident. Nowadays we try to enforce enable/disable pairs during review.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F