3.4.107: Wrong back port of "PCI: Handle read-only BARs on AMD CS553x devices"?
Hi,
from a private 3.4.107 review I've got the comment that
PCI: Handle read-only BARs on AMD CS553x devices
might be wrongly back ported to 3.4.107: The problem is that the prototype of pcibios_bus_to_resource() was changed by commit fc27985 "PCI: Convert pcibios_resource_to_bus() to take a pci_bus, not a pci_dev" in v3.14, but this commit was not back ported to the v3.4.y stable series [1].
Best regards
Dirk
[1]
drivers/pci/quirks.c: In function ‘quirk_io’:drivers/pci/quirks.c:351:26: warning: passing argument 1 of ‘pcibios_bus_to_resource’ from incompatible pointer type
pcibios_bus_to_resource(dev->bus, res, &bus_region);
^
In file included from drivers/pci/quirks.c:21:0:
include/linux/pci.h:653:6: note: expected ‘struct pci_dev *’ but argument is of type ‘struct pci_bus *’
void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res,
^Quoted 10 lines · Dirk Behme
Hi,
from a private 3.4.107 review I've got the comment that
PCI: Handle read-only BARs on AMD CS553x devices
might be wrongly back ported to 3.4.107: The problem is that the prototype of
pcibios_bus_to_resource()was changed by commit fc27985 "PCI: Convertpcibios_resource_to_bus()to take apci_bus, not apci_dev" in v3.14, but this commit was not back ported to the v3.4.y stable series [1].
I've backported fc27985 to 3.4 to fix this. Thanks!
Quoted 19 lines
Best regards
Dirk
[1]
drivers/pci/quirks.c: In function ‘quirk_io’:drivers/pci/quirks.c:351:26: warning: passing argument 1 of ‘pcibios_bus_to_resource’ from incompatible pointer typepcibios_bus_to_resource(dev->bus, res, &bus_region); ^ In file included from drivers/pci/quirks.c:21:0: include/linux/pci.h:653:6: note: expected ‘struct pci_dev *’ but argument is of type ‘struct pci_bus *’ void pcibios_bus_to_resource(struct pci_dev *dev, struct resource *res, ^Signature · 3 lines
To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html